aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Use CCTK_VError in some placeseschnett2013-02-26
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1574 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Dont use initial guess origins from parameters when tracking from gridscalarrhaas2013-02-02
| | | | | | | | | | | | | | | | Problem: My horizon will appear sometimes during the simulation at some position. I don't know this position in advance, so I set origin_* and AHFinderDirect::initial_guesscoord_sphere*_center to zero initially in my par-file. However, I have a grid scalar which tracks the coordinate location where the horizon will eventually appear. When the horizon finder starts to search for a horizon, it will first setup the coordinate ellipsoid. This routine is executed *before* the new origin is set from the grid scalar. The tracking occurs in the routine Newton(...). The ellipsoid is set before Newton(...) gets executed. Hence, the ellipsoid uses the value that got set via parameters (which would be zero in my case). Patch by Christian Reisswig git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1573 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Dont use recovered origin if AH was never foundrhaas2013-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | Problem: After some time in the simulation, I want to search for an horizon. I do not know where the horizon appears initially when the simulation started. I therefore leave origin_* and initial_guesscoord_sphere*_center at zero. By some means later, I have figured out where the horizon will appear. Therefore, after recovery, I want to set origin_* and initial_guesscoord_sphere*_center to the origin where I believe the horizon will appear. Unfortunately, upon recovery, the new origin_* is overwritten by whatever was stored in ah_origin_* (this would be zero). Generally, this means that the initial guess ellipsoid that is setup when a horizon has never been found, is ill-posed (because the initial (and incorrect) origin_* are used with the updated initial_guesscoord_sphere*_center). Solution: Don't use the stored AH origin upon recovery when a horizon has never been found before. Patch by Christian Reisswig git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1572 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Initialize Cactus grid scalar with data from internal data structuresrhaas2012-10-29
| | | | | | | | | | | | | | | | | | | | | this is avoids errors when new horizons are turned on in a checkpoint recovery. The reason is that AHFinderDirect attempts to initialize its internal variables from checkpointed data (in particular the patch system origin). Since the new horizons did not exist at the time of checkpoint (and the whole variable is missing) the recovery routine in CarpetIOHDF5 reads in no data which leaves the Cactus group uninitialized which in turn leads to invalid values in AHFinderDirect's internal data structures. The attached fix circumvents this by having AHFinderDirect initialize the Cactus group from its internal data structures (which it constructed from the parameters) at BaseGrid. This way, any newly created horizon will retain the values from the parameter file, but existing ones have their values overwritten. git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1569 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Use optional HDF5 capabilityhinder2012-05-14
| | | | | | The previous method no longer works git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1565 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Support CCTK_REAL4eschnett2012-05-12
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1564 f88db872-0e4f-0410-b76b-b9085cfa78c5
* support named spherical surfacesrhaas2012-01-24
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1562 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Correct commentschnetter2009-02-04
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1538 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Add new parameters track_origin_from_grid_scalar. They tellschnetter2008-10-04
| | | | | | | | AHFinderDirect to look at certain grid scalars to reset the origin used for horizon finding. git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1530 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Make "Erik" branch the default trunk for AHFinderDirect.svnadmin2008-06-26
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1526 f88db872-0e4f-0410-b76b-b9085cfa78c5
* make HorizonCentroid aliased fn return the correct valuejthorn2006-09-25
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1470 f88db872-0e4f-0410-b76b-b9085cfa78c5
* add a new aliased functionjthorn2006-09-25
| | | | | | | | HorizonCentroid() so other thorns can query the horizon centroid git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1469 f88db872-0e4f-0410-b76b-b9085cfa78c5
* rename local variable 'r' to 'local_r' to avoid conflict with gridfn Grid::rjthorn2006-08-31
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1463 f88db872-0e4f-0410-b76b-b9085cfa78c5
* remove trailing semicolon afterjthorn2006-07-21
| | | | | | | | | namespace foo { ... } (C++ forbids this; I had used it by mistake) git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1460 f88db872-0e4f-0410-b76b-b9085cfa78c5
* fix a nasty bug (which led to wrong AHFs being found):jthorn2006-07-17
| | | | | | | | | | | | if StaticConformal is active and StaticConformal::metric_type == "static conformal" and StaticConformal::conformal_state == 0 (so no conformal factor is actually in effect, and in fact storage may not even be turned on for the psi gridfn) the code mistakenly used the psi gridfn anyway git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1459 f88db872-0e4f-0410-b76b-b9085cfa78c5
* * when printing the verbose message about each grid that we're settingjthorn2006-05-25
| | | | | | | | | | a mask for, also include the grid spacing in the message (this makes it easier to identify which refinement level this is) * adjust wording of message to no longer imply that there's only a single grid (= Carpet component here) per processor git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1451 f88db872-0e4f-0410-b76b-b9085cfa78c5
* move another mask-setting message from "algorithm debug" up tojthorn2006-05-25
| | | | | | | "algorithm details" git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1450 f88db872-0e4f-0410-b76b-b9085cfa78c5
* change printing of messages that we're setting an excision mask, egjthorn2006-05-25
| | | | | | | | | | | | | | | | | | | INFO (AHFinderDirect): setting old-style (CCTK_REAL) mask grid function SpaceMask::emask INFO (AHFinderDirect): setting old-style (CCTK_REAL) mask grid function SpaceMask::emask INFO (AHFinderDirect): setting old-style (CCTK_REAL) mask grid function SpaceMask::emask so they're printed at "algorithm highlights" and higher verbosity settings (before they were only printed at "algorithm details" and higher settings Discussion: At "algorithm highlights" we already print a message each time we write a horizon-shape data file, and each time we set the SphericalSurface variables, so it seems consistent to also print a message each time we set an excision mask. People who don't want to see lots of output from AHFinderDirect won't be using "algorithm highlights" anyway, and so shouldn't be bothered by this change... git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1449 f88db872-0e4f-0410-b76b-b9085cfa78c5
* detect whether we're in a checkpoint-recover recovery,jthorn2006-04-25
| | | | | | | | | | | | and if so *append* to BH_diagnostics files rather than truncating them -- thanks to Luca for reporting this bug and pesting us for a fix, to Erik for helpful discussions, and to Steve for a patch which forms the basis for this commit (tweaked to be in AHFinderDirect style) git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1443 f88db872-0e4f-0410-b76b-b9085cfa78c5
* * implement new verbose_level option "no output"jthorn2005-06-14
| | | | | | | | * decrease the default verbose_level from "algorithm highlights" down to "physics details" git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1423 f88db872-0e4f-0410-b76b-b9085cfa78c5
* change the code so messagesjthorn2005-06-14
| | | | | | | | | | setting old-style (CCTK_REAL) mask ... setting new-style (CCTK_INT) mask ... will only be printed at the "algorithm details" verbosity level (formerly they'd be printed at the "algorithm highlights" level) git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1422 f88db872-0e4f-0410-b76b-b9085cfa78c5
* implement verbose_level = "physics highlights"jthorn2005-06-14
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1421 f88db872-0e4f-0410-b76b-b9085cfa78c5
* increase buffer sizes a bitjthorn2005-06-14
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1420 f88db872-0e4f-0410-b76b-b9085cfa78c5
* fix a bug found by Yosef Zlochower:jthorn2005-06-14
| | | | | | | | | | | | | | | | | | | | | | In a multiprocessor run, AHFinderDirect finds different horizons in parallel on different processors, and doesn't broadcast horizon shapes to all processors unless it thinks they'll be needed. However, the "the information will be needed" calculation doesn't take into account the possibility of the HorizonRadiusInDirection() aliased function being called on another processor, and in this case this function returns a wrong result if AHFinderDirect hasn't broadcast the horizon shapes. * introduce a new Boolean parameter always_broadcast_horizon_shape (defaults to false) * document in interface.ccl, param.ccl, and doc/documentation.tex, that this parameter should be set to true if you expect HorizonRadiusInDirection() to be used * inclusive-or this parameter into the "should we broadcast the horizon shape?" calculation in src/driver/find_horizons.cc git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1419 f88db872-0e4f-0410-b76b-b9085cfa78c5
* clarify commentjthorn2005-06-13
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1418 f88db872-0e4f-0410-b76b-b9085cfa78c5
* += select.planejthorn2005-05-31
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1412 f88db872-0e4f-0410-b76b-b9085cfa78c5
* note non-use of C++ exceptionsjthorn2005-05-02
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1405 f88db872-0e4f-0410-b76b-b9085cfa78c5
* make some of the mask parameters steerable (finally!!!)jthorn2005-02-28
| | | | | | | -- thanks to Frank Loeffler for the basic patches for this git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1397 f88db872-0e4f-0410-b76b-b9085cfa78c5
* remove an (unnecessary)jthorn2005-02-19
| | | | | | | | | #include <vector> that I committed by accident and that was causing compilation headaches on Macs git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1396 f88db872-0e4f-0410-b76b-b9085cfa78c5
* fix a C++ namespaces bug found by Erik:jthorn2005-02-01
| | | | | | | | | | | | | | | error_exit() was declared extern "C" --> it wasn't namespace-mangled --> it could conflict with a similar error_exit() in another thorn although this fix touches a *lot* of files, it's conceptually simple: * error_exit() is not extern "C" any more * everything in src/jtutil/ (which used to be in the jtutil:: namespace) is now in the AHFinderDirect::jtutil:: namespace --> all C++ code in this thorn is now inside the AHFinderDirect:: namespace git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1395 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Fix a problem found by Erik Schnetter & Thomas Radke involvingjthorn2005-01-04
| | | | | | | | | | | | | | | | | | writing data to the SphericalSurface variables in a multiprocessor run. In detail, the code writes data to the SphericalSurface variables on each processor. For everything except the horizon shape this is fine. However, the code formerly didn't broadcast the horizon shape to all processors, so the values written to the SphericalSurface variables were all 0 on processors other than the one that actually found that horizon. The fix is to broadcast the horizon shape if any horizon info is being written to the SphericalSurface variables. (In addition to broadcasting it whenever an excision mask is being set, which the code already did.) git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1392 f88db872-0e4f-0410-b76b-b9085cfa78c5
* print_unknown_gridfn():jthorn2004-10-04
| | | | | | | | | add an "origin" comment to the output file to match Erik's branch --> helps with visualization, we hope git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1385 f88db872-0e4f-0410-b76b-b9085cfa78c5
* remove local copy of irreducible_mass in BH_diagnostics::print()jthorn2004-08-25
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1379 f88db872-0e4f-0410-b76b-b9085cfa78c5
* change output format for cctk_time from %.3f to %fjthorn2004-08-25
| | | | | | | | since the lines are already long anyway (so a few more characters won't hurt) and some tests (like the ones I'm doing right now!) need the extra precision git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1378 f88db872-0e4f-0410-b76b-b9085cfa78c5
* disable automagic template instantiation on SGI CC compilerjthorn2004-07-01
| | | | | | | | | | | | because it's totally broken: if file A contains #include "../jtutil/array.hh" the compiler tries to also #include "../jtutil/array.cc" (even though I didn't ask for that file)... then it gets fatal errors when it can't resolve relative include paths for *that* file :( git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1375 f88db872-0e4f-0410-b76b-b9085cfa78c5
* after recent discussions with Erik about SphericalSurface, we've agreed thatjthorn2004-06-04
| | | | | | | | | | | sf_mean_radius = mean *coordinate* radius (alas, not yet clearly *documented* in SphericalSurface) sf_area = proper area (newly added to SphericalSurface) ==> change this code to store the right things git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1362 f88db872-0e4f-0410-b76b-b9085cfa78c5
* add another FIXME comment to the code which accesses the surface shape:jthorn2004-05-21
| | | | | | | | | | // * It would be cleaner to abstract out the (complicated) indexing // calculation for the SphericalSurface shape array into a separate // access structure/function, the way we do with struct cactus_grid_info // for grid functions. git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1353 f88db872-0e4f-0410-b76b-b9085cfa78c5
* * add interface to Erik's SphericalSurface thornjthorn2004-05-12
| | | | | | | | | | | | | | ==> With this commit, AHFinderDirect now inherits from AEIThorns/SphericalSurface, so you must have that thorn in your configuration to be able to compile. * add computation of surface quadrupole moments and areal radius * expand BH_diagnostics file format to accomodate quadrupole moments and areal radius, and also to include not-implemented-yet columns for 9 more diagnostics which Erik has implemented in his branch * some other small cleanups git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1329 f88db872-0e4f-0410-b76b-b9085cfa78c5
* remove unneededjthorn2004-05-06
| | | | | | | #include "cctk_Arguments.h" git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1322 f88db872-0e4f-0410-b76b-b9085cfa78c5
* * copy Cactus parameters to our local data structures,jthorn2004-05-05
| | | | | | | | | | then use these copies, rather than looking at the "global variable" Cactus parameters all over the place * given the above change, drop most #include "cctk_Parameters.h" and DECLARE_CCTK_PARAMETERS git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1320 f88db872-0e4f-0410-b76b-b9085cfa78c5
* expand/clarify comments -- no changes to executable codejthorn2004-04-29
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1315 f88db872-0e4f-0410-b76b-b9085cfa78c5
* change all occurences of CCTK_VWarn(1, ...)jthorn2004-04-27
| | | | | | | | to CCTK_VWarn(SERIOUS_WARNING, ...) to make the semantics clearer git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1314 f88db872-0e4f-0410-b76b-b9085cfa78c5
* refactor some code so file naming conventions are more explicitjthorn2004-04-27
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1313 f88db872-0e4f-0410-b76b-b9085cfa78c5
* * change fatal-error CCTK_VWarn() level from -1 to 0jthorn2004-04-27
| | | | | | | * introduce SERIOUS_WARNING macro for "level 1" errors git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1312 f88db872-0e4f-0410-b76b-b9085cfa78c5
* script to select xy/xz/yz-plane from AHFinderDirect output filesjthorn2004-04-21
| | | | | | | | (this is a kludge; it would be better for AHFinderDirect to have options to output plane intersections directly) git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1310 f88db872-0e4f-0410-b76b-b9085cfa78c5
* allow any number of # characters in marker commentsjthorn2004-03-15
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1293 f88db872-0e4f-0410-b76b-b9085cfa78c5
* document standard variable names for various data structuresjthorn2004-03-01
| | | | | | | used throughout the code git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1282 f88db872-0e4f-0410-b76b-b9085cfa78c5
* describe the rest of the files herejthorn2004-02-12
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1271 f88db872-0e4f-0410-b76b-b9085cfa78c5
* describe aliased_functions.ccjthorn2004-02-12
| | | | git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1270 f88db872-0e4f-0410-b76b-b9085cfa78c5
* Cleanup the aliased-function interface:jthorn2004-02-12
| | | | | | | | | | | | | | | | | * rename (delete-and-add in CVS :( ) the file which implements it from src/driver/horizon_radius.cc to src/driver/aliased_functions.cc * fix some off-by-one errors in checking the horizon number * add a new aliased function to allow querying of whether or not a given horizon was found the last time we looked for it * all the aliased functions are now *functions* returning a status code (>= 0 for ok, < 0 for error), instead of subroutines before * document the whole thing in the thorn guide (this was missing before :( ) N.b. you will need a make YOUR_CONFIG_NAME-cleandeps after this cvs update git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1267 f88db872-0e4f-0410-b76b-b9085cfa78c5