diff options
| author | jthorn <jthorn@f88db872-0e4f-0410-b76b-b9085cfa78c5> | 2004-05-21 15:38:17 +0000 |
|---|---|---|
| committer | jthorn <jthorn@f88db872-0e4f-0410-b76b-b9085cfa78c5> | 2004-05-21 15:38:17 +0000 |
| commit | 99c4c866efaea32c56ce56b010564c8b0bf734da (patch) | |
| tree | 5ecae96703a836bf2d2a6069b08e8985d74f1e7a /src | |
| parent | c2bf0a9b0c3533a5df6c967a8aac645ee8111c68 (diff) | |
add another FIXME comment to the code which accesses the surface shape:
// * It would be cleaner to abstract out the (complicated) indexing
// calculation for the SphericalSurface shape array into a separate
// access structure/function, the way we do with struct cactus_grid_info
// for grid functions.
git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@1353 f88db872-0e4f-0410-b76b-b9085cfa78c5
Diffstat (limited to 'src')
| -rw-r--r-- | src/driver/spherical_surface.cc | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/src/driver/spherical_surface.cc b/src/driver/spherical_surface.cc index 20617bd..df08da7 100644 --- a/src/driver/spherical_surface.cc +++ b/src/driver/spherical_surface.cc @@ -193,12 +193,17 @@ DECLARE_CCTK_ARGUMENTS // part of the 2-D array that's actually used. // sf_radius = (out) The SphericalSurface radius. // -// FIXME: The present implementation is quite inefficient, as it calls -// patch_system::radius_in_local_xyz_direction() (which does a -// separate interpolator call) for each point. It would be more -// efficient to have a new patch_system:: API which operated -// on a whole array of points at once, to amortize the interpolator -// overhead. +// FIXME: +// * The present implementation is quite inefficient, as it calls +// patch_system::radius_in_local_xyz_direction() (which does a +// separate interpolator call) for each point. It would be more +// efficient to have a new patch_system:: API which operated +// on a whole array of points at once, to amortize the interpolator +// overhead. +// * It would be cleaner to abstract out the (complicated) indexing +// calculation for the SphericalSurface shape array into a separate +// access structure/function, the way we do with struct cactus_grid_info +// for grid functions. // namespace { void store_horizon_shape(CCTK_ARGUMENTS, |