diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/driver/spherical_surface.cc | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/src/driver/spherical_surface.cc b/src/driver/spherical_surface.cc index 20617bd..df08da7 100644 --- a/src/driver/spherical_surface.cc +++ b/src/driver/spherical_surface.cc @@ -193,12 +193,17 @@ DECLARE_CCTK_ARGUMENTS // part of the 2-D array that's actually used. // sf_radius = (out) The SphericalSurface radius. // -// FIXME: The present implementation is quite inefficient, as it calls -// patch_system::radius_in_local_xyz_direction() (which does a -// separate interpolator call) for each point. It would be more -// efficient to have a new patch_system:: API which operated -// on a whole array of points at once, to amortize the interpolator -// overhead. +// FIXME: +// * The present implementation is quite inefficient, as it calls +// patch_system::radius_in_local_xyz_direction() (which does a +// separate interpolator call) for each point. It would be more +// efficient to have a new patch_system:: API which operated +// on a whole array of points at once, to amortize the interpolator +// overhead. +// * It would be cleaner to abstract out the (complicated) indexing +// calculation for the SphericalSurface shape array into a separate +// access structure/function, the way we do with struct cactus_grid_info +// for grid functions. // namespace { void store_horizon_shape(CCTK_ARGUMENTS, |