diff options
author | rhaas <rhaas@b32723a9-ab3a-4a60-88e2-2e5d99d7c17a> | 2012-06-11 18:35:24 +0000 |
---|---|---|
committer | rhaas <rhaas@b32723a9-ab3a-4a60-88e2-2e5d99d7c17a> | 2012-06-11 18:35:24 +0000 |
commit | 928b224243e765d0fc700e84f42d7c0f2204fe3d (patch) | |
tree | 5d1e065a9717a57e7814527ef2bfbbd39110268d /doc | |
parent | c393be9824383f44bec91c337e0ff7c6ce3e3cfc (diff) |
IOUtil: abort IOUtil_TruncateOutputFiles if called too early
currently when called before the grid extension for IOUtil has been registered
(which is when IOUtils learns if the is a checkpoint recovery run or not), the
routine returns -1. However the documentation in the thorn guide states that
Thorn IOUtil provides an aliased function for other I/O thorns to call:
CCTK_INT FUNCTION IO_TruncateOutputFiles (CCTK_POINTER_TO_CONST IN cctkGH)
This function simply returns 1 or 0 if output files should or should not be
truncated.
Since there are thorns out there that take this to heart and test for
IO_TruncateOutputFiles() being true (ie non-zero) these thorns always overwrite
data during a recovery when calling IOUtils too early. This happened to Carpet
in ticket #908.
The attached patch makes IOUtil abort instead which seems better than silently
returning the wrong (since undocumented) answer. No actual user thorn should be
affected.
git-svn-id: http://svn.cactuscode.org/arrangements/CactusBase/IOUtil/trunk@289 b32723a9-ab3a-4a60-88e2-2e5d99d7c17a
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions