1 files changed, 34 insertions, 43 deletions

diff --git a/users/drashna/tap_dances.c b/users/drashna/tap_dances.c
index 18ca96e187..65019ab751 100644
--- a/users/drashna/tap_dances.c
+++ b/users/drashna/tap_dances.c
@@ -1,65 +1,56 @@
 #include "tap_dances.h"
 
+#define NUM_OF_DIABLO_KEYS 4
+// define diablo macro timer variables
+diablo_timer_t diablo_timer[NUM_OF_DIABLO_KEYS];
 
-//define diablo macro timer variables
-diablo_timer_t diablo_timer[4];
-
-uint8_t diablo_times[] = { 0, 0, 1, 3, 5, 10, 30 };
-
-// has the correct number of seconds elapsed (as defined by diablo_times)
-bool check_dtimer(uint8_t dtimer) { return (timer_elapsed(diablo_timer[dtimer].key_time) < (diablo_timer[dtimer].timer * 1000)) ? false : true; };
+// Set the default intervals.  Always start with 0 so that it will disable on first hit.
+// Otherwise, you will need to hit a bunch of times, or hit the "clear" command
+uint8_t diablo_times[] = {0, 1, 3, 5, 10, 30};
 
 // Cycle through the times for the macro, starting at 0, for disabled.
-// Max of six values, so don't exceed
 void diablo_tapdance_master(qk_tap_dance_state_t *state, void *user_data) {
-    int index = (int)user_data;
-    if (state->count >= 7) {
-        diablo_timer[index].key_time = diablo_times[0];
+    diable_keys_t *diablo_keys = (diable_keys_t *)user_data;
+    // Sets the keycode based on the index
+    diablo_timer[diablo_keys->index].keycode = diablo_keys->keycode;
+
+    // if the tapdance is hit more than the number of elemints in the array, reset
+    if (state->count >= (sizeof(diablo_times) / sizeof(uint8_t))) {
+        diablo_timer[diablo_keys->index].key_interval = 0;
         reset_tap_dance(state);
-    }  else {
-        diablo_timer[index].key_time = diablo_times[state->count];
+    } else {  // else set the interval (tapdance count starts at 1, array starts at 0, so offset by one)
+        diablo_timer[diablo_keys->index].key_interval = diablo_times[state->count - 1];
     }
 }
 
-// One funtion to rule them all!!
-#define ACTION_TAP_DANCE_DIABLO(arg) {  \
+// clang-format off
+// One function to rule them all!!  Where the Magic Sauce lies
+#define ACTION_TAP_DANCE_DIABLO(index, keycode) {  \
     .fn = { NULL, (void *)diablo_tapdance_master, NULL }, \
-    .user_data = (void *)arg,  \
+    .user_data = (void *)&((diable_keys_t) { index, keycode }),  \
   }
+// clang-format on
 
-//Tap Dance Definitions
+// Tap Dance Definitions, sets the index and the keycode.
 qk_tap_dance_action_t tap_dance_actions[] = {
     // tap once to disable, and more to enable timed micros
-    [TD_D3_1] = ACTION_TAP_DANCE_DIABLO(0),
-    [TD_D3_2] = ACTION_TAP_DANCE_DIABLO(1),
-    [TD_D3_3] = ACTION_TAP_DANCE_DIABLO(2),
-    [TD_D3_4] = ACTION_TAP_DANCE_DIABLO(3),
+    [TD_D3_1] = ACTION_TAP_DANCE_DIABLO(0, KC_1),
+    [TD_D3_2] = ACTION_TAP_DANCE_DIABLO(1, KC_2),
+    [TD_D3_3] = ACTION_TAP_DANCE_DIABLO(2, KC_3),
+    [TD_D3_4] = ACTION_TAP_DANCE_DIABLO(3, KC_4),
 };
 
-// Sends the key press to system, but only if on the Diablo layer
-void send_diablo_keystroke(uint8_t diablo_key) {
-    if (IS_LAYER_ON(_DIABLO)) {
-        switch (diablo_key) {
-        case 0:
-            tap_code(KC_1); break;
-        case 1:
-            tap_code(KC_2); break;
-        case 2:
-            tap_code(KC_3); break;
-        case 3:
-            tap_code(KC_4); break;
-        }
-    }
-}
-
 // Checks each of the 4 timers/keys to see if enough time has elapsed
-// Runs the "send string" command if enough time has passed, and resets the timer.
 void run_diablo_macro_check(void) {
-    uint8_t dtime;
-    for (dtime = 0; dtime < 4; dtime++) {
-        if (check_dtimer(dtime) && diablo_timer[dtime].key_time) {
-        diablo_timer[dtime].timer = timer_read();
-        send_diablo_keystroke(dtime);
+    for (uint8_t index = 0; index < NUM_OF_DIABLO_KEYS; index++) {
+        // if key_interval is 0, it's disabled, so only run if it's set.  If it's set, check the timer.
+        if (diablo_timer[index].key_interval && timer_elapsed(diablo_timer[index].timer) > (diablo_timer[index].key_interval * 1000)) {
+            // reset the timer, since enough time has passed
+            diablo_timer[index].timer = timer_read();
+            // send keycode ONLY if we're on the diablo layer.
+            if (IS_LAYER_ON(_DIABLO)) {
+                tap_code(diablo_timer[index].keycode);
+            }
         }
     }
 }