aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* test: fix tests after notmuch show output changes related to filenamesDmitry Kurochkin2011-06-28
| | | | | | Adding the filename propery alongside ID and Content-type. This makes the test suite pass again after the recent change.
* Add part filename and content-id in notmuch show output if available.Dmitry Kurochkin2011-06-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before the change, notmuch show output had filename only for parts with "Content-Disposition: attachment". But parts with inline disposition may have filename as well. The patch makes notmuch show always output filename if available, independent of Content-Disposition. Both JSON and text output formats are changed. Also, the patch adds Content-id to text output format of notmuch show. The main goal of these changes is to have filenames on Emacs buttons for inline attachments. In particular, this is very helpful for inline patches. Note: text format changes may require updates in clients that use it. The changes are: * text part header format changed from: ^Lpart{ ID: 2, Content-type: text/x-diff to: ^Lpart{ ID: 2, Filename: cool-feature.patch, Content-type: text/x-diff * attachment format changed from: ^Lattachment{ ID: 4, Content-type: application/octet-stream Attachment: data.tar.bz2 (application/octet-stream) Non-text part: application/octet-stream ^Lattachment} to: ^Lattachment{ ID: 4, Filename: data.tar.bz2, Content-type: application/octet-stream Non-text part: application/octet-stream ^Lattachment}
* test: use emacsclient(1) for Emacs testsDmitry Kurochkin2011-06-28
| | | | | | | | | | | | | | | | | Before the change, every Emacs test ran in a separate Emacs instance. Starting Emacs many times wastes considerable time and it gets worse as the test suite grows. The patch solves this by using a single Emacs server and emacsclient(1) to run multiple tests. Emacs server is started on the first test_emacs call and stopped when test_done is called. We take care not to leave orphan Emacs processes behind when test is terminated by whatever reason: Emacs server runs a watchdog that periodically checks that the test is still running. Some tests need to provide user input. Before the change, this was done using echo(1) to Emacs stdin. This no longer works and instead `standard-input' variable is set accordingly to make `read' return the appropriate string.
* test: Increment mtime when delivering a message with emacs_deliver_messageCarl Worth2011-06-28
| | | | | | Without this, mail messages delivered by emacs_deliver_message might not be seen by the next invocation of "notmuch new", (which can lead to test-suite failures if emacs_deliver_message is fast enough).
* test:Improve test behaviors when --root is usedMark Anderson2011-06-28
| | | | | | | | | | | Change add_email_corpus, emacs_deliver_message and tests to use $TEST_DIRECTORY instead of '..'. This improves the behavior of the usage of --root=<dir>, as the assumption of what '..' means will usually be incorrect. Document -root option in README and update valgrind to work with -root.
* test: generate run_emacs script once on test startupDmitry Kurochkin2011-06-28
| | | | | | | Instead of generating auxiliary run_emacs script every time test_emacs is run, do it once in the beginning of the test. Also, use absolute paths in the script to make it more robust.
* test: set variables using `let' instead of `setq' in Emacs testsDmitry Kurochkin2011-06-28
| | | | | | | | | Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
* test: use emacs_deliver_message in Emacs SMTP send testDmitry Kurochkin2011-06-28
| | | | | Minor changes to expected results of other Emacs tests were needed because the message Date header changed.
* test: remove some sed(1) calls in Emacs testsDmitry Kurochkin2011-06-28
| | | | | | | | Few Emacs tests used sed(1) to remove unexpected output in the beginning to avoid getting confused by messages such as "Parsing /home/cworth/.mailrc... done". This is no longer needed since tests are run in a temporary home directory instead of the user's one. So remove these sed(1) calls.
* test: save buffer content to file instead of printing it in Emacs testsDmitry Kurochkin2011-06-28
| | | | | | | | | | | | | | | | | | | | | | Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
* test: wrap and indent test_emacs callsDmitry Kurochkin2011-06-28
| | | | | | | Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
* test: cleanup test_emacsDmitry Kurochkin2011-06-28
| | | | | Move auxiliary function definition and configuration from command line to test-lib.el.
* test: do not set `message-signature' in test_emacsDmitry Kurochkin2011-06-28
| | | | | It is no longer needed since tests are run in a temporary home directory instead of the user's one.
* test: fix argument order of test_expect_equal_file in few testsDmitry Kurochkin2011-06-28
| | | | | | Few Emacs tests had test_expect_equal_file arguments in the wrong order: the first argument should be the test output and the second one should be the expected.
* TODO: Clarify note about changing the way the emacs '*' command works.Carl Worth2011-06-28
| | | | | | Additional detail is available in this mail message: id:8739itagad.fsf@yoom.home.cworth.org
* .gitignore: Ignore the notmuch.sym file.Carl Worth2011-06-28
| | | | This is a generated file, so will not be under git control.
* search --output=files: Output all filenames for each matching messageMark Anderson2011-06-28
| | | | | | | | Messages in the database can have multiple files associated with a single message-id, but until now only one filename for each message has been reported by "notmuch search --output=files" Signed-off-by: Mark Anderson <ma.skies@gmail.com>
* test:Expect multiple filenames for message with multiple filesMark Anderson2011-06-28
| | | | | | | | | | | Update the test mail corpus to have two files with the same content to expose the bug where a single message with multiple filenames only reports a single filename. Update expected results for search --output=files to match new behavior for multiple files corresponding to a single message Signed-off-by: Mark Anderson <ma.skies@gmail.com>
* Makefile: Make emacs compilation depend on global dependencies.Carl Worth2011-06-28
| | | | | | | | We call these "global_deps" for a reason, after all! Without this, emacs compilation would proceed even if the configure script failed, (such as for a missing dependency). That's undesirable as it can cause the helpful error messages from the configure failure to scroll away.
* libnotmuch: build symbols list without relying on gcc -aux-info.David Bremner2011-06-28
| | | | | | | | | | | | | | | Carl reports "gcc -aux-info notmuch.aux lib/notmuch.h" does not generate notmuch.aux for him with Debian gcc 4.6.0-8. A small modification of the original sed regular expression allows us to work directly from lib/notmuch.h, rather than preprocessing with gcc. As with most such simple regex based "parsing", this is quite sensitive to the input format, and needs that each symbol to be exported from libnotmuch should - start with "notmuch_" - be the first non-whitespace token on the line - be followed by an open parenthesis.
* libnotmuch: fix typos in CLEAN setting, add fileDavid Bremner2011-06-28
| | | | | | | - c0961e6 introduced a missing slash between $(dir)$(LIBNAME) and missing $(dir) in front of libnotmuch.a - cdf1c70a created a file $(dir)/notmuch.h.gch and neglected to add it to CLEAN
* python: Do not implicitely call maildir_flags_to_tags etcSebastian Spaeth2011-06-24
| | | | | | | | | | In order to remain consistent with the underlying C API, we do not automatically synchronize notmuch tags and maildir flags anymore. The underlying functions Message.maildir_flags_to_tags and Message.tags_to_maildir_flags still exist and are available to the user. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* Merge remote-tracking branch 'origin/master'David Bremner2011-06-23
|\
| * test: remove useless test_emacs call from an emacs FCC testDmitry Kurochkin2011-06-23
| | | | | | | | | | This was inadvertently left over when debugging an early version of this commit. -Carl Worth <cworth@cworth.org>
| * Add dir-locals style variables for C++, Elisp, and shell code.Austin Clements2011-06-23
| | | | | | | | | | Also, slightly reformat dir-locals.el so that the settings align and to make it friendlier for future additions.
| * fix sum moar typos [test-case data]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | | | Various typo fixes in some test-case data. Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just test-case data.
| * fix sum moar typos [error messages]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | Various typo fixes in error messages within the source code. Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just error messages.
| * fix sum moar typos [user-visible documentation in code]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | | | | | | | | | Various typo fixes in documentation within the code that can be made available to the user, (emacs function help strings, "notmuch help" output, notmuch man page, etc.). Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just documentation and fixed fix of "comman" to "common" rather than "command".
| * fix sum moar typos [comments in source code]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | | | | | Various typo fixes in comments within the source code. Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just source-code comments, (and fixed fix of "descriptios" to "descriptors" rather than "descriptions").
| * fix sum moar typos [build scripts, Makefiles]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | Various typo fixes in comments within the Makefile and other build scripts. Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just build files.
| * fix sum moar typos [text files]Pieter Praet2011-06-23
| | | | | | | | | | | | | | | | | | Various typo fixes in auxiliary text files included with the source, (README, TODO, etc.). Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just text files.
| * Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup'Dmitry Kurochkin2011-06-23
| | | | | | | | | | | | | | | | | | | | | | This error occurs when `notmuch-fcc-dirs' is set to a list. The error was in the `notmuch-fcc-dirs' format check which was changed in an incompatible way from 0.4 to 0.5. The fix was extracted from a bigger patch series by David Edmondson id:"1290682750-30283-2-git-send-email-dme@dme.org". Signed-off-by: Jameson Graef Rollins <jrollins@finestructure.net>
| * test: Test emacs message composing with various values for notmuch-fcc-dirsCarl Worth2011-06-23
| | | | | | | | | | | | | | We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
* | debian: fix installation of notmuch-vim READMEDavid Bremner2011-06-23
| | | | | | | | There was a leftover override, installing it into the wrong package.
* | start new changelog stanzaDavid Bremner2011-06-23
| |
* | Revert "debian: Override RPATH_LDFLAGS"David Bremner2011-06-23
|/ | | | | | | This reverts commit fc126d89b2baa479d98c864fbef4174b6da707c0. This override of the make variable RPATH_LDFLAGS should no longer be required since the auto-configuration was fixed
* debian: Set conflicts from package split to point to an existing version.David Bremner2011-06-23
| | | | | The previous version was harmless, since there were no versions uploaded between ~237 and ~254, but this is less confusing.
* debian: fix typo in short description of notmuch-vimDavid Bremner2011-06-23
| | | | Thanks to Dirk Eddelbuettel for noticing.
* debian: update changelog for upload 0.6~254, bump standards version to 3.9.2David Bremner2011-06-23
|
* debian: remove Xapian exceptions symbols from libnotmuch1.symbolsDavid Bremner2011-06-23
| | | | | These were never intended to be public, since the library exports only a C API.
* debian: split off vim interface to its own packageDavid Bremner2011-06-23
| | | | So far the package does notthing fancy with vim-addon-manager.
* debian: split off emacs interface into its own package.David Bremner2011-06-23
| | | | | | | | | | - rename emacsen-install/remove files, and change embedded package name - split notmuch.install, notmuch.dirs - add Breaks/Replaces for previous notmuch packages with overlapping files.
* debian: Build depend on emacs-nox instead of emacs.David Bremner2011-06-23
| | | | | Nothing in the build process needs X, and the number of dependencies that need to be installed is much smaller.
* debian: build package for python-bindings.David Bremner2011-06-23
| | | | | | | This uses dh_python2 (included with sufficiently recent versions of the python/python-all packages). python-all brings in all of the supported versions of python. The double calls to dh_auto_install and friends are to avoid looping over python versions ourselves.
* tests: add a test for symbol hiding side effectsDavid Bremner2011-06-23
| | | | | | | | | | | The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e)
* libnotmuch: add linker script to declare only notmuch_* symbols as global.David Bremner2011-06-23
| | | | | | | | | | | This is closely tied to gcc and particularly gnu ld, but I guess the shared library linking code would need to be adjusted to work on a non-gnu linker anyay. I had to make a few not-obviously related changes to the lib/Makefile.local to make this work: libnotmuch_modules is defined with := and used in place of $^ (cherry picked from commit 014bf85b1c06ff49be2bde5a26433d2cf376cf70)
* debian: add changlog stanza for new snapshot 0.6~237David Bremner2011-06-22
| | | | (cherry picked from commit 17daa480e435ad4c1d8f4f18447eff1ff36dbe00)
* debian: Changelog stanza for new git snapshot 0.6~215David Bremner2011-06-22
| | | | (cherry picked from commit b85a415a7bd91c360c0acd453ead39be854f63f7)
* debian: update symbols file for libnotmuch1David Bremner2011-06-22
| | | | | | One of the Xapian exception symbols has gone missing. Hopefully this doesn't mean we should be bumping the SONAME. (cherry picked from commit e8260d63f1f5a37094801ecd5d110bf48f22ee45)
* debian: Changelog stanza for new snapshot 0.6~180David Bremner2011-06-22
| | | | (cherry picked from commit 54a3983d3c38830e2b609be0a96c5cf6dc6de054)
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-02 14:19:12 +0000