aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Add _notmuch_message_get_in_reply_to.Carl Worth2009-11-15
| | | | | | | The existing notmuch_message_get_header is *almost* good enough for this, except that we also need to remove the '<' and '>' delimiters. We'll probably want to implement this function with database storage in the future rather than loading the email message.
* Remove obsolete notmuch_message_get_subject prototype.Carl Worth2009-11-15
| | | | | | This prototype has been sitting around for a while with no function implementing it. I wonder if there's a compiler warning I could turn on to catch these things.
* lib/messages: Add new notmuch_message_list_t to internal interface.Carl Worth2009-11-15
| | | | | | | | | | | | Previously, the notmuch_messages_t object was a linked list built on top of a linked-list node with the odd name of notmuch_message_list_t. Now, we've got much more sane naming with notmuch_message_list_t being a list built on a linked-list node named notmuch_message_node_t. And now the public notmuch_messages_t object is a separate iterator based on notmuch_message_node_t. This means the interfaces for the new notmuch_message_list_t object are now made available to the library internals.
* database: Fix a typo in a commit.Carl Worth2009-11-15
| | | | | Nothing significant here, but we might as well not keep things misspelled when we notice.
* Export _parse_message_id to the library implementation.Carl Worth2009-11-15
| | | | | | Not exported through the public interface, but the thread code is going to want to be able to parse In-Reply-To headers so needs access to this code.
* _thread_add_messages: Remove unused variable.Carl Worth2009-11-15
| | | | | I'm not sure how I let this warning go by unfixed for a while. Fix it now.
* lib: Move notmuch_messages_t code from query.cc to new messages.cCarl Worth2009-11-14
| | | | | | | | | | | | | The new object is simply a linked-list of notmuch_message_t objects, (unlike the old object which contained a couple of Xapian iterators). This works now by the query code immediately iterator over all results and creating notmuch_message_t objects for them, (rather than waiting to create the objects until the notmuch_messages_get call as we did earlier). The point of this change is to allow other instances of lists of messages, (such as in notmuch_thread_t), that are not directly related to Xapian search results.
* notmuch_tags_advance: Make safe against excessive calls.Carl Worth2009-11-14
| | | | | | Previously, an excess call would have caused a crash. Now it simply does nothing. Also, make notmuch_tags_get use a similar, consistent early return for a NULL iterator.
* notmuch.el: Add support for viewing MIME-encoded parts (with 'v').Carl Worth2009-11-14
| | | | | | | Currently just supports viewing all MIME parts in the message. There's not yet support for selecting and viewing individual parts, but that should be easy to add from here, (now that we've found mm-display-parts to do all the heavy lifting).
* notmuch.el: Add an 'm' binding to start composing a new mail.Carl Worth2009-11-13
| | | | Available from either the "search" or the "show" view.
* notmuch.el: Use require instead of load to get the cl functions.Carl Worth2009-11-13
| | | | | Not only is "load" probably the wrong thing, but loading cl-seq befoe cl can cause complaints anyway.
* notmuch reply: Prefer "Reply-To" header over "From" for choosing recipient.Carl Worth2009-11-13
| | | | | | There are still open questions about how to correctly compute the intended list of recipients. We'll probably need separate "reply to sender" and "reply to all" commands at some point (unfortunately).
* notmuch new/tag: Flush all changes to database when interrupted.Keith Packard2009-11-13
| | | | | | By installing a signal handler for SIGINT we can ensure that no work that is already complete will be lost if the user interrupts a "notmuch new" run with Control-C.
* notmuch.el: Add a binding ('o') and command to toggle current search order.Carl Worth2009-11-12
| | | | | This ended up being a bit easier than I thought. Just flip the controlling variable and then run `notmuch-search-refresh-view'.
* notmuch search: Fix thread dates to come only from matched messages.Carl Worth2009-11-12
| | | | | | We were properly sorting the threads based only on matched messages, but we were displaying the date based on the total messages in the thread, which led to inconsistent and very confusing results.
* notmuch.el: Hook up support for different search orders.Carl Worth2009-11-12
| | | | | | | | | | | | | This gives us two different default search orders: The inbox view that comes up from "M-x notmuch" is sorted in chronological order (oldest threads first). A new global search "M-x notmuch-search" will instead be in reverse chronological order (newest threads first). Any filtered searches retain the sort order of the search being filtered. There's not yet any interface for changing the sort order of a search after it is constructed.
* notmuch search: Add support for a --reverse option to reverse sort order.Carl Worth2009-11-12
| | | | | | | | | | | | | | Note that the difference between thread results in date order and thread results in reverse-date order is not simply a matter of reversing the final results. When sorting in date order, the threads are sorted by the oldest message in the thread. When sorting in reverse-date order, the threads are sorted by the newest message in the thread. This difference means that we might want an explicit option in the interface to reverse the order, (even though the default will be to display the inbox in date order and global searches in reverse-date order).
* Makefile: Fix dependency generation for files in sub-directories.Carl Worth2009-11-12
| | | | | | | | | | | | | | | | | | | | Otherwise, things in the lib sub-directory weren't getting recompiled even when lib/notmuch.h was changed. The original rule we were using came from the GNU Makefile manual, but only handled files in the current directory, not file in sub-directories as we use here with our non-recursive Makefile. So the .deps files being created were being put in the right place, (such as .deps/lib/database.d), but the compiler was generating a dependency for "database.o" rather than "lib/database.o" like we want. We were already trying to do a sed job on that name to add a dependency for the .d file as well. But the sed job was failing since the expected pattern wasn't there, (the directory name was missing). So the fix is simply to use basename to construct the search pattern, and then use the name with the directory in the replacement (rather than the back-reference).
* notmuch search: Print the number of matched/total messages for each thread.Carl Worth2009-11-12
| | | | | | | | | | | | | | | | | | | Note that we don't print the number of *unread* messages, but instead the number of messages that matched the search terms. This is in keeping with our philosophy that the inbox is nothing more than a search view. If we search for messages with an inbox tag, then that's what we'll get a count of. (And if somebody does want to see unread counts, then they can search for the "unread" tag.) Getting the number of matched messages is really nice when doing historical searches. For example in a search like: notmuch search tag:sent (where the "sent" tag has been applied to all messages originating from the user's email address)---here it's really nice to be able to see a thread where the user just mentioned one point [1/13] vs. really getting involved in the discussion [10/29].
* Use $(MAKE) when invoking make from make.Carl Worth2009-11-12
| | | | Without this, things like MAKEFLAGS=-j4 can't work.
* notmuch search: Avoid printing duplicate author names.Carl Worth2009-11-12
| | | | | | | | We add a hash to the thread object so that we can detect author names that have already been added to the list, and avoid adding them redundantly. This avoids the giant chain of "bugzilla-daemon, bugzilla-daemon, bugzilla-daemon, bugzilla-daemon, ..." author lists that we would get otherwise, for example.
* notmuch search: Print all authors contributing to a thread.Carl Worth2009-11-12
| | | | | | | | We've now expanded the notmuch_thread_create function to fire off a secondary database query to find all the messages that belong to this particular thread. This allows us to now have the complete authors' list for the thread, and will also make it trivial to print accurate message counts for threads in the future.
* notmuch search: Add --first and --max-threads options for incremental search.Carl Worth2009-11-12
| | | | | | | | | | | | | This time, things are actually tested. The current results aren't exactly the same as previous results since the incremental search doesn't necessarily see all the new messages that pertain to the thread. This means that some author names are missing. I plan to fix this by doing an additional database search for all messages in each thread. Of course, this will also be different than before since now the result will display *all* authors in the thread (rather than only those that matched the search) but that's probably what we really want to display anyway.
* notmuch_query_search_threads: Avoid returning more threads than asked for.Carl Worth2009-11-12
| | | | | | | | | I thought it would be safe enough to return a few extra threads, (since we happened to already get the relevant messages out of the database). The problem is that then requires the caller to carefully read the number of threads returned and adjust its next "first" value accordingly. The interface is much simpler to use if we simply return exactly what is asked for and no more.
* notmuch search: Fix a second bug in the change to support incremental searches.Carl Worth2009-11-12
| | | | | | | The search was dropping the first thread from the results. When am I going to break down and write a test suite? It's long overdue now.
* notmuch search: Fix to actually return something.Carl Worth2009-11-12
| | | | | | | This serves me right for committing untested code. The notmuch_query_search_threads was totally broken, (it didn't properly treat -1 as being unlimited and instead returned no threads in that case).
* libnotmuch: Underlying support for doing partial-results searches.Carl Worth2009-11-12
| | | | | | The library interface now allows the caller to do incremental searches, (such as one page of results at a time). Next we'll just need to hook this up to "notmuch search" and the emacs interface.
* notmuch.el: Remove functions to show/hide thread IDs.Carl Worth2009-11-12
| | | | | | I wrote these originally jsut for debugging. They've never been hooked up to any keybinding and the existing "M-x visible-mode" does what's needed anyway.
* notmuch reply: Add Bcc to the user's primary email address.Carl Worth2009-11-12
| | | | | The user really wants a copy of all outbound messages to come back in.
* notmuch show: Display "Subject: " before the subject.Carl Worth2009-11-12
| | | | I think I was being uselessly terse when I dropped that. Put it back.
* notmuch search: Print the names of author of matched emails.Carl Worth2009-11-12
| | | | | | | It's important to have the names present for determining whether a thread is worth reading or not. We may want to think about abbreviating the list somehow if it is excessively long (or redundant as in bugzilla-daemon, bugzilla-daemon, bugzilla-daemon, etc.).
* Don't create "contact" terms in the database.Carl Worth2009-11-12
| | | | | | | | | | | We never did export any interface to get at these, and when I went to use these, I found them inadequate, (because I wanted to distinguish address found in from: from those found in To:). Meanwhile, it was easy enough to extract addresses with a search like: notmuch show tag:sent | grep ^To: so the storage of contact terms was just wasting space. Stop that.
* TODO: Add note on making "notmuch new" interruptible.Carl Worth2009-11-12
| | | | | | | | | This note was described in the previous commit message, but mistakenly not committed: The note about making "notmuch setup" faster is now rewritten to apply to "notmuch new" since "notmuch setup" no longer does any mail indexing.
* TODO: Update based on recent additions.Carl Worth2009-11-12
| | | | | | | | | We recently added support for "notmuch reply" and also made (most of) the hidden components self documenting. The note about making "notmuch setup" faster is now rewritten to apply to "notmuch new" since "notmuch setup" no longer does any mail indexing.
* notmuch new: Don't ignore files with mtime of 0.Carl Worth2009-11-12
| | | | | | | | | I recently discovered that mb2md has the annoying bug of creating files with mtime of 0, and notmuch then promptly ignored them, (thinking that its timestamps initialized to 0 were just as new). We fix notmuch to not exclude messages based on a database timestamp of 0.
* notmuch show: Avoid segmentation for message with no subject.Carl Worth2009-11-11
| | | | | It's safer to return an empty string rather than NULL for missing header values.
* Initialize count of new files to zero.Keith Packard2009-11-11
| | | | | | | Leaving this variable uninitialized caused notmuch to display a random number while counting files for the new database. Signed-off-by: Keith Packard <keithp@keithp.com>
* notmuch.el: Switch to using "notmuch reply" rather than message-reply.Carl Worth2009-11-11
| | | | | | This way we get to take advantage of the configuration of the user's email addresses in notmuch, (rather than expecting the user to configure all of their email addresses in message mode as well).
* notmuch reply: Fish out user's address from recipient list to use as From.Carl Worth2009-11-11
| | | | | | That is, if mail was addresses to one of the "other" addresses in the configuration file, then the reply will have its "From" header set to that same address rather than the primary address.
* notmuch reply: Don't reply to address belonging to the user.Carl Worth2009-11-11
| | | | | | Here's our first real advantage of having a configuration system. We get to omit our own addresses from the recipient list of any replies.
* Unbreak several notmuch commands after the addition of configuration.Carl Worth2009-11-11
| | | | | | | | | | | | | | | | | | | | | | All of the following commands: notmuch dump notmuch reply notmuch restore notmuch search notmuch show notmuch tag were calling notmuch_database_open with an argument of NULL. This was a legitimate call until the recent addition of configuration, after which it is expected that all commands will lookup the correct path in the configuration file. So fix all these commands to do that. Also, while touching all of these commands, we fix them to use the talloc context that is passed in rather than creating a local talloc context. We also switch from using goto for return values, to doing direct returns as soon as an error is detected, (which can be leak free thanks to talloc).
* notmuch new: Unbreak after the addition of notmuch-config.Carl Worth2009-11-11
| | | | | | Pull in the code from add-files.c now that notmuch_new_command is the only user, (we no longer have notmuch_setup_command adding any messages).
* notmuch: Make the command of "notmuch" walk the user through the next step.Carl Worth2009-11-11
| | | | | | | | If this is run first, it will run "notmuch setup" directly. After that is successful, it will look for a databae and tell the user to run "notmuch new" if the database doesn't exist yet. Finally, if the database is present, it will provide some example "notmuch search" commands for the user to try.
* notmuch: Move welcome messages from "notmuch" to "notmuch setup".Carl Worth2009-11-11
| | | | | | It's quite possible for someone to read the documentation and run "notmuch setup" rather than just "notmuch". In that case, we don't want to be any less welcoming.
* notmuch setup: Add some comments when creating a .notmuch-config file.Carl Worth2009-11-11
| | | | | The "notmuch setup" command is nice and all, but we also want to allow users to conveniently edit the configuration file directly.
* notmuch: Add a configuration system.Carl Worth2009-11-11
| | | | | | | | | | | | | | This will allow for things like the database path to be specified without any cheesy NOTMUCH_BASE environment variable. It also will allow "notmuch reply" to recognize the user's email address when constructing a reply in order to do the right thing, (that is, to use the user's address to which mail was sent as From:, and not to reply to the user's own addresses). With this change, the "notmuch setup" command is now strictly for changing the configuration of notmuch. It no longer creates the database, but instead instructs the user to call "notmuch new" to do that.
* notmuch setup: Break the implementation up into manageable functions.Carl Worth2009-11-11
| | | | | The notmuch_setup_command function was getting entirely unwieldy. Break it up into smaller functions for better maintainability.
* notmuch reply: Use GMime to construct the header for the reply.Carl Worth2009-11-11
| | | | | | | | | The advantage here is that we actually get the necessary folding of long headers, (particularly the References header, but also things like Subject). This also gives us parsed recipient addresses so that we can easily elide the sender's address(es) from the recipient list (just as soon as we have a configured value for the recipient's address(es)).
* notmuch.el: Add a binding ('r') to reply to the current message.Carl Worth2009-11-10
| | | | | | | We were just starting to get "notmuch reply" into shape in order to provide the needed functionality here, but then I realized that the message-reply function built into emacs is already more functional, (at least for the case of replying to a single message).
* notmuch reply: Process headers a bit more accurately.Carl Worth2009-11-10
| | | | | | We know take the original From: and all recipients and put them on the To: line. We also add a "Re: " to the subject, and we add In-Reply-To: and References: headers.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 18:03:07 +0000