aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* NEWS: document Emacs UI tagging operations changesDmitry Kurochkin2012-02-08
|
* emacs: s/tags/tag-changes/ for arguments of tagging functionsDmitry Kurochkin2012-02-08
| | | | | | | This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'.
* emacs: accept empty tag list in `notmuch-tag'Dmitry Kurochkin2012-02-08
| | | | | | | Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error.
* emacs: relax tag syntax check in `notmuch-tag' functionDmitry Kurochkin2012-02-08
| | | | | | | | The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not include whitespace characters.
* emacs: separate history for operations which accept single and multiple tagsDmitry Kurochkin2012-02-08
| | | | | | | | | | | | Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you have to skip options with incompatible format when going through the history. The patch adds separate history lists for the two functions. Note that functions that accept the same input format (e.g. "+", "-", "*") share the history list as before.
* emacs: add "*" binding for notmuch-show viewDmitry Kurochkin2012-02-08
| | | | | | | The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread.
* emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'Dmitry Kurochkin2012-02-08
| | | | | `Notmuch-search-tag-all' is more clear and consistent with other tagging function names.
* test: fix emacs tests after tagging operations changesDmitry Kurochkin2012-02-08
| | | | | | After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
* emacs: make "+" and "-" tagging operations in notmuch-show more flexibleDmitry Kurochkin2012-02-08
| | | | | | | | | | Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in notmuch-show view allow to both add and remove multiple tags. The only difference between "+" and "-" is the minibuffer initial input ("+" and "-" respectively).
* emacs: make "+" and "-" tagging operations in notmuch-search more flexibleDmitry Kurochkin2012-02-08
| | | | | | | | | | | Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in notmuch-search view allow to both add and remove multiple tags. The only difference between "+" and "-" is the minibuffer initial input ("+" and "-" respectively).
* emacs: remove text properties from `notmuch-search-get-tags' resultDmitry Kurochkin2012-02-08
|
* emacs: move tag format validation to `notmuch-tag' functionDmitry Kurochkin2012-02-08
| | | | | | | Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation.
* tag: remove unused attribute from notmuch_tag_command() argumentsDmitry Kurochkin2012-02-08
| | | | | Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them.
* emacs: use mark instead of point-max in MML quoting.David Bremner2012-02-04
| | | | | | | | | | | As Aaron explains in id:"m2vco72tf3.fsf@wal122.wireless-pennnet.upenn.edu" Using point-max would include the signature in the quoting as well. It would probably be fairly odd to want to put an MML tag in one’s signature, but that doesn’t mean that we should break that usage. We had to use point-max in the 0.11.1 bug-fix release, because the mark functionality was added post 0.11.
* test: Fix up date in MML quoting tests.David Bremner2012-02-04
| | | | | | based on id:"1328264649-27346-3-git-send-email-pieter@praet.org" Commit 66ecd9063 made dates "real", but it hasn't hit release yet.
* Merge commit '0.11.1'David Bremner2012-02-04
|\ | | | | | | | | | | | | | | | | | | Conflicts: NEWS bindings/python/notmuch/database.py bindings/python/notmuch/message.py notmuch.1 NEWS merged by hand, others taken from master.
| * debian: changelog for 0.11.1David Bremner2012-02-03
| | | | | | | | mention the two bugfixes
| * version: bump to 0.11.1David Bremner2012-02-03
| | | | | | | | also semi-automatically update man page and python bindings versions.
| * NEWS: set release date for 0.11.1David Bremner2012-02-03
| |
| * emacs: quote MML tags in repliesAaron Ecay2012-02-03
| | | | | | | | | | | | | | | | | | Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch.
| * test: add tests for quoting of MML tags in repliesAaron Ecay2012-02-03
| | | | | | | | | | | | | | | | The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
| * Add a NEWS section for 0.11.1 and document the python error handling bugfixJustus Winter2012-01-23
| |
| * python: fix error handlingJustus Winter2012-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | Before 3434d1940 the return values of libnotmuch functions were declared as c_void_p and the code checking for errors compared the returned value to None, which is the ctypes equivalent of a NULL pointer. But said commit wrapped all the data types in python classes and the semantic changed in a subtle way. If a function returns NULL, the wrapped python value is falsish, but no longer equal to None. Backported from master to 0.11.
* | emacs: fix `notmuch-wash-region-to-button' to work at beginning of bufferDmitry Kurochkin2012-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well. The patch fixes this. There are two parts in the fix: * Use `insert-before-markers' instead of `insert' for creating the button, so that it does not get added to the hidden overlay. * Stop using PREFIX argument for adding a newline before the button. The newline should not be added before a button at the beginning of buffer. The corresponding test is fixed now.
* | test: add test for hiding Original Message region at beginning of a messageDmitry Kurochkin2012-02-04
| | | | | | | | | | | | | | | | | | | | The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme@dme.org"
* | emacs: Move the blank line from the bottom of the headers to the top of the ↵David Edmondson2012-02-03
| | | | | | | | | | | | | | | | | | body. The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible.
* | emacs: More address cleaning.David Edmondson2012-02-03
| | | | | | | | | | | | | | Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests.
* | emacs: Prefer '[No Subject]' to blank subjects.David Edmondson2012-02-03
| |
* | emacs: Stop the `truncate-string-to-width' madness.David Edmondson2012-02-03
| | | | | | | | | | There's no need to call `truncate-string-to-width' twice in this code path.
* | lib: Use talloc to simplify cleanup in notmuch_database_openAustin Clements2012-02-03
| | | | | | | | | | | | | | Previously, we manually "free"d various pointers in notmuch_database_open. Use a local talloc context instead to simplify cleanup and eliminate various NULL pointer initializations and conditionals.
* | lib: Release resources if notmuch_database_open failsAustin Clements2012-02-03
| | | | | | | | | | Previously, if a Xapian exception occurred in notmuch_database_open, we failed to clean up the allocated notmuch_database_t object.
* | lib: Don't delete uninitialized pointersAustin Clements2012-02-03
| | | | | | | | | | | | | | | | | | In the error-handling paths of notmuch_database_open, we call notmuch_database_close, which "delete"s several objects referenced by the notmuch_database_t object. However, some of these pointers may be uninitialized, resulting in undefined behavior. Hence, allocate the notmuch_database_t with talloc_zero to make sure these pointers are NULL so that "delete"ing them is harmless.
* | test: remove ".sh" extension from the recently added Emacs testsDmitry Kurochkin2012-02-03
| | | | | | | | | | All test files, except for the recently added Emacs tests, do not have ".sh" extension. So remove it from the new test files for consistency.
* | configure: update explicit check for glib : >= 2.22Pieter Praet2012-02-03
| | | | | | | | | | | | | | | | | | | | | | As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc', which was only introduced in glib 2.22, so update the dependency. Thanks to datapipe@gmail.com for reporting this [1]. Also see commit b88e6abc. [1] id:"alpine.DEB.2.02.1201132130220.21970@ltspubuntu4.int.smq.datapipe.net"
* | emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."Pieter Praet2012-02-01
| | | | | | | | Less code, same results, without sacrificing readability.
* | emacs: fix show-previous-message doc stringJameson Graef Rollins2012-01-30
| |
* | emacs: modify the default show-mode key bindings for archivingJameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message (archive-message-then-next). 'A' is now bound to the previous archive-thread-then-next function.
* | emacs: use pop-at-end functionality in show-archive-message-then-next functionJameson Graef Rollins2012-01-30
| | | | | | | | | | This provides a smoother message processing flow by reducing the number of key presses needed for these common operations.
* | emacs: add option to show-next-{, open-}message functions to pop out to ↵Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | parent buffer if at end This will allow for keybindings that achieve a smoother message processing flow by reducing the number of key presses needed for most common operations.
* | emacs: add message archiving functionsJameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox).
* | emacs: break out thread navigation from notmuch-show-archive-threadJameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | | | | | | | This function is now just for archiving the current thread. A new function is created to archive-then-next. The 'a' key binding is updated accordingly. This will allow people to bind to the simple thread archiving function without the extra navigation. The archive-thread function now also takes a prefix to unarchive the current thread (ie. put the whole thread back in the inbox).
* | emacs: break up notmuch-show-archive-thread-internal into two more generally ↵Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | useful functions Break up notmuch-show-archive-thread-internal into two new functions: notmuch-show-tag-thread-internal: applies a tag to all messages in thread. If option remove flag is t, tags will be removed instead of added. notmuch-show-next-thread: moves to the next thread in the search result. If given a prefix, will show the next result, otherwise will just move to it in the search view. Two new interactive functions, notmuch-show-{add,remove}-tag-thread, are also added. Together, these provide a better suit of thread tagging and navigation tools. The higher level thread archiving functions are modified to use these new function.
* | emacs: use search-next-thread to move to next thread in show modeJameson Graef Rollins2012-01-30
| | | | | | | | | | We should always use the dedicated search mode navigation functions, in case navigation mechanics change down the line.
* | moved _config_(get|set)_list () functions earlier in the fileTomi Ollila2012-01-30
| | | | | | | | | | | | Moved static functions _config_get_list () and _config_set_list () closer to the beginning of file so that their definition is known (without adding forward declarations) in upcoming changes.
* | emacs: Don't mark messages as "unsaved" when printing.David Edmondson2012-01-27
| | | | | | | | | | `ps-print-buffer' notes that a buffer is unsaved unless `buffer-modified-p' returns `nil', so ensure that it does.
* | emacs: Another special case for `notmuch-show-clean-address'.David Edmondson2012-01-27
| | | | | | | | Remove backslashes.
* | test: Updated expected output for new `notmuch-show-clean-address'.David Edmondson2012-01-27
| |
* | emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.David Edmondson2012-01-27
| | | | | | | | | | | | | | | | | | | | `mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. Mark the corresponding test as no longer broken. Minor whitespace cleanup.
* | emacs: Re-enable line wrapping in `notmuch-show-mode'.David Edmondson2012-01-27
| | | | | | | | | | Turn on `visual-line-mode' via a hook, so that those who so choose can avoid it.
* | emacs: `notmuch-search-operate-all' code cleanup, no functional changesDmitry Kurochkin2012-01-27
| |