summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* notmuch_message_get_message_id: Fix to cache resultCarl Worth2009-10-21
| | | | | | | | | Previously, this would allocate new memory with every call. That was with talloc, of course, so there wasn't any leaking (eventually). But since we're now calling this internally we want to be a little less wasteful. It's easy enough to just stash the result into the message on the first call, and then just return that on subsequent calls.
* database: Add new notmuch_database_find_messageCarl Worth2009-10-21
| | | | | | | With this function, and the recently added support for notmuch_message_get_thread_ids, we now recode the find_thread_ids function to work just the way we expect a user of the public notmuch API to work. Not too bad really.
* Add notmuch_message_get_thread_ids functionCarl Worth2009-10-21
| | | | | | Along with all of the notmuch_thread_ids_t iterator functions. Using a consistent idiom seems better here rather than returning a comma-separated string and forcing the user to parse it.
* Add wrappers for regcomp and regexec to xutil.c.Carl Worth2009-10-21
| | | | These will be handy for some parsing.
* Rename NOTMUCH_MAX_TERM to NOTMUCH_TERM_MAXCarl Worth2009-10-21
| | | | Just better consistency with our naming schemes.
* Move find_prefix function from database.cc to message.ccCarl Worth2009-10-21
| | | | | | It's definitely a better fit there for now, (and can likely eventually be made static as add_term moves from database to message as well).
* notmuch dump: Fix to print spaces between tags.Carl Worth2009-10-21
| | | | Simple little bug here made all the tags run together.
* Convert notmuch_database_t to start using talloc.Carl Worth2009-10-21
| | | | | This will be handy as we can hang future talloc allocations off of the datbase now.
* Move declarations for xutil.c from notmuch-private to new xutil.h.Carl Worth2009-10-21
| | | | | | | The motivation here is that our top-level notmuch.c main program wants to start using these, but we don't want it to see into notmuch-private.h, (since our main program is a test vehicle for the "public" notmuch interface in notmuch.h).
* notmuch dump: Fix buffer overrun in error message.Carl Worth2009-10-21
| | | | Just a little bug I noticed while editing nearby code.
* notmuch setup: Collapse internal whitespace within message-idCarl Worth2009-10-21
| | | | | | | I'm too lazy to see what the RFC says, but I know that having whitespace inside a message-ID is sure to confuse things. And besides, this makes things more compatible with sup so that I have some hope of importing sup labels.
* notmuch dump: Fix the sorting of results.Carl Worth2009-10-21
| | | | | | | | | | | | | To properly support sorting in notmuch_query we know use an Enquire object. We also throw in a QueryParser too, so we're really close to being able to support arbitrary full-text searches. I took a look at the supported QueryParser syntax and chose a set of flags for everything I like, (such as supporting Boolean operators in either case ("AND" or "and"), supporting phrase searching, supporting + and - to include/preclude terms, and supporting a trailing * on any term as a wildcard).
* add_message: Add a type:mail ("Kmail") term to all documents.Carl Worth2009-10-21
| | | | | This gives us an easy way to specify "all mail messages" in a search query. We simply look for this term.
* notmuch setup: Print a few protecting spaces after progress reports.Carl Worth2009-10-21
| | | | | | | | | | This is to help keep the report looking clean when a new report is shorter than a previous reports, (say, when crossing the boundary from over one minute remaining to less than one minute remaining). This used to be here, but I must have accidentally dropped it when reformatting the progress report recently.
* .gitignore: Ignore generated file Makefile.depCarl Worth2009-10-20
| | | | | Forgot to add this when I first add dependency checking to the Makefile.
* database: Remove two little bits of dead code.Carl Worth2009-10-20
|
* query: Remove the magic NOTMUCH_QUERY_ALLCarl Worth2009-10-20
| | | | | | | Using the address of a static char* was clever, but really unnecessary. An empty string is much less magic, and even easier to understand as the way to query everything from the database.
* notmuch dump: Free each message as it's used.Carl Worth2009-10-20
| | | | | | | | | | | | Previously we were leaking[*] memory in that the memory footprint of a "notmuch dump" run would continue to grow until the output was complete, and then finally all the memory would be freed. Now, the memory footprint is small and constant, O(1) rather than O(n) in the number of messages. [*] Not leaking in a valgrind sense---every byte was still carefully being accounted for and freed eventually.
* Add destroy functions for results, message, and tags.Carl Worth2009-10-20
| | | | | | | | | | | | None of these are strictly necessary, (everything was leak-free without them), but notmuch_message_destroy can actually be useful for when one query has many message results, but only one is needed to be live at a time. The destroy functions for results and tags are fairly gratuitous, as there's unlikely to be any benefit from calling them. But they're all easy to add, (all of these functions are just wrappers for talloc_free), and we do so for consistency and completeness.
* Rename our talloc destructor functions to _destructor.Carl Worth2009-10-20
| | | | | I want to reserve the _destroy names for some public functions I'm about to add.
* Implement 'notmuch dump'.Carl Worth2009-10-20
| | | | | | | | | | | | | | | | This is a fairly big milestone for notmuch. It's our first command to do anything besides building the index, so it proves we can actually read valid results out from the index. It also puts in place almost all of the API and infrastructure we will need to allow searching of the database. Finally, with this change we are now using talloc inside of notmuch which is truly a delight to use. And now that I figured out how to use C++ objects with talloc allocation, (it requires grotty parts of C++ such as "placement new" and "explicit destructors"), we are valgrind-clean for "notmuch dump", (as in "no leaks are possible").
* Rename private notmuch_message_t to notmuch_message_file_tCarl Worth2009-10-20
| | | | | | | | | This is in preparation for a new, public notmuch_message_t. Eventually, the public notmuch_message_t is going to grow enough features to need to be file-backed and will likely need everything that's now in message-file.c. So we may fold these back into one object/implementation in the future.
* Makefile: Add automatic dependency tracking to the Makefile.Carl Worth2009-10-20
| | | | With this, I really don't miss anything from automake.
* notmuch: Fix setup so that accepting the default mail path works.Carl Worth2009-10-20
| | | | | | The recent change from GIOChannel to getline, (with a semantic change of the newline terminator now being included in the result that setup_command sees), broke this.
* message: Use g_hash_table_destroy instead of g_hash_table_unrefCarl Worth2009-10-20
| | | | | | | | | I'm trying to chase down 3 still-reachable pointers to glib hash tables. This change didn't help with that, but I think destroy might be a better semantic match for what I actually want. (It shouldn't matter though since I never take any additional references.)
* add_message: Fix memory leak of thread_ids GPtrArray.Carl Worth2009-10-20
| | | | | | | | | We were properly feeing this memory when the thread-ids list was not empty, but leaking it when it was. Thanks, of course, to valgrind along with the G_SLICE=always-malloc environment variable which makes leak checking with glib almost bearable.
* database.cc: Document better pieces of glib that we're using.Carl Worth2009-10-20
|
* message.c: Free leaked memory in notmuch_message objectCarl Worth2009-10-20
| | | | | | We were careful to free this memory when we finished parsing the headers, but we missed it for the case of closing the message without ever parsing all of the headers.
* notmuch: Use GNU libc getline() instead of glib GIOChannelCarl Worth2009-10-20
| | | | | Less reliance on glib is always nice for our memory-leak testing efforts.
* notmuch_database_open: Fix error message for file-not-found.Carl Worth2009-10-20
| | | | | | | | | I was incorrectly using the return value of stat (-1) instead of errno (ENOENT) to try to construct the error message here. Also, while we're here, reword the error message to not have "stat" in it, which in spite of what a Unix programmer will tell you, is not actually a word.
* Add some explanation about NOTMUCH_BASE to setup_command.Carl Worth2009-10-20
| | | | | | | Since we allow the user to enter a custom directory, we need to let the user know how to make this persistent. Of course, a better answer would be to take what the user entered and shove it into a ~/.notmuch-config file or so, but for now this will have to do.
* notmuch_database_create/open: Fix to handle NULL as documented.Carl Worth2009-10-20
| | | | | | | | | | | When documenting these functions I described support for a NOTMUCH_BASE environment variable to be consulted in the case of a NULL path. Only, I had forgotten to actually write the code. This code exists now, with a new, exported function: notmuch_database_default_path
* notmuch_message_get_header: Fix bogus return of NULL header.Carl Worth2009-10-20
| | | | | | | | | | | | | A simple bug meant that the correct value was being inserted into the hash table, but a NULL value would be returned in some cases. (If the value was already in the hash table at the beginning of the call the the correct value would be returned, but if the function had to parse to reach it then it would return NULL.) This was tripping up the recently-added code to ignore messages with NULL From:, Subject:, and To: headers, (which is fortunate since otherwise the broken parsing might have stayed hidden for longer).
* notmuch: Revamp help message a bit.Carl Worth2009-10-19
| | | | | | The big update here is the addition of the dump and restore commands which are next on my list. Also, I've now come up with a syntax for documenting the arguments of sub-commands.
* notmuch: Ignore files that don't look like email messages.Carl Worth2009-10-19
| | | | | | | This is helpful for things like indexes that other mail programs may have left around. It also means we can make the initial instructions much easier, (the user need not worry about moving away auxiliary files from some other email program).
* Protect definition of _GNU_SOURCE.Carl Worth2009-10-19
| | | | | I was getting a duplicate definition of this from somewhere, so getting compiler warnings without this protection.
* Remove test programs, xapian-dump and notmuch-index-messageCarl Worth2009-10-19
| | | | | | | | | | These were just little tests while getting comfortable with GMime and xapian. I'll likely use pieces of these as notmuch continues, but for now let's not distract anyone looking at notmuch with these. And the code will live on in the history if I need to look at it.
* notmuch: Reword the progress report slightly.Carl Worth2009-10-19
| | | | | | I noticed this style during a recent Debian install and I liked how much less busy it is compared to what we had before, (while still telling the user everything she might want).
* Rework message parsing to use getline rather than mmap.Carl Worth2009-10-19
| | | | | | | The line-based parsing can be a bit awkward when wanting to peek ahead, (say, for folded header values), but it's so convenient to be able to trust that a string terminator exists on every line so it cleans up the code considerably.
* Don't hash headers we won't end up using.Carl Worth2009-10-19
| | | | Just saving a little work here.
* Document which pieces of glib we're still using.Carl Worth2009-10-19
| | | | | | | | Looks like we can copy in a hash-table implementation, (from cairo, say), and then a few _ascii_ functions from glib, (we'll need to switch a few current uses if things like isspace, etc. to locale- independent versions as well). So not too hard to free ourselves of glib for now, (until we add GMime back in later, of course).
* Hook up our fancy new notmuch_parse_date function.Carl Worth2009-10-19
| | | | | With all the de-glib-ification out of the way, we can now use it to allow for date-based sorting of Xapian search results.
* notmuch_parse_date: Handle a NULL date string gracefully.Carl Worth2009-10-19
| | | | | The obvious thing to do is to treat a missing date as the beginning of time. Also, remove a useless cast from another return of 0.
* date.c: Rename function to notmuch_parse_dateCarl Worth2009-10-19
| | | | | | | Now completing the process of making this function "our own". The documentation is deleted here, because we already have the documentation we want in notmuch-private.h.
* date.c: Add hard-coded definition of HAVE_TIMEZONECarl Worth2009-10-19
| | | | | | | | | | | | The original code expected this to be set by running configure. We'll just manually set it here for now. This isn't as portable as if we were doing some compile-time examination of the current system, but I don't need portability now. When someone comes along that wants to port notmuch to another system, they will already have all the #ifdefs in place and will simply need to add the appropriate machinery to set the defines.
* date.c: Don't use glib's slice allocator.Carl Worth2009-10-19
| | | | | | | | | | | | | | | | | | | | This change is gratuitous. For now, notmuch is still linking against glib, so I don't have any requirement to remove this, (unlike the last few changes where good taste really did require the changes). The motivation here is two-fold: 1. I'm considering switching away from all glib-based allocation soon so that I can more easily verify that the memory management is solid. I want valgrind to say "no leaks are possible" not "there is tons of memory still allocated, but probably reachable so who knows if there are leaks or not?". And glib seems to make that impossible. 2. I don't think there's anything performance-sensitive about the allocation here. (In fact, if there is, then the right answer would be to do this parsing without any allocation whatsoever.)
* date.c: Remove occurrences of gboolean.Carl Worth2009-10-19
| | | | | | | | | | While this is surely one of the most innocent typedefs, it still annoys me to have basic types like 'int' re-defined like this. It just makes it harder to copy the code between projects, with very little benefit in readability. For readability, predicate functions and variables should be obviously Boolean-natured by their actual *names*.
* date.c: Remove all occurrences of g_return_val_if_failCarl Worth2009-10-19
| | | | | | | | | | | That's got to be one of the hardest macro names to read, ever, (it's phrased with an implicit negative in the condition, rather than something simple like "assert"). Plus, it's evil, since it's a macro with a return in it. And finally, it's actually *longer* than just typing "if" and "return". So what's the point of this ugly idiom?
* date.c: Keep the comments clean.Carl Worth2009-10-19
| | | | | Never know when the children might be reading over my shoulder, for example. :-)
* date.c: Change headers/defines t owork within notmuch.Carl Worth2009-10-19
| | | | | | We can't rely on any gmime-internal headers, (and fortunately we don't need to). We also aren't burdened with any autconf machinery so don't reference any of that.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-13 01:09:02 +0000