summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Remove the talloc_owner argument from create_for_message_id.Carl Worth2009-11-17
| | | | | | | This function has only one caller, and that one caller was passing the same value for both talloc_owner and the notmuch database. Dropping the redundant argument simplifies the documentation of this function considerably.
* get_in_reply_to: Implement via the database, not by opening mail file.Carl Worth2009-11-17
| | | | | | | This reduces our reliance on open message_file objects, (so is a step toward fixing the "too many open files" bug), but more importantly, it means we don't load a self-referencing in-reply-to header, (since we weed those out before adding any replyto terms to the database).
* Makefile: Manual pages shouldn't be executableIngmar Vanhassel2009-11-17
|
* Makefile: Change default install prefix from /usr to /usr/local, reallyIngmar Vanhassel2009-11-17
|
* Makefile: Change default install prefix from /usr to /usr/localCarl Worth2009-11-17
| | | | | | | We'll be a much more polite package this way. And the user can change the prefix by editing Makefile.config. Still to be done is to make configure write out Makefile.config and to add a --prefix option to configure.
* Makefile: Prefer directories as the target for install commands.Carl Worth2009-11-17
| | | | | | I was confusing myself with some rules installing to directories and some installing to files. We do still install to a filename when simultaneously renaming, (such as notmuch-completion.bash to notmuch).
* Update .gitignore, add objects and static archivesIngmar Vanhassel2009-11-17
|
* Makefile: Create installation directories explicitlyIngmar Vanhassel2009-11-17
| | | | Previously, notmuch.1.gz was installed as /usr/share/man/man1 (a file).
* Deal with situation where sysconf(_SC_GETPW_R_SIZE_MAX) returns -1Alexander Botero-Lowry2009-11-17
|
* Fix broken commit.Carl Worth2009-11-17
| | | | Oops. I should have actually compiled before pushing.
* Include <stdint.h> to get uint32_t in C++ file with gcc 4.4Mikhail Gusarov2009-11-17
| | | | Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
* Close message file after parsing message headersMikhail Gusarov2009-11-17
| | | | | | Keeping unused files open helps to see "Too many open files" often. Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
* add_message: Avoid a memory leak when user holds on to message return.Carl Worth2009-11-17
| | | | | | | | | | When this function was originally written, the 'message' object was always destroyed locally, so I thought it would be good to use a NULL talloc context to make it more obvious if there was any leak. Since then, however, this function has been changed to optionally return the added message, and in that case we *don't* free the message locally, so let's let the database be the talloc context.
* notmuch_message_file_get_header returns "" for missing headers, not NULLKeith Packard2009-11-16
| | | | | | | This makes notmuch reply fail to add From: addresses to the list of recipients. Signed-off-by: Keith Packard <keithp@keithp.com>
* Use 'forward-line' instead of 'next-line' while walking search displayKeith Packard2009-11-16
| | | | | | | | The documentation for 'next-line' suggests that 'forward-line' is a better choice for non-interactive usage. That appears to be the case here; using next-line caused emacs to spin forever for me. Signed-off-by: Keith Packard <keithp@keithp.com>
* notmuch.el: Consider an entire line of underscores as a signature separator.Carl Worth2009-11-16
| | | | | | | This is the default separator used by mailman, so there's a lot of clutter in thread displays without this. Also, we not provide a nice variable to the user (notmuch-show-signature-regexp) for configuring this.
* notmuch.el: Insert a newline if the last line of a part is missing one.Carl Worth2009-11-16
| | | | | | | | | | | | | I think there's a GMime bug that we're getting parts decoded without a final newline (the encoded parts seem to have them just fine). We can workaround the bug easily enough by finding a part-closing delimiter that is not at the beginning of a line, and if so, just insert a newline. Without this, the one-line-summary of the next message would continue on the same line as the last line of the previous message, (and this would often happen for mailing-list messages where mailman would add an extra part for its signature block).
* notmuch restore was skipping entries with no new tagsKeith Packard2009-11-16
| | | | | | | | | | | notmuch restore used to only add tags; now that it clears existing tags, it needs to operate on messages even if the new tag list is empty. Signed-off-by: Keith Packard <keithp@keithp.com> Reviewed-by: Carl Worth <cworth@cworth.org>: I fixed up the indentation here, (someday we might switch to 8-space indents, but we haven't yet).
* notmuch.el: Display authors in a column separate from subject.Carl Worth2009-11-16
| | | | | | | | | | | | | | | This makes it much easier to actually read the subject lines. The user can set notmuch-search-authors-width to control the width of the column. Two possible ideas for improving this support further: 1. Make the excess authors invisible instead of removing them from the buffer, (which means that isearch could still find them). 2. Have the user variable control a percentage of the window width rather than being a fixed number of columns.
* notmuch.el: Indent messages to show nested structure of thread.Carl Worth2009-11-16
| | | | | | | | | | | | | Now that we're actually adding text to the buffer for the indentation, our old aproach of using positions to record regions to manipulate is now longer correct. Fortunately, it's easy to switch from positions to markers which are robust, (just call point-marker instead of point and all relevant functions accept markers as well as points). I also finally fixed the bug where the text "[6 line signature]" we display was causing the one-line-summary of the next message to be on its same line rather than at the beginning of the next line where it belongs.
* notmuch show: Implement proper thread ordering/nesting of messages.Carl Worth2009-11-15
| | | | | | | | We now properly analyze the in-reply-to headers to create a proper tree representing the actual thread and present the messages in this correct thread order. Also, there's a new "depth:" value added to the "message{" header so that clients can format the thread as desired, (such as by indenting replies).
* Minor whitespace touchup.Carl Worth2009-11-15
| | | | | | It's funny that I picked up the habit of always including a space before a left parenthesis from Keith, and now he's in the habit of contributing code without it.
* Add _notmuch_message_get_in_reply_to.Carl Worth2009-11-15
| | | | | | | The existing notmuch_message_get_header is *almost* good enough for this, except that we also need to remove the '<' and '>' delimiters. We'll probably want to implement this function with database storage in the future rather than loading the email message.
* Remove obsolete notmuch_message_get_subject prototype.Carl Worth2009-11-15
| | | | | | This prototype has been sitting around for a while with no function implementing it. I wonder if there's a compiler warning I could turn on to catch these things.
* lib/messages: Add new notmuch_message_list_t to internal interface.Carl Worth2009-11-15
| | | | | | | | | | | | Previously, the notmuch_messages_t object was a linked list built on top of a linked-list node with the odd name of notmuch_message_list_t. Now, we've got much more sane naming with notmuch_message_list_t being a list built on a linked-list node named notmuch_message_node_t. And now the public notmuch_messages_t object is a separate iterator based on notmuch_message_node_t. This means the interfaces for the new notmuch_message_list_t object are now made available to the library internals.
* database: Fix a typo in a commit.Carl Worth2009-11-15
| | | | | Nothing significant here, but we might as well not keep things misspelled when we notice.
* Export _parse_message_id to the library implementation.Carl Worth2009-11-15
| | | | | | Not exported through the public interface, but the thread code is going to want to be able to parse In-Reply-To headers so needs access to this code.
* _thread_add_messages: Remove unused variable.Carl Worth2009-11-15
| | | | | I'm not sure how I let this warning go by unfixed for a while. Fix it now.
* lib: Move notmuch_messages_t code from query.cc to new messages.cCarl Worth2009-11-14
| | | | | | | | | | | | | The new object is simply a linked-list of notmuch_message_t objects, (unlike the old object which contained a couple of Xapian iterators). This works now by the query code immediately iterator over all results and creating notmuch_message_t objects for them, (rather than waiting to create the objects until the notmuch_messages_get call as we did earlier). The point of this change is to allow other instances of lists of messages, (such as in notmuch_thread_t), that are not directly related to Xapian search results.
* notmuch_tags_advance: Make safe against excessive calls.Carl Worth2009-11-14
| | | | | | Previously, an excess call would have caused a crash. Now it simply does nothing. Also, make notmuch_tags_get use a similar, consistent early return for a NULL iterator.
* notmuch.el: Add support for viewing MIME-encoded parts (with 'v').Carl Worth2009-11-14
| | | | | | | Currently just supports viewing all MIME parts in the message. There's not yet support for selecting and viewing individual parts, but that should be easy to add from here, (now that we've found mm-display-parts to do all the heavy lifting).
* notmuch.el: Add an 'm' binding to start composing a new mail.Carl Worth2009-11-13
| | | | Available from either the "search" or the "show" view.
* notmuch.el: Use require instead of load to get the cl functions.Carl Worth2009-11-13
| | | | | Not only is "load" probably the wrong thing, but loading cl-seq befoe cl can cause complaints anyway.
* notmuch reply: Prefer "Reply-To" header over "From" for choosing recipient.Carl Worth2009-11-13
| | | | | | There are still open questions about how to correctly compute the intended list of recipients. We'll probably need separate "reply to sender" and "reply to all" commands at some point (unfortunately).
* notmuch new/tag: Flush all changes to database when interrupted.Keith Packard2009-11-13
| | | | | | By installing a signal handler for SIGINT we can ensure that no work that is already complete will be lost if the user interrupts a "notmuch new" run with Control-C.
* notmuch.el: Add a binding ('o') and command to toggle current search order.Carl Worth2009-11-12
| | | | | This ended up being a bit easier than I thought. Just flip the controlling variable and then run `notmuch-search-refresh-view'.
* notmuch search: Fix thread dates to come only from matched messages.Carl Worth2009-11-12
| | | | | | We were properly sorting the threads based only on matched messages, but we were displaying the date based on the total messages in the thread, which led to inconsistent and very confusing results.
* notmuch.el: Hook up support for different search orders.Carl Worth2009-11-12
| | | | | | | | | | | | | This gives us two different default search orders: The inbox view that comes up from "M-x notmuch" is sorted in chronological order (oldest threads first). A new global search "M-x notmuch-search" will instead be in reverse chronological order (newest threads first). Any filtered searches retain the sort order of the search being filtered. There's not yet any interface for changing the sort order of a search after it is constructed.
* notmuch search: Add support for a --reverse option to reverse sort order.Carl Worth2009-11-12
| | | | | | | | | | | | | | Note that the difference between thread results in date order and thread results in reverse-date order is not simply a matter of reversing the final results. When sorting in date order, the threads are sorted by the oldest message in the thread. When sorting in reverse-date order, the threads are sorted by the newest message in the thread. This difference means that we might want an explicit option in the interface to reverse the order, (even though the default will be to display the inbox in date order and global searches in reverse-date order).
* Makefile: Fix dependency generation for files in sub-directories.Carl Worth2009-11-12
| | | | | | | | | | | | | | | | | | | | Otherwise, things in the lib sub-directory weren't getting recompiled even when lib/notmuch.h was changed. The original rule we were using came from the GNU Makefile manual, but only handled files in the current directory, not file in sub-directories as we use here with our non-recursive Makefile. So the .deps files being created were being put in the right place, (such as .deps/lib/database.d), but the compiler was generating a dependency for "database.o" rather than "lib/database.o" like we want. We were already trying to do a sed job on that name to add a dependency for the .d file as well. But the sed job was failing since the expected pattern wasn't there, (the directory name was missing). So the fix is simply to use basename to construct the search pattern, and then use the name with the directory in the replacement (rather than the back-reference).
* notmuch search: Print the number of matched/total messages for each thread.Carl Worth2009-11-12
| | | | | | | | | | | | | | | | | | | Note that we don't print the number of *unread* messages, but instead the number of messages that matched the search terms. This is in keeping with our philosophy that the inbox is nothing more than a search view. If we search for messages with an inbox tag, then that's what we'll get a count of. (And if somebody does want to see unread counts, then they can search for the "unread" tag.) Getting the number of matched messages is really nice when doing historical searches. For example in a search like: notmuch search tag:sent (where the "sent" tag has been applied to all messages originating from the user's email address)---here it's really nice to be able to see a thread where the user just mentioned one point [1/13] vs. really getting involved in the discussion [10/29].
* Use $(MAKE) when invoking make from make.Carl Worth2009-11-12
| | | | Without this, things like MAKEFLAGS=-j4 can't work.
* notmuch search: Avoid printing duplicate author names.Carl Worth2009-11-12
| | | | | | | | We add a hash to the thread object so that we can detect author names that have already been added to the list, and avoid adding them redundantly. This avoids the giant chain of "bugzilla-daemon, bugzilla-daemon, bugzilla-daemon, bugzilla-daemon, ..." author lists that we would get otherwise, for example.
* notmuch search: Print all authors contributing to a thread.Carl Worth2009-11-12
| | | | | | | | We've now expanded the notmuch_thread_create function to fire off a secondary database query to find all the messages that belong to this particular thread. This allows us to now have the complete authors' list for the thread, and will also make it trivial to print accurate message counts for threads in the future.
* notmuch search: Add --first and --max-threads options for incremental search.Carl Worth2009-11-12
| | | | | | | | | | | | | This time, things are actually tested. The current results aren't exactly the same as previous results since the incremental search doesn't necessarily see all the new messages that pertain to the thread. This means that some author names are missing. I plan to fix this by doing an additional database search for all messages in each thread. Of course, this will also be different than before since now the result will display *all* authors in the thread (rather than only those that matched the search) but that's probably what we really want to display anyway.
* notmuch_query_search_threads: Avoid returning more threads than asked for.Carl Worth2009-11-12
| | | | | | | | | I thought it would be safe enough to return a few extra threads, (since we happened to already get the relevant messages out of the database). The problem is that then requires the caller to carefully read the number of threads returned and adjust its next "first" value accordingly. The interface is much simpler to use if we simply return exactly what is asked for and no more.
* notmuch search: Fix a second bug in the change to support incremental searches.Carl Worth2009-11-12
| | | | | | | The search was dropping the first thread from the results. When am I going to break down and write a test suite? It's long overdue now.
* notmuch search: Fix to actually return something.Carl Worth2009-11-12
| | | | | | | This serves me right for committing untested code. The notmuch_query_search_threads was totally broken, (it didn't properly treat -1 as being unlimited and instead returned no threads in that case).
* libnotmuch: Underlying support for doing partial-results searches.Carl Worth2009-11-12
| | | | | | The library interface now allows the caller to do incremental searches, (such as one page of results at a time). Next we'll just need to hook this up to "notmuch search" and the emacs interface.
* notmuch.el: Remove functions to show/hide thread IDs.Carl Worth2009-11-12
| | | | | | I wrote these originally jsut for debugging. They've never been hooked up to any keybinding and the existing "M-x visible-mode" does what's needed anyway.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 06:58:21 +0000