summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* Make "notmuch new" ignore directories that are read-only.Carl Worth2009-10-23
| | | | | | With this, "notmuch new" is now plenty fast even with large archives spanning many sub-directories. Document this both in "notmuch help" and also in the output of notmuch setup.
* add_files: Pull one stat out of the recrusive function.Carl Worth2009-10-23
| | | | | There's no need to stat each directory both before and after each recursive call.
* More fixing of plurals.Carl Worth2009-10-23
| | | | | It definitely doesn't help that we have the same messages in both "setup" and "new". Should combine those really.
* More care in final status reporting.Carl Worth2009-10-23
| | | | | Printing "Added 1 new messages" just looks like lack of attention to detail, (but yes plurals can be annoying this way).
* Print a better message than "0s" for zero seconds.Carl Worth2009-10-23
| | | | It's nice to have a tool that at least construct actual sentences.
* Add new "notmuch new" command.Carl Worth2009-10-23
| | | | | | | | Finally, I can get new messages into my notmuch database without having to run a complete "notmuch setup" again. This takes advantage of the recent timestamp capabilities in the database to avoid looking into directories that haven't changed since the last time "notmuch new" was run.
* add_files: Change to return a status value instead of voidCarl Worth2009-10-23
| | | | | Also change to use goto rather than early returns. And once again, there were lots of bugs in the error cases previously.
* notmuch setup: Clean up the progress printing a bit.Carl Worth2009-10-23
| | | | | | | | | | Get rid of a useless leading 0 on the seconds value, and make a distinction between "files" and "messages", (we process many files, but not all of them are recongized as messages). Finally, add a summary line at the end saying how many unique messages were added to the database. Since this comes right after the total number of files, it gives the user at least a hint as to how many messages were encountered with duplicate message IDs.
* Re-order documentation a bit.Carl Worth2009-10-23
| | | | | | The notmuch_database_get_default_path function is unique in not accepting a notmuch_database_t* (nor creating one). So list it outside the other notmuch_database functions.
* notmuch_message_get_filename: Improve documentation.Carl Worth2009-10-23
| | | | | Fix a typo, and add clarifications about the lifetime and readonly nature of the return value.
* Remove some unneeded initializers.Carl Worth2009-10-23
| | | | | | | | | | Some people might argue for more initializers to be "safer", but I actually prefer to leave things this way. It saves typing, but the real benefit is that the things that do require initialization stand out so we know to watch them carefully. And with valgrind, we actually get to catch errors earlier if we *don't* initialize them. So that can be "safer" ironically enough.
* notmuch setup: Fix a couple of error paths.Carl Worth2009-10-23
| | | | | We had early returns instead of goto statments, and sure enough, they were leaking. Much cleaner this way.
* _find_prefix: Exit when given an invalid prefix name.Carl Worth2009-10-23
| | | | This will be a nice safety check for internal sanity.
* Add NOTMUCH_STATUS_DUPLICATE_MESSAGE_IDCarl Worth2009-10-23
| | | | | | | | | And document that notmuch_database_add_message can return this value. This pushes the hard decision of what to do with duplicate messages out to the user, but that's OK. (We weren't really doing anything with these ourselves, and this way the user is at least informed of the issue, rather than it just getting papered over internally.)
* Clean up comments to not include spaces before tabs.Carl Worth2009-10-23
| | | | | | This were just unclean, (an invisble sort of uncleanliness, but still there are liable to make for ugly diffs). Oh, wait, like this one! But at least it's not sprinkled among code changes.
* Clarify documentation and error string for NOTMUCH_STATUS_TAG_TOO_LONGCarl Worth2009-10-23
| | | | It's helpful to point out NOTMUCH_STATUS_TAG_MAX for users.
* Add notmuch_database_set_timestamp and notmuch_database_get_timestampCarl Worth2009-10-23
| | | | | These will be very helpful to implement an efficient "notmuch new" command which imports new mail messages that have appeared.
* database: Add private find_unique_doc_id and find_unique_document functionsCarl Worth2009-10-23
| | | | | | These are a generalization of the unique-ness testing of notmuch_database_find_message. More preparation for firectory timestamps.
* database: Similarly rename find_message_by_docid to find_document_for_doc_idCarl Worth2009-10-23
| | | | | | | | Again preferring notmuch_database_t* over Xapian::Database*. Also, we're standardizing on "doc_id" rather than "docid" locally, (as an analoge to "message_id"), in spite of the "Xapian::docid" name, (which, fortunately, we can ignore and just us "unsigned int" instead).
* database: Rename internal find_messages_by_term to find_doc_idsCarl Worth2009-10-23
| | | | | | | | | | This name is a more accurate description of what it does, and the more general naming will make sense as we start storing non-message documents in the database (such as directory timestamps). Also, don't pass around a Xapian::Database where it's more our style to pass a notmuch_database_t*.
* sha1: Add new notmuch_sha1_of_string functionCarl Worth2009-10-23
| | | | | | | | | | | | | | | We'll be using this for storing really long terms in the database and when we just need to look them up, (and never read back the original data directly from the database). For example, storing arbitrarily long directory paths in the database along with mtime timestamps. Note that if we did want to store arbitrarily long terms and also be able to read them back, the Xapian folks recommending splitting the term off with multiple prefixes. See the note near the end of this page: http://trac.xapian.org/wiki/FAQ/UniqueIds
* notmuch restore: Print names of tags that cannot be appliedCarl Worth2009-10-23
| | | | | | | | | | | | | | | | This helps the user gauge the severity of the error. For example, when restoring my sup tags I see a bunch of tags missing for message IDs of the form "sup-faked-...". That's not surprising since I know that sup generates these with the md5sum of the message header while notmuch uses the sha-1 of the entire message. But how much will this hurt? Well, now that I can see that most of the missing tags are just "attachment", then I'm not concerned, (I'll be automatically creating that tag in the future based on the message contents). But if a missing tag is "inbox" then that's more concerning because that's data that I can't easily regenerate outside of sup.
* notmuch_tags_has_more: Fix to use string.empty rather than string.sizeCarl Worth2009-10-23
| | | | | I'm really interested in the length of the data here, not the size of the storage.
* Fix notmuch_message_get_message_id to never return NULL.Carl Worth2009-10-23
| | | | | | With the recent improvements to the handling of message IDs we "know" that a NULL message ID is impossible, (so we simply abort if the impossible happens).
* add_message: Fix to not add multiple documents with the same message IDCarl Worth2009-10-23
| | | | | | | | Here's the second big fix to message-ID handling, (the first was to generate message IDs when an email contained none). Now, with no document missing a message ID, and no two documents having the same message ID, we have a nice consistent database where the message ID can be used as a unique key.
* Add _notmuch_message_create_for_message_idCarl Worth2009-10-23
| | | | | | | This is the last piece needed for add_message to be able to properly support a message with a duplicate message ID. This function creates a new notmuch_message_t object but one that may reference an existing document in the database.
* Fix _notmuch_message_create to catch Xapian DocNotFoundError.Carl Worth2009-10-23
| | | | | | | | This function is only supposed to be called with a doc_id that was queried from the database already. So there's an internal error if no document with that doc_id can be found in the database. In that case, return NULL.
* Add internal functions for manipulating a new notmuch_message_tCarl Worth2009-10-23
| | | | | | | | | | | This will support the add_message function in incrementally creating state in a new notmuch_message_t. The new functions are _notmuch_message_set_filename _notmuch_message_add_thread_id _notmuch_message_ensure_thread_id _notmuch_message_set_date _notmuch_message_sync
* Add notmuch_message_get_filenameCarl Worth2009-10-23
| | | | | | | | This is a new public function to find the filename of the original email message for a message-object that was found in the database. We may change this function in the future to support returning a list of filenames, (for messages with duplicate message IDs).
* add_message: Re-order the code a bit (find message-id first).Carl Worth2009-10-23
| | | | | | | | We're preparing for being able to deal with files with duplicate message IDs here. The plan is to create a notmuch_message_t object in add_message that may or may not reference a document that exists in the database. So to do this, we have to find the message ID before we do any manipulation of the doc.
* Move thread_id generation code from database.cc to message.ccCarl Worth2009-10-23
| | | | It's really up to the message to decide how to generate these.
* Move the _notmuch_message_sync from private to public interfacesCarl Worth2009-10-23
| | | | | | | | | | | The idea here is to allow internal users to see a non-synced message object, (for example, while parsing a message file and incrementally adding terms, etc.). We're willing to take the care to get the improved performance. But for the public interface, keeping everything synced will be much less confusing, (reference lots of sup bugs that happen due to message state being altered by the user but not synced to the database).
* add_message: Rename message to message_fileCarl Worth2009-10-23
| | | | | | | | | I still don't like the name message_file at all, but we're about to start using a notmuch_message_t in this function so we need to do something to keep the identifiers separate for now. Eventually, it probably makes sense to push the message-parsing code from database.cc to message.cc.
* Prevent that last bug from reoccurring.Carl Worth2009-10-22
| | | | | | | It's even enough to check if a "missing" header was accidentally left off the list in the call to restrict_headers. (And it's cheap since we only check in case no such header was found in the message.)
* Don't forget the "to" header when restrict parsing to certain headersCarl Worth2009-10-22
| | | | | | | | | | We recently started discarding files as "not email" if they have none of Subject, From, nor To. Apaprently, my mail collection contains a number of messages that I sent, that are saved without Subject and From, (perhaps these were drafts?). Anyway, it's fortunate I had those since they alerted me to this bug, where we were not parsing the "To" header in some cases.
* Fix missing error check.Carl Worth2009-10-22
| | | | | The notmuch_message_file_open function is perfectly capable of returning NULL. So check for it.
* Generate message ID (using SHA1) when a mail message contains none.Carl Worth2009-10-22
| | | | | | This is important as we're using the message ID as the unique key in our database. So previously, all messages with no message ID would be treated as the same message---not good at all.
* Rename sha1.c to libsha1.cCarl Worth2009-10-21
| | | | | | | | | This way both the .c and .h files have the same name, and all of the code imported from the "libsha1" implementation is in filenames matching libsha1.*. This also gives me room to make my own notmuch_sha1 wrapper functions in sha1.c.
*-. Merge branch from fixing up bugs after bisecting.Carl Worth2009-10-21
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm glad that when I implemented "notmuch restore" I went through the extra effort to take the code I had written in one sitting into over a dozen commits. Sure enough, I hadn't tested well enough and had totally broken "notmuch setup", (segfaults and bogus thread_id values). With the little commits I had made, git bisect saved the day, and I went back to make the fixes right on top of the commits that introduced the bugs. So now we octopus merge those in.
| | * Bring back the insert_thread_id function.Carl Worth2009-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We deleted this in favor of our fancy new thread_ids iterator from the message object. But one of the previous callers of insert_thread_id isn't using notmuch_message_t yet. I made the mistake of thinking I could just call g_hash_table_insert directly, but the problem was that nobody was splitting up the thread_id string at its commas. So with this, we were inserting bogus comma-separated IDs into the hash table, so thread_id values were ballooning out of control. Should be much better now.
| * | Fix lifetime-maintenance bug with std::string and c_str()Carl Worth2009-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here's more evidence that C++ is a nightmare to program---or that I'm smart enough to realize that C++ is more clever than I will ever be. Most of my issues with C++ have to do with it hiding things from me that I'd really like to and expect to be aware of as a C programmer. For example, the specific problem here is that there's a short-lived std::string, from which I just want to copy the C string. I try to do that on the next line, but before I can, C++ has already called the destructor on the std::string. Now, C++ isn't alone in doing garbage collecting like this. But in a *real* garbage-collecting system, everything would work that way. For example, here, I'm still holding a pointer to the C string contents, so if the garbage collector were aware of that reference, then it might clean up the std::string container and leave the data I'm still using. But that's not what we get with C++. Instead, some things are reference counted and collected, (like the std::string), and some things just aren't (like the C string it contains). The end result is that it's very fragile. It forces me to be aware of the timing of hidden functions. In a "real" system I wouldn't have to be aware of that timing, and in C the function just wouldn't be hidden.
* | | List a few more co-conspirators.Carl Worth2009-10-21
| | | | | | | | | | | | | | | | | | | | | Keith's name already shows up in the git log, so it would be wrong to not mention him. And Martin and Jamey have been helpful in discussions about what an ideal mail system would look like.
* | | Add an AUTHORS file.Carl Worth2009-10-21
| | | | | | | | | | | | | | | Now that I've copied in another source file from someone else, I want to be sure I'm keeping a good list of everyone who has helped.
* | | Add sha1.c and libsha1.h for doing SHA-1-based message-ID generation.Mikhail Gusarov2009-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code comes courtesy of Brian Gladman and Mikhail Gusarov. Both files are available under the GPL and were downloaded as version 0.2 of libsha1 from git://github.com/dottedmag/libsha1.git with the following commit: commit d0f0e7e0dc5ce2d58972cb5a492183c0d4e58433 Author: Mikhail Gusarov <dottedmag@dottedmag.net> Date: Mon Oct 20 22:38:47 2008 +0700 Version bump. Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
* | | Add copy of GNU General Public License (version 3).Carl Worth2009-10-21
| | | | | | | | | | | | | | | All the files were already advertising the license, but we didn't actually have a copy of the license in the repository until now.
* | | Add notmuch_status_to_string function.Carl Worth2009-10-21
| | | | | | | | | | | | | | | Be kind and let the user print error messages, not just error codes.
* | | Implement "notmuch restore".Carl Worth2009-10-21
| | | | | | | | | | | | | | | | | | It's pretty easy to do with all the right infrastructure in place. Now that I can get my tags from sup to notmuch, maybe I'll be able to start reading mail again.
* | | Pull out a chomp_newline function from "notmuch setup"Carl Worth2009-10-21
| | | | | | | | | | | | | | | We'll want this same thing with "notmuch restore", (and really anything using getline).
* | | Add notmuch_message_add_tag and notmuch_message_remove_tagCarl Worth2009-10-21
| | | | | | | | | | | | | | | With these two added, we now have enough functionality in the library to implement "notmuch restore".
* | | notmuch-private.h: Move NOTMUCH_BEGIN_DECLS earlierCarl Worth2009-10-21
| | | | | | | | | | | | | | | | | | | | | We actually need this before the include of xutil.h, but it was previously stuck randomly among various system includes. Instead, put it at the top, right after include the notmuch.h header that defines it.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 07:07:44 +0000