song: use flex arrays to store song->url

Reduce the number of allocations we make, so there's less
pressure on the allocator and less overhead to keep track
of the allocations in.

1 files changed, 6 insertions, 2 deletions

diff --git a/src/song.h b/src/song.h
index f7466e24..e2e74928 100644
--- a/src/song.h
+++ b/src/song.h
@@ -20,6 +20,7 @@
 #define SONG_H
 
 #include "os_compat.h"
+#include "gcc.h"
 
 #define SONG_BEGIN	"songList begin"
 #define SONG_END	"songList end"
@@ -35,12 +36,15 @@ enum song_type {
 struct client;
 
 typedef struct _Song {
-	char *url;
 	enum song_type type;
 	struct tag *tag;
 	struct _Directory *parentDir;
 	time_t mtime;
-} Song;
+	char url[1];
+} mpd_packed Song;
+
+Song *
+song_alloc(const char *url, enum song_type type, struct _Directory *parent);
 
 Song *newSong(const char *url, enum song_type type,
 	      struct _Directory *parentDir);