audio: replaced copyAudioFormat() with simple assignment

The "!src" check in copyAudioFormat() used to hide bugs - one should
never pass NULL to it.  There is one caller which might pass NULL, add
a check in this caller.

Instead of doing mempcy(), we can simply assign the structures, which
looks more natural.

1 files changed, 3 insertions, 5 deletions

diff --git a/src/output_control.c b/src/output_control.c
index 8a5e14e0..3459a904 100644
--- a/src/output_control.c
+++ b/src/output_control.c
@@ -32,14 +32,12 @@ int audio_output_open(struct audio_output *audioOutput,
 		return 0;
 	}
 
-	copyAudioFormat(&audioOutput->inAudioFormat, audioFormat);
+	audioOutput->inAudioFormat = *audioFormat;
 
 	if (audioOutput->convertAudioFormat) {
-		copyAudioFormat(&audioOutput->outAudioFormat,
-		                &audioOutput->reqAudioFormat);
+		audioOutput->outAudioFormat = audioOutput->reqAudioFormat;
 	} else {
-		copyAudioFormat(&audioOutput->outAudioFormat,
-		                &audioOutput->inAudioFormat);
+		audioOutput->outAudioFormat = audioOutput->inAudioFormat;
 		if (audioOutput->open)
 			audio_output_close(audioOutput);
 	}