diff options
| author | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
| commit | e3af0032b236dc52d4a74c4d740e57a1f6d520aa (patch) | |
| tree | 3984233a9b639e71ad80b4f6598539de3a27a008 /src/output/recorder_output_plugin.c | |
| parent | 9b21152600071ec46c021c8ba3b2ef69c90f039f (diff) | |
set the close-on-exec flag on all file descriptors
Added the "fd_util" library, which attempts to use the new thread-safe
Linux system calls pipe2(), accept4() and the options O_CLOEXEC,
SOCK_CLOEXEC. Without these, it falls back to FD_CLOEXEC, which is
not thread safe.
This is particularly important for the "pipe" output plugin (and
others, such as JACK/PulseAudio), because we were heavily leaking file
descriptors to child processes.
Diffstat (limited to 'src/output/recorder_output_plugin.c')
| -rw-r--r-- | src/output/recorder_output_plugin.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/output/recorder_output_plugin.c b/src/output/recorder_output_plugin.c index 413e5d0d..202b5607 100644 --- a/src/output/recorder_output_plugin.c +++ b/src/output/recorder_output_plugin.c @@ -20,6 +20,7 @@ #include "output_api.h" #include "encoder_plugin.h" #include "encoder_list.h" +#include "fd_util.h" #include <assert.h> #include <sys/types.h> @@ -156,7 +157,7 @@ recorder_output_open(void *data, struct audio_format *audio_format, /* create the output file */ - recorder->fd = creat(recorder->path, 0666); + recorder->fd = creat_cloexec(recorder->path, 0666); if (recorder->fd < 0) { g_set_error(error_r, recorder_output_quark(), 0, "Failed to create '%s': %s", |