diff options
| author | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
| commit | e3af0032b236dc52d4a74c4d740e57a1f6d520aa (patch) | |
| tree | 3984233a9b639e71ad80b4f6598539de3a27a008 /src/output/fifo_output_plugin.c | |
| parent | 9b21152600071ec46c021c8ba3b2ef69c90f039f (diff) | |
set the close-on-exec flag on all file descriptors
Added the "fd_util" library, which attempts to use the new thread-safe
Linux system calls pipe2(), accept4() and the options O_CLOEXEC,
SOCK_CLOEXEC. Without these, it falls back to FD_CLOEXEC, which is
not thread safe.
This is particularly important for the "pipe" output plugin (and
others, such as JACK/PulseAudio), because we were heavily leaking file
descriptors to child processes.
Diffstat (limited to 'src/output/fifo_output_plugin.c')
| -rw-r--r-- | src/output/fifo_output_plugin.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/output/fifo_output_plugin.c b/src/output/fifo_output_plugin.c index d3145748..0217c267 100644 --- a/src/output/fifo_output_plugin.c +++ b/src/output/fifo_output_plugin.c @@ -20,6 +20,7 @@ #include "output_api.h" #include "utils.h" #include "timer.h" +#include "fd_util.h" #include <glib.h> @@ -152,7 +153,7 @@ fifo_open(struct fifo_data *fd, GError **error) if (!fifo_check(fd, error)) return false; - fd->input = open(fd->path, O_RDONLY|O_NONBLOCK); + fd->input = open_cloexec(fd->path, O_RDONLY|O_NONBLOCK); if (fd->input < 0) { g_set_error(error, fifo_output_quark(), errno, "Could not open FIFO \"%s\" for reading: %s", @@ -161,7 +162,7 @@ fifo_open(struct fifo_data *fd, GError **error) return false; } - fd->output = open(fd->path, O_WRONLY|O_NONBLOCK); + fd->output = open_cloexec(fd->path, O_WRONLY|O_NONBLOCK); if (fd->output < 0) { g_set_error(error, fifo_output_quark(), errno, "Could not open FIFO \"%s\" for writing: %s", |