conf: turn config_get_path() into config_dup_path()

config_get_path() was somewhat flawed, because it pretended to be a
function, when it really had a side effect.  The second flaw was that
it did not return the parser error, instead it aborted the whole
process, which is bad style.  The new function returns a duplicated
(modified) string that must be freed by the caller, and returns a
GError on failure.

1 files changed, 12 insertions, 4 deletions

diff --git a/src/log.c b/src/log.c
index 140b50a2..86dd86ea 100644
--- a/src/log.c
+++ b/src/log.c
@@ -271,10 +271,18 @@ log_init(bool verbose, bool use_stdout, GError **error_r)
 			return true;
 #endif
 		} else {
-			const char *path = config_get_path(CONF_LOG_FILE);
-			assert(path != NULL);
-
-			return log_init_file(path, param->line, error_r);
+			GError *error = NULL;
+			char *path = config_dup_path(CONF_LOG_FILE, &error);
+			if (path == NULL) {
+				assert(error != NULL);
+				g_propagate_error(error_r, error);
+				return false;
+			}
+
+			bool success = log_init_file(path, param->line,
+						     error_r);
+			g_free(path);
+			return success;
 		}
 	}
 }