diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-01-16 16:24:42 +0100 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-01-19 12:18:17 +0100 |
| commit | cb592ae95fffff3fc06afee22703a9800d80833c (patch) | |
| tree | 3a244c6d09e527f579c24eba33aa52b0c4ad7cb6 /tests | |
| parent | 9f7e0b37ffc76e2ad0e5a2b007601cfdd6cc201d (diff) | |
avformat/matroskaenc: Remove duplicated code for writing WebVTT subs
Up until now, the WebM variant of WebVTT subtitles has been handled
specially: It had its own function to write it, because the data
had to be reformatted before writing. But given that other codecs
also need reformatting, this is no good reason to also duplicate the
generic stuff for writing Block(Group)s.
This commit therefore uses an ordinary reformatting function for
this task; writing WebVTT subtitles now uses the generic code
and therefore automatically uses the least amount of bytes
for its BlockGroup length fields whereas the earlier code used
an overestimation for the length of the Duration element.
This is the reason for the changes to the webm-webvtt-remux FATE-test.
(This commit does not implement support for Matroska's way of muxing
WebVTT; it also does not add checks to ensure that WebM-style subtitles
don't get muxed in Matroska. But the function for reformatting gets a
webm prefix to indicate that this is for WebM.)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/ref/fate/webm-webvtt-remux | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/ref/fate/webm-webvtt-remux b/tests/ref/fate/webm-webvtt-remux index 15e919d74b..d847bbee2b 100644 --- a/tests/ref/fate/webm-webvtt-remux +++ b/tests/ref/fate/webm-webvtt-remux @@ -1,5 +1,5 @@ -c5625f28e6968e12d91f125edef5f16c *tests/data/fate/webm-webvtt-remux.webm -6560 tests/data/fate/webm-webvtt-remux.webm +8620a6614f149fc49ab7f4552373943e *tests/data/fate/webm-webvtt-remux.webm +6556 tests/data/fate/webm-webvtt-remux.webm #tb 0: 1/1000 #media_type 0: subtitle #codec_id 0: webvtt |