summaryrefslogtreecommitdiff
path: root/libavdevice
diff options
context:
space:
mode:
authorLuca Barbato <lu_zero@gentoo.org>2015-03-14 12:30:10 +0100
committerLuca Barbato <lu_zero@gentoo.org>2015-04-30 14:10:13 +0200
commit82a10225f817b2612fdd2b23af9d4f0a3408df3b (patch)
tree350759da4f5df0c1668d20bb52934e3ab745cbc2 /libavdevice
parenta09c499a2e25ded575cb9f37528384402be86ad8 (diff)
xcbgrab: Do not assume the non shm image data is always available
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Diffstat (limited to 'libavdevice')
-rw-r--r--libavdevice/xcbgrab.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c
index 13284ec9d4..decb7a7a30 100644
--- a/libavdevice/xcbgrab.c
+++ b/libavdevice/xcbgrab.c
@@ -145,13 +145,25 @@ static int xcbgrab_frame(AVFormatContext *s, AVPacket *pkt)
xcb_get_image_cookie_t iq;
xcb_get_image_reply_t *img;
xcb_drawable_t drawable = c->screen->root;
+ xcb_generic_error_t *e = NULL;
uint8_t *data;
int length, ret;
iq = xcb_get_image(c->conn, XCB_IMAGE_FORMAT_Z_PIXMAP, drawable,
c->x, c->y, c->width, c->height, ~0);
- img = xcb_get_image_reply(c->conn, iq, NULL);
+ img = xcb_get_image_reply(c->conn, iq, &e);
+
+ if (e) {
+ av_log(s, AV_LOG_ERROR,
+ "Cannot get the image data "
+ "event_error: response_type:%u error_code:%u "
+ "sequence:%u resource_id:%u minor_code:%u major_code:%u.\n",
+ e->response_type, e->error_code,
+ e->sequence, e->resource_id, e->minor_code, e->major_code);
+ return AVERROR(EACCES);
+ }
+
if (!img)
return AVERROR(EAGAIN);
@@ -405,7 +417,7 @@ static int xcbgrab_read_packet(AVFormatContext *s, AVPacket *pkt)
ret = xcbgrab_frame(s, pkt);
#if CONFIG_LIBXCB_XFIXES
- if (c->draw_mouse && p->same_screen)
+ if (ret >= 0 && c->draw_mouse && p->same_screen)
xcbgrab_draw_mouse(s, pkt, p, geo);
#endif