summaryrefslogtreecommitdiff
path: root/libavcodec/nellymoserdec.c
diff options
context:
space:
mode:
authorJustin Ruggles <justin.ruggles@gmail.com>2011-10-17 10:22:46 -0400
committerJustin Ruggles <justin.ruggles@gmail.com>2011-10-28 14:40:52 -0400
commit0aaa85dbedbd4029dac0e78f10a412c7ec9a0d4d (patch)
treea171e3f306a19bbe38a014dc79d2ec8bfccbb784 /libavcodec/nellymoserdec.c
parentf19305fe93e3b400f4d6f0c3450e40e0605878d0 (diff)
nellymoserdec: fail if output buffer is too small
avoids silently truncating the output
Diffstat (limited to 'libavcodec/nellymoserdec.c')
-rw-r--r--libavcodec/nellymoserdec.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/libavcodec/nellymoserdec.c b/libavcodec/nellymoserdec.c
index ec045af16b..3812d78b11 100644
--- a/libavcodec/nellymoserdec.c
+++ b/libavcodec/nellymoserdec.c
@@ -176,8 +176,12 @@ static int decode_tag(AVCodecContext * avctx,
return buf_size;
}
block_size = NELLY_SAMPLES * av_get_bytes_per_sample(avctx->sample_fmt);
- blocks = FFMIN(buf_size / NELLY_BLOCK_LEN, *data_size / block_size);
+ blocks = buf_size / NELLY_BLOCK_LEN;
if (blocks <= 0) {
+ av_log(avctx, AV_LOG_ERROR, "Packet is too small\n");
+ return AVERROR_INVALIDDATA;
+ }
+ if (*data_size < blocks * block_size) {
av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n");
return AVERROR(EINVAL);
}