summaryrefslogtreecommitdiff
path: root/libavcodec/cook.c
diff options
context:
space:
mode:
authorJustin Ruggles <justin.ruggles@gmail.com>2011-10-26 21:11:13 -0400
committerJustin Ruggles <justin.ruggles@gmail.com>2011-10-29 13:43:28 -0400
commite34c6c9708336b9445574bb6ddb48416368af963 (patch)
treef8fd6f0b39081e0abb838400419bce4e37ff0fbe /libavcodec/cook.c
parent6631294c26b82f11b1862bdc3a6685a201afd19d (diff)
cook: check output buffer size before decoding
Diffstat (limited to 'libavcodec/cook.c')
-rw-r--r--libavcodec/cook.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/libavcodec/cook.c b/libavcodec/cook.c
index eefbf4ad48..9e3cd624a0 100644
--- a/libavcodec/cook.c
+++ b/libavcodec/cook.c
@@ -955,13 +955,20 @@ static int cook_decode_frame(AVCodecContext *avctx,
const uint8_t *buf = avpkt->data;
int buf_size = avpkt->size;
COOKContext *q = avctx->priv_data;
- int i;
+ int i, out_size;
int offset = 0;
int chidx = 0;
if (buf_size < avctx->block_align)
return buf_size;
+ out_size = q->nb_channels * q->samples_per_channel *
+ av_get_bytes_per_sample(avctx->sample_fmt);
+ if (*data_size < out_size) {
+ av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n");
+ return AVERROR(EINVAL);
+ }
+
/* estimate subpacket sizes */
q->subpacket[0].size = avctx->block_align;
@@ -984,8 +991,7 @@ static int cook_decode_frame(AVCodecContext *avctx,
chidx += q->subpacket[i].num_channels;
av_log(avctx,AV_LOG_DEBUG,"subpacket[%i] %i %i\n",i,q->subpacket[i].size * 8,get_bits_count(&q->gb));
}
- *data_size = q->nb_channels * q->samples_per_channel *
- av_get_bytes_per_sample(avctx->sample_fmt);
+ *data_size = out_size;
/* Discard the first two frames: no valid audio. */
if (avctx->frame_number < 2) *data_size = 0;