summaryrefslogtreecommitdiff
path: root/libavcodec/cbs_av1.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-06-18 14:37:38 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-06-24 15:56:24 +0200
commit6f06c17a55137855c67ba4a7b6778ca34ddbbe6b (patch)
treea6ed27681dea134fcadab94394aaccab8ff1fe71 /libavcodec/cbs_av1.c
parent8ee6557c2e93166a03ef8588a09674e4a083d43b (diff)
avcodec/cbs_av1: Fix writing uvlc numbers >= INT_MAX
Fixes: assertion failure Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 23264/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_METADATA_fuzzer-6308429248593920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Diffstat (limited to 'libavcodec/cbs_av1.c')
-rw-r--r--libavcodec/cbs_av1.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c
index 29b316e011..0abcba9c60 100644
--- a/libavcodec/cbs_av1.c
+++ b/libavcodec/cbs_av1.c
@@ -125,8 +125,9 @@ static int cbs_av1_write_uvlc(CodedBitstreamContext *ctx, PutBitContext *pbc,
put_bits(pbc, 1, 1);
} else {
zeroes = av_log2(value + 1);
- v = value - (1 << zeroes) + 1;
- put_bits(pbc, zeroes + 1, 1);
+ v = value - (1U << zeroes) + 1;
+ put_bits(pbc, zeroes, 0);
+ put_bits(pbc, 1, 1);
put_bits(pbc, zeroes, v);
}