summaryrefslogtreecommitdiff
path: root/libavcodec/bmp.c
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2012-09-16 08:33:09 +0200
committerAnton Khirnov <anton@khirnov.net>2012-09-16 09:43:17 +0200
commit8b78c2969a5b7dca939d93bf525aa2bcd737b5d9 (patch)
treef3052fb9c05d41a7c9db1714ab9e9c19bf124e0d /libavcodec/bmp.c
parent1c9d54b468e4b026dab2cf86d7993da06d00eda1 (diff)
bmpdec: only initialize palette for pal8.
Gray8 is not considered to be paletted, so this would cause an invalid write. Fixes bug 367. CC: libav-stable@libav.org
Diffstat (limited to 'libavcodec/bmp.c')
-rw-r--r--libavcodec/bmp.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/libavcodec/bmp.c b/libavcodec/bmp.c
index 299f37c95f..3af25cd333 100644
--- a/libavcodec/bmp.c
+++ b/libavcodec/bmp.c
@@ -228,9 +228,6 @@ static int bmp_decode_frame(AVCodecContext *avctx,
if(comp == BMP_RLE4 || comp == BMP_RLE8)
memset(p->data[0], 0, avctx->height * p->linesize[0]);
- if(depth == 4 || depth == 8)
- memset(p->data[1], 0, 1024);
-
if(height > 0){
ptr = p->data[0] + (avctx->height - 1) * p->linesize[0];
linesize = -p->linesize[0];
@@ -241,6 +238,9 @@ static int bmp_decode_frame(AVCodecContext *avctx,
if(avctx->pix_fmt == PIX_FMT_PAL8){
int colors = 1 << depth;
+
+ memset(p->data[1], 0, 1024);
+
if(ihsize >= 36){
int t;
buf = buf0 + 46;