summaryrefslogtreecommitdiff
path: root/libavcodec/arm/hpeldsp_armv6.S
diff options
context:
space:
mode:
authorJanne Grunau <janne-libav@jannau.net>2014-03-05 12:44:57 +0100
committerJanne Grunau <janne-libav@jannau.net>2014-03-05 14:30:57 +0100
commitcbddee1cca0ebd01e8c5aa694d31228eb4de4b41 (patch)
tree95e3e73f0d5ccb6e54ed587e6fb547080bf71371 /libavcodec/arm/hpeldsp_armv6.S
parent3741aa37c2a0d0717faff74a5c4cc357d16f6d1d (diff)
arm: hpeldsp: prevent overreads in armv6 asm
Based on a patch by Russel King <rmk+libav@arm.linux.org.uk> Bug-Id: 646 CC: libav-stable@libav.org
Diffstat (limited to 'libavcodec/arm/hpeldsp_armv6.S')
-rw-r--r--libavcodec/arm/hpeldsp_armv6.S20
1 files changed, 12 insertions, 8 deletions
diff --git a/libavcodec/arm/hpeldsp_armv6.S b/libavcodec/arm/hpeldsp_armv6.S
index f85c8cb82c..984e0f0e32 100644
--- a/libavcodec/arm/hpeldsp_armv6.S
+++ b/libavcodec/arm/hpeldsp_armv6.S
@@ -132,11 +132,12 @@ function ff_put_pixels8_y2_armv6, export=1
uhadd8 r9, r5, r7
eor r11, r5, r7
and r10, r10, r12
- ldr_pre r4, r1, r2
+ ldrc_pre ne, r4, r1, r2
uadd8 r8, r8, r10
and r11, r11, r12
uadd8 r9, r9, r11
- ldr r5, [r1, #4]
+ it ne
+ ldrne r5, [r1, #4]
uhadd8 r10, r4, r6
eor r6, r4, r6
uhadd8 r11, r5, r7
@@ -144,10 +145,11 @@ function ff_put_pixels8_y2_armv6, export=1
eor r7, r5, r7
uadd8 r10, r10, r6
and r7, r7, r12
- ldr_pre r6, r1, r2
+ ldrc_pre ne, r6, r1, r2
uadd8 r11, r11, r7
strd_post r8, r9, r0, r2
- ldr r7, [r1, #4]
+ it ne
+ ldrne r7, [r1, #4]
strd_post r10, r11, r0, r2
bne 1b
@@ -192,13 +194,15 @@ function ff_put_pixels8_y2_no_rnd_armv6, export=1
1:
subs r3, r3, #2
uhadd8 r8, r4, r6
- ldr_pre r4, r1, r2
+ ldrc_pre ne, r4, r1, r2
uhadd8 r9, r5, r7
- ldr r5, [r1, #4]
+ it ne
+ ldrne r5, [r1, #4]
uhadd8 r12, r4, r6
- ldr_pre r6, r1, r2
+ ldrc_pre ne, r6, r1, r2
uhadd8 r14, r5, r7
- ldr r7, [r1, #4]
+ it ne
+ ldrne r7, [r1, #4]
stm r0, {r8,r9}
add r0, r0, r2
stm r0, {r12,r14}