summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-09-30 23:42:41 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-10-01 22:16:20 +0200
commitc4de49edc4652e2f17c8747a6dd9b36ff362017a (patch)
tree9b23abd86ec727fe310f67b49532dcfea9c48a33
parent87b7e141a6fda7f450aff4560b776d546af313ed (diff)
avformat/electronicarts: If no packet has been read at the end do not treat it as if theres a packet
Fixes: Assertion failure Fixes: 17770/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5700606668308480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Peter Ross <pross@xvid.org> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/electronicarts.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
index 6dbc3e350a..c894663c29 100644
--- a/libavformat/electronicarts.c
+++ b/libavformat/electronicarts.c
@@ -574,11 +574,12 @@ static int ea_read_packet(AVFormatContext *s, AVPacket *pkt)
EaDemuxContext *ea = s->priv_data;
AVIOContext *pb = s->pb;
int partial_packet = 0;
+ int hit_end = 0;
unsigned int chunk_type, chunk_size;
int ret = 0, packet_read = 0, key = 0;
int av_uninit(num_samples);
- while (!packet_read || partial_packet) {
+ while ((!packet_read && !hit_end) || partial_packet) {
chunk_type = avio_rl32(pb);
chunk_size = ea->big_endian ? avio_rb32(pb) : avio_rl32(pb);
if (chunk_size < 8)
@@ -676,7 +677,7 @@ static int ea_read_packet(AVFormatContext *s, AVPacket *pkt)
}
if (avio_feof(pb))
ret = AVERROR_EOF;
- packet_read = 1;
+ hit_end = 1;
break;
case MVIh_TAG:
@@ -737,6 +738,9 @@ get_video_packet:
if (ret < 0 && partial_packet)
av_packet_unref(pkt);
+ if (ret >= 0 && hit_end && !packet_read)
+ return AVERROR(EAGAIN);
+
return ret;
}