summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2013-01-29 17:19:08 +0100
committerAnton Khirnov <anton@khirnov.net>2013-02-06 10:21:52 +0100
commit2cd4068071b9a8908823a3107f97e938211045ce (patch)
tree80926438d7e983628e2c19adc75abcbb0d09bca5
parentda7baaaae79b4d7d715d35ea6bcfbdd149edc177 (diff)
fraps: fix off-by one bug for version 1.
CC:libav-stable@libav.org
-rw-r--r--cmdutils.c2
-rw-r--r--libavcodec/fraps.c2
-rw-r--r--tests/ref/fate/fraps-v12
3 files changed, 3 insertions, 3 deletions
diff --git a/cmdutils.c b/cmdutils.c
index dbe22e3ea4..a9523aec74 100644
--- a/cmdutils.c
+++ b/cmdutils.c
@@ -1566,7 +1566,7 @@ static int alloc_buffer(FrameBuffer **pool, AVCodecContext *s, FrameBuffer **pbu
/* XXX this shouldn't be needed, but some tests break without this line
* those decoders are buggy and need to be fixed.
* the following tests fail:
- * fraps-v1, qtrle-1bit
+ * qtrle-1bit
*/
memset(buf->base[0], 128, ret);
diff --git a/libavcodec/fraps.c b/libavcodec/fraps.c
index 5473bd8b76..237cb743f9 100644
--- a/libavcodec/fraps.c
+++ b/libavcodec/fraps.c
@@ -239,7 +239,7 @@ static int decode_frame(AVCodecContext *avctx,
if (f->pict_type == AV_PICTURE_TYPE_I) {
for (y = 0; y<avctx->height; y++)
- memcpy(&f->data[0][(avctx->height - y) * f->linesize[0]],
+ memcpy(&f->data[0][(avctx->height - y - 1) * f->linesize[0]],
&buf[y * avctx->width * 3],
3 * avctx->width);
}
diff --git a/tests/ref/fate/fraps-v1 b/tests/ref/fate/fraps-v1
index 64392c33b4..29c7e37df3 100644
--- a/tests/ref/fate/fraps-v1
+++ b/tests/ref/fate/fraps-v1
@@ -1,2 +1,2 @@
#tb 0: 1/25
-0, 0, 0, 1, 230400, 0x6bc891ff
+0, 0, 0, 1, 230400, 0x23c29d17