| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made all variables in CarpetLib:gh to be const or non-public, to avoid
confusion and insanity.
Toward this end, created four member accessors for gh:
const rexts & extents() const
const rbnds & outer_boundaries() const
const rprocs & processors() const
const vector<vector<ibbox> > & bases() const
This involved a few changes in several files throughout the repository:
M ./Carpet/Carpet/src/Initialise.cc -2 +2
M ./Carpet/Carpet/src/Recompose.cc -8 +8
M ./Carpet/Carpet/src/SetupGH.cc -2 +2
M ./Carpet/Carpet/src/modes.cc -3 +3
M ./Carpet/CarpetIOHDF5/src/Recover.cc -4 +4
M ./Carpet/CarpetInterp/src/interp.cc -5 +5
M ./Carpet/CarpetLib/src/dh.cc -3 +3
M ./Carpet/CarpetLib/src/gh.cc -33 +33
M ./Carpet/CarpetLib/src/gh.hh -10 +28
M ./Carpet/CarpetReduce/src/mask_carpet.cc -4 +4
M ./Carpet/CarpetRegrid/src/automatic.cc -2 +2
darcs-hash:20041210131459-32473-ff0835ff0e57f6693fbe1ec23b350d1b1d18e3bc.gz
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tightened access to a few public members of gh class.
Made a few const (they are never modified after construction),
Made a couple private.
There are several more with scary access: full public non-const
(extents, e.g.) which is used all over and ... try not to think about it.
darcs-hash:20041210004122-32473-3ed8ee7f07ea9f13400f51f580dc1d29a4258a1a.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The g* classes had exposed public member variables which were never
meant to be altered from outside (I imagine altering most of them
would have resulted in very bad behaviour); I made most of these const.
This resulted in some complaints by the compiler about the canonical
constructor and assignment ops, so I provided private dummies.
This patch contains the following changes:
M ./Carpet/CarpetLib/src/gdata.cc +6
M ./Carpet/CarpetLib/src/gdata.hh -2 +2
M ./Carpet/CarpetLib/src/gf.hh +5
M ./Carpet/CarpetLib/src/ggf.hh -9 +15
darcs-hash:20041209172710-32473-46d2a93e11f21f305467b375fe15910d47b8e4de.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke down monster function data::interpolate_from_innerloop to make
its overall logic visible.
Added three functions
void data::Check_that_the_times_are_consistent
bool data::interpolate_in_time
void data::interpolate_prolongate
void data::interpolate_restrict
Made constant 'eps' to be static file scope.
Got rid of another nasty surprise return.
darcs-hash:20041209121013-32473-e3164f151ce8a67871459c847e1f779a1f6d40fc.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed evil assert from otherwise harmless public accessor gdata::proc().
Very systematically checked that the assert is still done everywhere
this function was previously called.
New functions
bool this_processor_is (int procno);
bool lives_on_this_processor ();
wrapper messy repeated MPI_Comm_rank code.
Had to modify ioascii.cc due to missing assert as explained above, but
found no other instances of calls to proc().
This patch contains the following changes:
M ./Carpet/CarpetIOASCII/src/ioascii.cc +1
M ./Carpet/CarpetLib/src/data.cc -41 +21
M ./Carpet/CarpetLib/src/gdata.cc -6 +19
M ./Carpet/CarpetLib/src/gdata.hh -1 +3
darcs-hash:20041208171657-32473-11da4a7ec810f97b2c82c322119fa69a9ffb4640.gz
|
|
|
|
|
|
|
|
|
| |
Repeated comments like
Catch broken compilers that only know min(int),
when the arguments of the functions could only be floating-point.
So...changed to fabs fmin fmax and got rid of the Catch.
darcs-hash:20041207224657-32473-0f54e7b139bd275e8906f6169400f214e968b1c5.gz
|
|
|
|
|
|
|
| |
Broke this mama of a function into a couple of levels of functional
parts.
darcs-hash:20041201155737-32473-d59b9f090a4d5bac0bce2d668c7ae674d545e660.gz
|
|
|
|
|
|
|
| |
Broke this mama of a function into a couple of levels of functional
parts.
darcs-hash:20041201155737-32473-ce364db1ab14403a823d0bf0937ff4520ed04639.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulled out repeated code into single routine data::fill_box_arrays.
While this is an improvement, I don't like the fact that I've had
to expose the ugly funciton in the data.hh interface, even as private.
It was necessary because the inappropriate declaration of ibbox as
an internal type (of inexplicit access) of the data class.
Down the road, make a separate ibbox declaration.
darcs-hash:20041129175753-32473-a0f983bbaf22ff404cd89a0db814faca0a8f0a7b.gz
|
|
|
|
|
|
| |
Decomposed a long function gh::recompose into smaller functional parts.
darcs-hash:20041129170456-32473-738fb31f621adce8d0437c01c7d250740763c54a.gz
|
|
|
|
|
|
|
|
| |
Fixed indentation
Made order of function declarations more like the order they are
called in.
darcs-hash:20041123182640-32473-a83a83ad132b847bf8b219686e9c88ad277f411c.gz
|
|
|
|
|
|
| |
Fixed a crashing bug. Je suis d[_\e9_]sol[_\e9_].
darcs-hash:20041123164102-32473-7746f9871f6e2f58f84825b8eb38416c622f5cb9.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke up dh<D>::recompose( bool ) into bite-sized chunks.
Made use of member function pointers to cut down as many as three
levels of blocks. See 'foreach_reflevel_component_mglevel'.
Advantages:
1) the code of the main function 'recompose' now presents an outline of
its functionality, rather than a post-ice-age deluge.
2) component functions are named according to some comment found in the
code. For those who want to minimise comments.
3) most of the functions conform to my "rule of thumb" (comprehensible
chunks of code are no longer than my thumb)
4) nesting substantially reduced (The functions that still have more
than 5 levels of nested blocks are mostly those that are also
unthumbworthy. More room on the screen, but still room for
improvement.)
darcs-hash:20041122173415-32473-616506e73f5c93be610bc773adaa7867663cb726.gz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I broke up dh<D>::recompose( bool ) into bite-sized chunks.
I made use of member function pointers to cut down as many as three
levels of blocks. See 'foreach_reflevel_component_mglevel'.
Resulting in:
1) the code of the main function 'recompose' now presents an outline of
its functionality, rather than a post-ice-age deluge.
2) component functions are named according to some comment found in the
code. For those who want to minimise comments.
3) most of the functions conform to my "rule of thumb" (comprehensible
chunks of code are no longer than my thumb)
4) nesting substantially reduced (The functions that still have more
than 5 levels of nested blocks are mostly those that are also
unthumbworthy. More room on the screen, but still room for
improvement.)
Probably some of these functions could have been non-members, but it
was more mechanical to consider them all as members.
darcs-hash:20041119182315-32473-7a328297ba05b013194c23ae5d5b516c1105b7c1.gz
|
|
|
|
|
|
|
|
| |
Add a parameter CarpetLib::use_waitall that switches from using a
series of MPI_Wait statements to using a single MPI_Waitall
statement. This might improve performance on many processors.
darcs-hash:20041124235118-891bb-034efea054db236a187022b1858e4574da867fa3.gz
|
|
|
|
| |
darcs-hash:20041020094227-891bb-aac66b506731e35384752ff0fa0df4e91f689a71.gz
|
|
|
|
| |
darcs-hash:20041009190019-891bb-2b68aaeb88316e252f60603eecc4aef857a7b9d8.gz
|
|
|
|
|
|
| |
Replace all CVS header tags with the standard "$Header:$".
darcs-hash:20040918132147-891bb-dea889bdd94a479ec412d14d08e9efca63e5c24d.gz
|
|
|
|
| |
darcs-hash:20040917143726-07bb3-cdfed6bde9278cc33ad4ad0a04ed13d6a700b65d.gz
|
|
|
|
|
|
|
| |
Explain the harmless compiler warnings about array indices out of
range.
darcs-hash:20040814054125-07bb3-232abf6b8906138d6b7425e2ec05feca8eac2368.gz
|
|
|
|
|
|
|
|
|
|
|
| |
Re-introduce the parameter Carpet::prolongate_initial_data with the
default "yes". If set to "no", newly created refinement levels are
not initialised through prolongation, which saves quite some time.
Remove the unused optional argument checkpoing_recovery from
Carpet::Regrid.
darcs-hash:20040807174712-07bb3-78054ad80959a2e26238531d9ea54eaac161ffce.gz
|
|
|
|
| |
darcs-hash:20040708103601-1d9bf-29cfb972c05ca5c3eb5d8b982818e25132c41433.gz
|
|
|
|
| |
darcs-hash:20040626130809-07bb3-14d132fa6dd6c3fbbba9582f4e7f0f2e78dc9586.gz
|
|
|
|
|
|
|
| |
Simplify logic when evaluating the invariant.
Evaluate the invariant after normalising.
darcs-hash:20040613204648-07bb3-a87112f7ef0cde77040e6453947318cd4e8a7c99.gz
|
|
|
|
|
|
|
| |
Free vector groups leaders only after the other vector elements have
been freed.
darcs-hash:20040608205801-07bb3-96319f89460b351b1d058548e2a2cba6455ea1d0.gz
|
|
|
|
| |
darcs-hash:20040608205722-07bb3-9e14f4d2c51a9ae07887c911270fe8329b0b6ed5.gz
|
|
|
|
|
|
|
| |
Copy the whole exterior during regridding instead of relying on
boundary prolongation.
darcs-hash:20040529093622-07bb3-743ef08b661877e18b6772d31ecb6e18134773da.gz
|
|
|
|
| |
darcs-hash:20040527102609-07bb3-8a80ea8a94dc7739da7e482ae925beb4a01585c3.gz
|
|
|
|
|
|
|
|
|
| |
Add option to use less memory during regridding.
Some more internal consistency checks.
Some reformatting.
darcs-hash:20040521161341-07bb3-de11e460fb175d3dbbd94708730c18a6e94e370a.gz
|
|
|
|
|
|
| |
- bzink
darcs-hash:20040511105326-5b8bb-7120c4b070169b13fd49d63a783cce544482dc68.gz
|
|
|
|
|
|
| |
lead to a code stop after recovery.
darcs-hash:20040511055304-5b8bb-fb243c24af5033c8486914703840895e0bbc82f1.gz
|
|
|
|
| |
darcs-hash:20040504201207-07bb3-b8a9db665cc225198475179abc2d2e6bcd7f2b2f.gz
|
|
|
|
| |
darcs-hash:20040429201506-1d9bf-fdd77458fba0b9716f255c0b732641d0e003b4da.gz
|
|
|
|
| |
darcs-hash:20040424184234-07bb3-d339b61d1d7b5c1880e29c31a54729ab0c5101f6.gz
|
|
|
|
| |
darcs-hash:20040422121713-07bb3-1ef5a3ac1752f5f05d3e010bf9390bc6cff7ea79.gz
|
|
|
|
|
|
|
|
| |
While regridding, initialise only the interior of the grid functions.
There is in general not be enough parent to intialise the outer
boundaries.
darcs-hash:20040420095552-07bb3-812459eafff1161f31a5cb26686ced00b7512b68.gz
|
|
|
|
|
|
|
|
|
|
| |
Regrid all grid functions at once. This is necessary to treate vector
grid functions correctly, where otherwise storage would be released
too early. This requires the regridding interface between the dh and
ggf classes to change. Another advantage is that this should now be
faster on multiple processors.
darcs-hash:20040419193833-07bb3-f7474744feaa57f8a1621aeca34de11b65eaeed8.gz
|
|
|
|
| |
darcs-hash:20040419130015-07bb3-1ec081e478db9a67b131f6f351719b45c9b12a9c.gz
|
|
|
|
| |
darcs-hash:20040419115007-07bb3-6dbfa1995bc5376ae7106e05d6c525d009b9c3b6.gz
|
|
|
|
| |
darcs-hash:20040419055635-07bb3-6014661f8995a59c900cebf24c03f52b6eed2d21.gz
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the parameters Carpet::prolongate_initial_data; this is now
always done.
Remove arguments initialise_from and do_prolongate from Regrid().
Regridding is now done in level mode instead of meta mode.
Furthermore, CarpetRegrid is called in singlemape mode.
darcs-hash:20040418112943-07bb3-2e392df1737ab75f3f0d553bb53bde2ed41f8773.gz
|
|
|
|
| |
darcs-hash:20040418112556-07bb3-87cca0e1b0860665e56b2a729a06baba55fa5580.gz
|
|
|
|
| |
darcs-hash:20040418110408-07bb3-0a871795414c96c78eb3e5d123044044de61dc91.gz
|
|
|
|
|
|
|
| |
Change the bbox iterators to be cyclic.
Update ASCII output to use the new iterators.
darcs-hash:20040418110344-07bb3-1ea594b79f3031dbc38101d15a65b9aafcf3b005.gz
|
|
|
|
| |
darcs-hash:20040413091349-07bb3-52f2c2f87c5c51b61b6cc2d609d985b1e24a846b.gz
|
|
|
|
| |
darcs-hash:20040413090144-07bb3-585c2620dc244665c9e7a2fb686a87d089948f4e.gz
|
|
|
|
| |
darcs-hash:20040410161022-07bb3-a9fb76984c7cce24ac241d49c37222c78048eed5.gz
|
|
|
|
|
|
|
| |
Abort with an error message if CarpetLib cannot allocate memory for
grid functions. Also track how much memory is already used.
darcs-hash:20040408091635-07bb3-3385e3472c428b3aa562d6ab76f2f6ca32b77f19.gz
|
|
|
|
| |
darcs-hash:20040407150102-07bb3-6d3acc8417e0b0e27427c959fce6d3f8a39cbcd6.gz
|
|
|
|
|
|
|
| |
Insert a check that all gdata arrays are created on all processors.
Expensive, and disabled by default.
darcs-hash:20040407145807-07bb3-7e85aaef2e6f8bac996079f446172e4171c53ab7.gz
|