diff options
author | Erik Schnetter <schnetter@gmail.com> | 2012-06-04 13:34:25 -0400 |
---|---|---|
committer | Erik Schnetter <schnetter@gmail.com> | 2012-06-04 13:34:25 -0400 |
commit | 996a8fe6969ac18be68daad6fd7679ecc73b95bd (patch) | |
tree | 05a5517e76053c862e5917d2f958119013d98720 | |
parent | 7785625df8c374affc2babddd61430003f6f5539 (diff) |
CarpetRegrid2: Add comments
-rw-r--r-- | Carpet/CarpetRegrid2/src/property.cc | 5 | ||||
-rw-r--r-- | Carpet/CarpetRegrid2/src/regrid.cc | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/Carpet/CarpetRegrid2/src/property.cc b/Carpet/CarpetRegrid2/src/property.cc index ed80dfac9..c8ad16905 100644 --- a/Carpet/CarpetRegrid2/src/property.cc +++ b/Carpet/CarpetRegrid2/src/property.cc @@ -798,6 +798,11 @@ namespace CarpetRegrid2 { level_boundary const& bnd, vector<ibset> const& regions, int const rl) { + // TODO: baseextent is the exterior of the domain (i.e. it + // includes the boundary); we need to use the interior of the + // domain here (i.e. baseextent minus the boundary). Such a + // calculation is already performed in the beginning of dh.cc's + // regrid. return regions.at(rl) <= hh.baseextent(0,rl); } diff --git a/Carpet/CarpetRegrid2/src/regrid.cc b/Carpet/CarpetRegrid2/src/regrid.cc index a92e9934b..20493f402 100644 --- a/Carpet/CarpetRegrid2/src/regrid.cc +++ b/Carpet/CarpetRegrid2/src/regrid.cc @@ -343,6 +343,10 @@ namespace CarpetRegrid2 { final_properties.push_back (new in_domain()); final_properties.push_back (new is_symmetric()); + // TODO: Check that the coarse grid contains all finer grids. To + // do this, apply proper_nesting to the coarse grid, and then + // check whether it grew -- if so, this is an error. + regss.resize (regions.size()); |