Fixed some things noticed by perl -w .

Tom


git-svn-id: http://svn.cactuscode.org/flesh/trunk@1102 17b73243-c579-4c4c-a9d2-2d5706c11dac

7 files changed, 12 insertions, 13 deletions

diff --git a/lib/sbin/BuildHeaders.pl b/lib/sbin/BuildHeaders.pl
index 75d6a3b4..701ca3d2 100644
--- a/lib/sbin/BuildHeaders.pl
+++ b/lib/sbin/BuildHeaders.pl
@@ -1,4 +1,4 @@
-#! /usr/bin/perl -s
+ #! /usr/bin/perl -s
 
 #/*@@
 #  @routine BuildHeaders
@@ -23,7 +23,7 @@ sub BuildHeaders
 
   $start_dir = `pwd`;
   chdir $bindings_dir;
-  chdir include;
+  chdir "include";
 
 # First set all data strings 
   foreach $thorn (split(" ",$interface_database{"THORNS"}))
diff --git a/lib/sbin/CST b/lib/sbin/CST
index 863297cf..e88e08ef 100644
--- a/lib/sbin/CST
+++ b/lib/sbin/CST
@@ -6,7 +6,7 @@
 #  @desc 
 #  Parses the the configuration files for thorns.
 #  @enddesc 
-#  @version $Header: /mnt/data2/cvs2svn/cvs-repositories/Cactus/lib/sbin/CST,v 1.32 1999-10-24 22:55:48 goodale Exp $
+#  @version $Header: /mnt/data2/cvs2svn/cvs-repositories/Cactus/lib/sbin/CST,v 1.33 1999-10-25 09:09:26 goodale Exp $
 #@@*/
 
 # Global parameter to track the number of errors from the CST
@@ -279,11 +279,11 @@ sub CreateThornList
 
 sub get_global_parameters
 {
-  my(%parameter_database) = @_;
+  my($rhparameter_db) = @_;
   my(%global_parameters);
   my($param);
 
-  foreach $param (split(/ /,$parameter_database{"GLOBAL PARAMETERS"}))
+  foreach $param (split(/ /,$rhparameter_db->{"GLOBAL PARAMETERS"}))
   {
     if($param =~ m/(.*)::(.*)/)
     {
diff --git a/lib/sbin/CreateImplementationBindings.pl b/lib/sbin/CreateImplementationBindings.pl
index 529de247..c3114300 100644
--- a/lib/sbin/CreateImplementationBindings.pl
+++ b/lib/sbin/CreateImplementationBindings.pl
@@ -61,7 +61,7 @@ sub CreateImplementationBindings
   &WriteFile("make.code.defn",\$dataout);
 
 
-  chdir $_start_dir;
+  chdir $start_dir;
 }
 
 1;
diff --git a/lib/sbin/CreateParameterBindings.pl b/lib/sbin/CreateParameterBindings.pl
index b2d4ce13..9f7e50c0 100644
--- a/lib/sbin/CreateParameterBindings.pl
+++ b/lib/sbin/CreateParameterBindings.pl
@@ -387,7 +387,7 @@ sub NewParamStuff
   my(%routines);
   my($structure, %structures);
   my(%header_files);
-  my($thorn, $block); 
+  my($block); 
   my($filelist);
   my(@creationdata);
   my(@extensiondata);
diff --git a/lib/sbin/ScheduleParser.pl b/lib/sbin/ScheduleParser.pl
index ea10d041..da361ec3 100644
--- a/lib/sbin/ScheduleParser.pl
+++ b/lib/sbin/ScheduleParser.pl
@@ -77,7 +77,7 @@ sub parse_schedule_ccl
   my($name, $type, $description, $where, $language, 
        $mem_groups, $comm_groups, $trigger_groups,
        $before_list, $after_list, $while_list);
-  my($type, $groups);
+  my($groups);
 
   $buffer       = "";
   $n_blocks     = 0;
@@ -158,7 +158,8 @@ sub ParseScheduleBlock
   my(@trigger_groups) = ();
   my($keyword) = "";
   my(@current_sched_list) = ();
-  my($where) = "";
+
+  $where = "";
 
   #Parse the first line of the schedule block
 
diff --git a/lib/sbin/create_c_stuff.pl b/lib/sbin/create_c_stuff.pl
index 771f8d37..d5b4442a 100644
--- a/lib/sbin/create_c_stuff.pl
+++ b/lib/sbin/create_c_stuff.pl
@@ -31,7 +31,6 @@ sub CreateParameterBindingFile
   my($line,@data);
   my(%parameters);
   my($type, $type_string);
-  my(@data);
 
   # Header Data
   $line = "\#include <stdio.h>";
@@ -192,7 +191,6 @@ sub CreateCStructureParameterHeader
   my($line,@data);
   my(%parameters);
   my($type, $type_string);
-  my(@data);
   my(@definition);
 
   # Create the structure
diff --git a/lib/sbin/interface_parser.pl b/lib/sbin/interface_parser.pl
index 4fbebf8d..b68ca32b 100644
--- a/lib/sbin/interface_parser.pl
+++ b/lib/sbin/interface_parser.pl
@@ -609,7 +609,7 @@ sub parse_interface_ccl
       {
 	$message = "Duplicate group $3 in thorn $thorn";
 	&CST_error(0,$message,__LINE__,__FILE__);
-	if($data[line_number+1] =~ m:\{:)
+	if($data[$line_number+1] =~ m:\{:)
 	{
 	    $message = "Skipping interface block";
 	    &CST_error(1,$message,__LINE__,__FILE__);
@@ -688,7 +688,7 @@ sub parse_interface_ccl
 	  $interface_db{"\U$thorn GROUP $current_group\E GTYPE"} .
 	    " for group $current_group of thorn $thorn";
 	  &CST_error(0,$message,__LINE,__FILE__);
-	  if($data[line_number+1] =~ m:\{:)
+	  if($data[$line_number+1] =~ m:\{:)
 	  {
 	      $message = "Skipping interface block in $thorn";
 	      &CST_error(1,$message,__LINE__,__FILE__);