| Commit message (Collapse) | Author | Age |
|---|
| |\
| |
| | |
Fix issue 1113
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently anything except "user@domain" (such as
"User Name <user@domain>"), will not work with the sign command, because
settings.get_account_by_address wants just the "user@domain" bit, and we
don't split it.
Fixes #1113
|
| | |
| |
| |
| |
| | |
These tests exercise issue 1113, which has to do with extracting the
mail correctly from the 'From' header.
|
| | |
| |
| |
| |
| | |
I wrote these looking at a bug, but they turned out not to be helpful
there, but they should be useful all the same.
|
| | |
| |
| |
| |
| |
| | |
Currently it's possible to set sign_by_default without setting a default
key. This is obviously not a good plan for all sorts of reasons. This
fixes the two failing tests from the last commit.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds tests to exercise #1110.
These tests operated on a twisted async method, based on the
inlineCallbacks decorator (which creates a deferred, but looks like
synchronous code). The tests therefore have to use twisted's trial
module for unittest. These seem to operate mostly correctly using the
standard python unittest runner, pass and fail work right, but expected
failure does not. Instead of an expected failure, you get pass.
I really am not impressed with trial. After several hours of mucking
with it I never got it to run any tests, just spit out errors or do
nothing. pytest can run these tests just fine, and if we're going to
change test runner I'll again say that pytest is much nicer to work
with.
|
| |\
| |
| | |
commands/envelope: Fall back to account for signing key
|
| | |
| |
| |
| |
| |
| | |
This new return_default flag (which is an optional and default to
False) will try to return the default account if it cannot find an
account matching the address hint.
|
| | |
| |
| |
| |
| |
| | |
Currently if a signature name has a non-ascii unicode character in it,
the thread will fail to load because a UnicodeEncodeError. This patch
fixes that by converting the str into unicode.
|
| | |
| |
| |
| | |
One of these tests is known to fail, and marked as xfail.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
These are pretty basic, but they do cover most of the conditions, even
if they rely heavily on mocking.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This covers mosts of the functions in the crypto module, but doesn't
bother with the hash_key function, which is slated for deletion in the
port to python-gpg. It also doesn't cover re-raising errors.
|
| |
|
|
|
|
|
|
|
|
| |
gpgme.Context.verify doesn't raise an exception, instead it attaches the
error as an attribute of the return value. This means that we've been
returning that a signature is valid even when it isn't.
This patch checks the attribute instead of try/excepting. Because there
is a second bug (fixed in the next patch) signature verification will
always fail with this patch.
|
| |
|
|
|
|
|
|
| |
This adds a couple of basic tests for the signing and verification of
signatures code in the crypto module. This relies on the utilities
module introduced in the last patch.
One of the tests in here is expected to fail
|
| |
|
|
|
| |
This module currently only contains a class that adds a class level
addCleanup function (called addClassCleanup).
|
| |
|
|
| |
The test file is also renamed.
|
| |
|
|
|
|
|
|
|
|
|
| |
This patch does a bit of refactoring to the Settings class for it's
setup, and adds a reload method. The refactoring encapsulates the
handling of NoneType for the read_*config methods, and reworks the
constructor just a bit so that it doesn't rely on calling methods to
create instance variables.
The end result is slightly cleaner, and will be useful for adding a
reload command to alot itself.
|
| | |
|
| |
|
|
| |
makes pylint happier to run tests, doesn't affect main pytest.
|
| |
|
|
| |
Or it wont be picked up by some test discovery methods.
|
| |
|
|
|
|
|
| |
Instead of manual parsing with regexp and manual string formatting the
functions from email.utils are used. This fixes some small
inconsistencies with addresses with empty realnames and with commas in
realnames.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This fixes a bug in determine_sender where an account that did match but
did not have a realname set was "not found" in case force_realname was
set.
Helped-By: Pol Van Aubel <dev@polvanaubel.com>
|
| |
|
|
| |
The second test case exemplifies a bug in determine_sender.
|
| |
|
|
|
| |
Otherwise the next account in the for loop might have been returned if
the account was found to match with its last alias.
|
| |
|
|
|
| |
This test case exemplifies a bug in determine_sender. The address is
matched correctly but the wrong account is associated with it.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
add some first tests for settings.manager.SettingsManager
|
| | | |
|
| |/
|
|
|
| |
This doesn't cover the actually complex part of the of the module, but
it's a few basic tests.
|
