summaryrefslogtreecommitdiff
path: root/alot
Commit message (Collapse)AuthorAge
* Merge pull request #1222 from mjg/thread-retagpromptPatrick Totzke2018-06-23
|\ | | | | provide retagprompt command in thread mode
| * provide retagprompt command in thread modeMichael J Gruber2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | retagprompt in search mode allows to retag a whole thread. The new thread mode version allows to do the same for each selected message. The common command infers its mode from the UI object that it is passed when applied. Therefore, the docstring (and everything else) is mode-agnostic. When this command command is registered for the wrong mode and applied it raises a KeyError (on purpose).
| * refactor common retagpromptMichael J Gruber2018-06-22
| | | | | | | | | | | | | | | | | | Introduce a new source file common.py for common commands and, as a first example, define RetagPromptCommand there and register it from search.py. This shows how to "decorate" a class that is defined somewhere else, and thus how to decorate it multiple times.
* | add missing importPatrick Totzke2018-06-22
|/ | | | | .. that accidentally got dropped during c86623d9c7daaa2f9a832135a11870a0d91110a3 This fixes #1255
* lazy reading of config files in SettingsManagerPatrick Totzke2018-06-21
| | | | | | | | | This prevents SettingsManager from reading the config files right when it is isntantiated and instead waits for the main module to call `read_[notmuch]config` with the right path. This should prevent problems with accidentally reading the default config paths despite being told otherwise (via commandline options)
* Merge pull request #1228 from dcbaker/auto-encrypt-newPatrick Totzke2018-06-19
|\ | | | | envelope: Update encryption keys when CC, To, or From is changed
| * envelope: Update encryption keys when CC, To, or From is changedDylan Baker2018-03-12
| | | | | | | | | | | | | | | | | | | | | | | | Currently the encryption keys will only be updated when they are toggled, which means that if you change a Cc or To then the keys encrypted to might be wrong, either too many keys will be encrypted to, or not enough, or just the wrong ones. This patches fixes this by calling set_encrypt whenever the 'To', 'Cc', or 'From' headers are changed by set or unset. Fixes #1227
* | remove deprecated future importsPatrick Totzke2018-06-19
| | | | | | | | see also #1250
* | refactor buffersPatrick Totzke2018-06-19
| | | | | | | | | | This splits buffers.py, which contained all buffer classes, into several smaller files. issue #1226
* | Merge branch 'master' into futurePatrick Totzke2018-06-19
|\ \
| * | use importlib to load hooks code at startupPatrick Totzke2018-06-19
| | | | | | | | | | | | imp is deprecated in favor of importlib.
* | | Remove old __future__ importsLucas Hoffmann2018-06-19
|/ / | | | | | | They are not needed for python >= 3.0.
* | fix encoding issue in thread.PrintCommandPatrick Totzke2018-06-18
| | | | | | | | fixes #1244
* | db/utils: remove unused importDylan Baker2018-05-15
| |
* | alot/helper: allow call_cmd to take bytes or strings as stdinDylan Baker2018-05-15
| | | | | | | | | | This might be a little sloppy, but there are legitimate cases where stdin is bytes, and cases where it is a string.
* | commands/thread use a BytesIO instead of StringIO objectDylan Baker2018-05-15
| | | | | | | | because the data is in bytes not strings.
* | alot/db/utils: improve unknown CTE messageDylan Baker2018-05-15
| |
* | Merge branch 'master' into py3kDylan Baker2018-05-15
|\ \
| * | better message on hook loading failureMatthieu Coudron2018-05-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | The typical current message looks like: unable to load hooks file:/home/teto/.config/alot/hooks.py without telling why python couldn't load the hook. This commit prints the exception, thus helping users to solve the issue (in my case encoding + wrong imports).
* | | Add support for binary Content-Transfer-EncodingDylan Baker2018-05-07
| | |
* | | Fix some formatting requests for @luccDylan Baker2018-04-24
| | |
* | | This merges Pazz split of the extract_body functionDylan Baker2018-04-24
|\| | | | | | | | | | | | | | And attempts to fix handling of non text/plain parts by leaving them as bytes until they've been passed to the program that will render them.
| * | refactor db/utils.extract_bodyPatrick Totzke2018-04-24
| |/ | | | | | | | | | | | | This moves out the plaintext rendering of email parts (that are not multipart/* and not text/plain) into a separate utility function render_part. This function looks up and calls the apropriate mailcap handler.
* | db/utils: fix bad merge conflict resolutionDylan Baker2018-04-24
| | | | | | | | oops
* | Merge remote-tracking branch 'bignose/wip/issue/python3-codeclimate' into py3kDylan Baker2018-04-24
|\ \ | | | | | | | | | | | | One small conflict caused by "db/utils: correctly handle 8bit encoded mail"
| * | Extract a level of nested control flow.Ben Finney2018-04-23
| | |
| * | Wrap long statements on open-bracket syntax.Ben Finney2018-04-23
| | |
| * | Raise an exception with a meaningful message.Ben Finney2018-04-23
| | | | | | | | | | | | | | | | | | The `assert` statement is not always executed (it can be optimised away) so is not a suitable run-time check. Also, an exception allows for a better error message.
| * | Extract a level of nested conditionals for tag command.Ben Finney2018-04-23
| | |
* | | db/utils: handle mail with bogus encodingsDylan Baker2018-04-24
| | | | | | | | | | | | | | | I've run into this with misconfigured git-send-email messages, where the encoding is utf-8, but the declared encoding is true or 8bit.
* | | db/utils: correctly handle 8bit encoded mailDylan Baker2018-04-24
|/ /
* | Fix 8bit some moreDylan Baker2018-04-10
| | | | | | | | | | For reasons I don't understand python sometimes converts 8bit to a string properly, and other times it doesn't. This is a bit of a hack.
* | db/utils: correctly handle 8bit encodings.Dylan Baker2018-04-10
| | | | | | | | | | | | Because python's mail will use raw-unicode-escape for anything that isn't ascii we need to encode back into the original raw bytes, then decode into the proper encoding.
* | db/utils: attempt to unwrap Content-Transfer-Encodings manuallyDylan Baker2018-04-10
| | | | | | | | | | | | | | | | The builtin for this assumes that inside of a Content-Transfer-Encoding that the format must be ascii. That is pretty silly, since the reason to use something like base64 is to transfer something that is not ascii, like utf-8. This attempts to handle the base64 and quoted-printable cases manually.
* | helper: add debug for what encoding was guessed.Dylan Baker2018-04-06
| |
* | Merge branch 'py3k-chardet' into py3kDylan Baker2018-04-06
|\ \
| * | require chardetDylan Baker2018-03-06
| | | | | | | | | | | | | | | | | | | | | magic struggles to decode a number of encodings, particularly it struggles with windows-1252, which Exchange *loves* to silently re-encode mail in, without updated the charset of the payload. Chardet successfully guesses these oddball encodings much more often.
| * | db/utils: Update docstring for message_from_bytesDylan Baker2018-03-06
| | |
| * | USe get_payload.decode instead of decoding ourselves.Dylan Baker2018-03-06
| | |
| * | drop bytes support from AddressDylan Baker2018-03-06
| | | | | | | | | | | | | | | | | | We don't want to be comparing bytes anyway, the decode would use utf-8, and that isn't right. Instead make the caller convert to a str of Address first.
| * | utils: Fix types for add_signature_headerDylan Baker2018-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | currently _handle_signatures will pass `False~ for the error_msg if there is no error, but the documentation for add_signature_headers says it only accepts strings. Don't do either of these, instead use None if there is no error, otherwise a string, and updated the assert and documentation to match.
* | | fix saving attachmentsDylan Baker2018-03-14
| | | | | | | | | | | | | | | | | | Attachments are encoded into bytes, but the file we open to write them into was being opened in text mode. That doesn't work. Open the file in bytes mode instead.
* | | Merge branch 'master' into py3kDylan Baker2018-03-12
|\ \ \ | | |/ | |/|
| * | rename parameter of Command.apply methodPatrick Totzke2018-03-11
| | | | | | | | | | | | | | | | | | .. from "caller" to "ui", as used throughout all subclasses. The inconsistent naming causes the codacity code checker (pylint) to complain every time we add a new command subclass.
| * | Merge pull request #1158 from dcbaker/wip/fix-bad-signature-encryptedDylan Baker2018-03-05
| |\ \ | | | | | | | | crypto: Handle message that is encrypted, but the signature is invalid
| | * | crypto: Handle message that is encrypted, but the signature is invalidDylan Baker2017-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One case of this would be not having the public key of the signer. If the verification of the signatures fails, then use the signatures from the error, and try to redecrypt without verification. I have no tests yet, and this probably deserves tests. Fixes #1157
* | | | db/utils: decoded_headers will be passed str not bytesDylan Baker2018-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I had made the assumption early on that this would get bytes, but when I added `assert isinstance(header, bytes)` alot would crash on startup, changing `bytes` to `str` fixed that. I noticed this when trying to fix the warning generated in the logging call.
* | | | db/utils: Update docstring for message_from_bytesDylan Baker2018-03-06
| | | |
* | | | USe get_payload.decode instead of decoding ourselves.Dylan Baker2018-03-06
| | | |
* | | | drop bytes support from AddressDylan Baker2018-03-06
| | | | | | | | | | | | | | | | | | | | | | | | We don't want to be comparing bytes anyway, the decode would use utf-8, and that isn't right. Instead make the caller convert to a str of Address first.