| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| |
|
|
|
|
|
|
| |
This reverts commit d01d2e51da45dd87f0abf98b8a856f3b3de69153.
I don't think that this patch really improved readability that much. The
right solution is to split ComposeCommand.apply so we don't need so many
mocks.
|
| |\
| |
| |
| |
| | |
And attempts to fix handling of non text/plain parts by leaving them as
bytes until they've been passed to the program that will render them.
|
| | |\
| | |
| | | |
refactor extract_body
|
| | |/
| |
| |
| |
| |
| |
| | |
This moves out the plaintext rendering of email parts (that are
not multipart/* and not text/plain) into a separate utility function
render_part. This function looks up and calls the apropriate mailcap
handler.
|
| | |
| |
| |
| | |
oops
|
| |\ \
| | |
| | |
| | |
| | | |
One small conflict caused by "db/utils: correctly handle 8bit encoded
mail"
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The `assert` statement is not always executed (it can be optimised
away) so is not a suitable run-time check. Also, an exception allows
for a better error message.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This allows writing less-nested statements.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
I've run into this with misconfigured git-send-email messages, where the
encoding is utf-8, but the declared encoding is true or 8bit.
|
| |/ / |
|
| | |
| |
| |
| |
| | |
For reasons I don't understand python sometimes converts 8bit to a
string properly, and other times it doesn't. This is a bit of a hack.
|
| | |
| |
| |
| |
| |
| | |
Because python's mail will use raw-unicode-escape for anything that
isn't ascii we need to encode back into the original raw bytes, then
decode into the proper encoding.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
The builtin for this assumes that inside of a Content-Transfer-Encoding
that the format must be ascii. That is pretty silly, since the reason to
use something like base64 is to transfer something that is not ascii,
like utf-8. This attempts to handle the base64 and quoted-printable
cases manually.
|
| | | |
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
magic struggles to decode a number of encodings, particularly it
struggles with windows-1252, which Exchange *loves* to silently
re-encode mail in, without updated the charset of the payload. Chardet
successfully guesses these oddball encodings much more often.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
We don't want to be comparing bytes anyway, the decode would use utf-8,
and that isn't right. Instead make the caller convert to a str of
Address first.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
currently _handle_signatures will pass `False~ for the error_msg if
there is no error, but the documentation for add_signature_headers says
it only accepts strings.
Don't do either of these, instead use None if there is no error,
otherwise a string, and updated the assert and documentation to match.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Attachments are encoded into bytes, but the file we open to write them
into was being opened in text mode. That doesn't work. Open the file in
bytes mode instead.
|
| |\ \ \
| | |/
| |/| |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
.. from "caller" to "ui", as used throughout all subclasses.
The inconsistent naming causes the codacity code checker (pylint) to
complain every time we add a new command subclass.
|
| | |\ \
| | | |
| | | | |
crypto: Handle message that is encrypted, but the signature is invalid
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
One case of this would be not having the public key of the signer. If
the verification of the signatures fails, then use the signatures from
the error, and try to redecrypt without verification.
I have no tests yet, and this probably deserves tests.
Fixes #1157
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I had made the assumption early on that this would get bytes, but when I
added `assert isinstance(header, bytes)` alot would crash on startup,
changing `bytes` to `str` fixed that. I noticed this when trying to fix
the warning generated in the logging call.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't want to be comparing bytes anyway, the decode would use utf-8,
and that isn't right. Instead make the caller convert to a str of
Address first.
|
| | |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
currently _handle_signatures will pass `False~ for the error_msg if
there is no error, but the documentation for add_signature_headers says
it only accepts strings.
Don't do either of these, instead use None if there is no error,
otherwise a string, and updated the assert and documentation to match.
|
| | | |
| | |
| | |
| | |
| | | |
Commands running in a subprocess should return the terminal encoding so
we don't need to guess their encoding.
|
| | | |
| | |
| | |
| | | |
basically just remove hand rolling what try_decode does.
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
This requires regenerating the accounts_table docs, as they've changed
for python 3.
|
| | |\ \
| | | |
| | | | |
Tag replied passed
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
maildir knows R and P flags which denote messages that have been replied
to resp. passed on (fowarded, bounced). They correspond to IMAP flags
\Replied and $Forwarded which are used by many clients and by
synchronisation software. E.g., mbsync syncs \Replied to R, a patch for
P is pending.
Implement replied_tags and passed_tags for alot which work similar to
sent_tags: sent_tags tags the sent message; replied_tags (resp.
passed_tags) tags the message being replied to (resp. being fowarded).
Basically, setting the replied_tags config to `replied` and replying to
a message has the same effect as doing `tag replied; reply`, but the
latter would tag even sending the reply is aborted or fails. The
implementation in this patch makes sure that the tagging is done only if
and when the reply resp. forward has been sent successfully.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
draft_tags works the same way as sent_tags, so provide the same defaults
and doc.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
force_list() converts single items to lists already. Thus, remove a
superfluous list() that could be mistaken for converting a single string
into a list of chars.
|
| |\| | | |
|
| | |\ \ \
| | | | |
| | | | | |
CompleteEdit: go up when the up key is pressed
|
