summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
| * Don't pass None as second argument of dict.get()Dylan Baker2016-12-13
| | | | | | | | This is the default value.
| * Don't materialize with any()Dylan Baker2016-12-13
| | | | | | | | | | It's more efficient to use a generator here than a list comprehension, since then we can avoid calculating addresses we don't need.
| * Use tuple for isinstance instead of multiple calls to isinstanceDylan Baker2016-12-13
| |
| * Replace list comprehension with set comprehensionDylan Baker2016-12-13
| | | | | | | | | | | | | | Instead of using set([l for l in list]) use {l for l in list} (which shouldn't be confused with a dict comprehension which requires the ':' in the first value}. This avoids creating a list before reducing it to a set. This feature is new in 2.7 and 3.3.
| * Replace mutable keyword argumentsDylan Baker2016-12-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a number of cases of mutable keyword arguments (list and dict in this case). Mutable keyword arguments are rather dangerous, since any mutation of the default value is persistent, which will inevitably lead to bugs. For example, imagine this code: def func(def=[]): def.append('foo') return def >>> func() ['foo'] >>> func() ['foo', 'foo'] This is almost certainly not what was intended. This code generally uses the idiom of setting the default value to None, and then assigning with or `value = value or []` which will replace value with the empty list (or dict) when value is falsey, like None or another empty list.
| * settings/manager.py: Compare addresses using == instead of inDylan Baker2016-12-13
|/ | | | | | | I don't think this was correct from the start, since "foo@bar.com" would match "bfoo@bar.com", even if there was a "bfoo@bar.com" in the accountmap, depending on the order that they happened to be sorted in accountmap.
* Merge pull request #916 from lucc/mini-travisLucas Hoffmann2016-12-13
|\ | | | | Start using travis.ci to check auto generated docs
| * Start using travis.ci to check auto generated docsLucas Hoffmann2016-12-11
|/ | | | | | | | | For starters only the auto generated part of the docs is regenerated in order to check that the last author did regenerate and commit them. Some dependencies of alot are mocked to speed up installation. Especially notmuch would need to be build manually as the version available on travis is to old.
* Merge pull request #914 from lucc/docs2Patrick Totzke2016-12-11
|\ | | | | Some more fixes for building docs
| * Update autogenerated documentation filesLucas Hoffmann2016-12-11
| |
| * Remove trailing whitespace from inline docsLucas Hoffmann2016-12-11
| | | | | | | | It would otherwise be picked up by the autogenerated docs.
| * Remove trainling whitespace when autogenerating docsLucas Hoffmann2016-12-11
| |
| * Add target to delete generated doc filesLucas Hoffmann2016-12-11
| | | | | | | | | | | | When checking out files from git the timestamps might not give enough information to make which files to remake. So this new target can be used to force a remake of all generated files on the next run.
| * Fix path in docs generating scriptsLucas Hoffmann2016-12-11
| | | | | | | | | | | | | | | | | | The path to the present development version of alot should be prepended to sys.path in order to shadow other versions of alot installed on the system. Also it should be a directory from which the alot module is loadable. That is the root of the git repository and not one level above this. This was overlooked in #912.
| * Remove :option: marker from pip option in docsLucas Hoffmann2016-12-11
|/ | | | | `sphinx-build -W` was complaining as this is not a option of alot and can not be found in our documentation.
* Merge pull request #913 from lucc/trailing-white-spaceLucas Hoffmann2016-12-11
|\ | | | | Remove trailing white space
| * Remove trailing white spaceLucas Hoffmann2016-12-11
|/
* Merge pull request #912 from lucc/docsLucas Hoffmann2016-12-11
|\ | | | | Fix building of docs to ease development
| * Use some more variables in makefileLucas Hoffmann2016-12-10
| | | | | | | | | | | | | | | | | | | | | | | | | | On Arch Linux python points to python3 and hence the makefile fails. With this change users can tell the makefile which python executable to use: make PYTHON=/some/version2/python ... or simply make PYTHON=python2 ... For sake of completeness the same is done for rm.
| * Fix NoneType error in docs scriptLucas Hoffmann2016-12-10
|/
* Merge pull request #911 from zenhack/addressbook-doc-fixPatrick Totzke2016-12-10
|\ | | | | docs: fix incorrect module/class names
| * docs: fix incorrect module/class namesIan Denhardt2016-12-10
|/ | | | | | | | api/settings.rst previously erroneously pluralized alot.addressbook, named one class that does not exist, named one from a sub module, and omitted two sub modules (with classes). This was causing build errors from sphinx
* Merge pull request #883 from lucc/minorLucas Hoffmann2016-12-09
|\ | | | | Some minor style fixes/improvements
| * Further minor style fixesLucas Hoffmann2016-12-09
| |
| * Fix except syntaxLucas Hoffmann2016-12-09
| |
| * Clean up importsLucas Hoffmann2016-12-09
| | | | | | | | | | | | - use relative imports if possible - group imports into standard library, third party, and alot modules - sort imports alphabetically
| * Use logging's native string interpolationLucas Hoffmann2016-12-09
| |
| * Remove braces after `del` and `return`Lucas Hoffmann2016-12-09
|/ | | | | `del` and `return` are keywords and not functions so the braces are not needed.
* version bumpPatrick Totzke2016-12-09
|
* bump version numberPatrick Totzke2016-12-09
|
* update newsPatrick Totzke2016-12-06
|
* New option `thread_authors_order_by` to control author orderTommy Lindgren2016-12-06
| | | | | | | | | | | | | Default value 'first_message' lists authors in the order they joined the conversation. Value 'latest_message' order authors by their latest message, which makes it easier to see which authors who wrote the most recent messages. Note that authors with duplicate emails were previously filtered. We now keep all authors where name + email is unique. This is behavior is desired for some email notification services. For example, Jira will set the From header to "Joe User <jira@company.com>" meaning you will only see one author if you only keep unique email addresses.
* Merge pull request #752 from jkoelker/pipeto_field_keyPatrick Totzke2016-12-06
|\ | | | | Allow specifing the mailcap field key for `pipeto`
| * Allow specifing the mailcap field key for `pipeto`Jason Kölker2015-02-11
| | | | | | | | | | When decoding the message, use the mailcap field specified for command lookup.
* | Merge pull request #901 from xunam/fix-backslash-tPatrick Totzke2016-12-06
|\ \ | | | | | | Removed incorrect backslash-t substitution in envelope.
| * | Removed incorrect backslash-t substitution in envelope.Emmanuel Beffara2016-10-20
| | |
* | | Merge pull request #856 from meskio/multipart_signature_missingPatrick Totzke2016-12-06
|\ \ \ | | | | | | | | Get the signature payload only if it exist
| * | | Get the signature payload only if it existRuben Pollan2016-03-24
| | | |
* | | | Merge pull request #909 from pazz/autofix/wrapped2_to3_fixPatrick Totzke2016-12-06
|\ \ \ \ | | | | | | | | | | Fix "Use `is` or `is not` to compare with `None`" issue
| * | | | Use `is` operator for comparing with `None` (Pep8)Cody2016-12-06
|/ / / /
* | | | update newsPatrick Totzke2016-12-06
| | | |
* | | | Merge branch '0.3.8-SIGINT-903'Patrick Totzke2016-12-06
|\ \ \ \
| * | | | ui: Only update via SIGINT1 when in search bufferDimitrios Semitsoglou-Tsiapos2016-11-13
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Refreshing non-search buffers (eg the thread view) can have undesired effects. This defensively only refreshes when the search buffer is visible. (fixes #871) Signed-off-by: Dimitrios Semitsoglou-Tsiapos <kmhzsem@gmx.com>
* | | | Merge branch '0.3.8-editnew_bug-819'Patrick Totzke2016-12-06
|\ \ \ \
| * | | | Use the first account if no address matches in ComposeCommandRuben Pollan2016-09-03
| | | | |
* | | | | Merge branch '0.3.8-reply_account_header_priority'Patrick Totzke2016-12-06
|\ \ \ \ \
| * | | | | Rename to adhere to config option naming scheme.Pol Van Aubel2016-12-06
| | | | | |
| * | | | | Make header list configurable.Pol Van Aubel2016-12-06
| | | | | |
| * | | | | Introduce header-based preference in sender selectPol Van Aubel2016-12-06
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce a header-based preference in sender selection, as proposed in #771. In the examples below, assume the accounts are ordered X-Y-Z in the config file. Suppose I'm in a conversation, sending mails from account Y. However, I add my account X to the "CC:" header. If I do not receive any replies before sending another mail, I want to send it from account Y again, 9 out of 10 times. The old version would prefer account X, because it lumps all headers in one list and gets a match on account X first. Suppose I have aliasing in my mailserver, but send mails from several of these aliases. They are not "aliases" as such, but accounts which happen to share a mailbox. However, account X is the account where the mail is ultimately sent to so will always be present in the "Delivered-To:" header, even if the sender only knows my address for account Y, which is in the "To:". Obviously, I want any replies to be sent from account Y, not account X. This is fixed by prioritizing matches on the "To:" over "Delivered-To:". The only case which this patch doesn't fix is when somebody replies in the first situation, adding *both* addresses to the "To:" header. In this case, however, I would be fine manually editing the proposed sender address.
* | | | | Merge branch '0.3.8-feature-untrusted-signatures-858'Patrick Totzke2016-12-06
|\ \ \ \ \