summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* docs: mention 'content' part in threadline themingPatrick Totzke2017-08-04
| | | | | ... which displays a prefix of the msg contents. This feature was missing in the docs.
* Merge pull request #1097 from lucc/scriptsLucas Hoffmann2017-08-02
|\ | | | | Clean up doc source generators
| * Clean up doc source generatorsLucas Hoffmann2017-07-31
| |
* | Merge pull request #1096 from dcbaker/submit/gpg-no-bccPatrick Totzke2017-07-31
|\ \ | | | | | | command/envelope: Prompt before sending an encrypted message with Bcc
| * | command/envelope: Prompt before sending an encrypted message with BccDylan Baker2017-07-27
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently alot cannot encrypt to Bcc recipients, and it isn't obvious how to implement encrypted BCC without a metadata leak (the key ids of the Bcc recpients would be visible to the to and cc recipients as well as the other bcc recipients). As such it hasn't been implemented yet (although #949) is opened for such encryption. In the mean time alot doesn't encrypt to bcc recipients at all, making the message all but useless (it might be useful to send it to yourself as a blind recipient, or to two email addresses of the same person). Since most people don't know that alot has this limitation, we should really warn them. This adds a prompt before constructing the message for that case.
* | Merge pull request #1093 from dcbaker/submit/update-docsPatrick Totzke2017-07-31
|\ \ | |/ |/| Submit/update docs
| * docs: Note that system paths can contain themesDylan Baker2017-07-27
| | | | | | | | Since the original patch that added the support didn't.
| * update NEWS file with other changes since 0.5.0Dylan Baker2017-07-27
| |
* | Merge pull request #1089 from dcbaker/submit/sign-without-hintDylan Baker2017-07-27
|\ \ | |/ |/| commands/envelope: Fall back to account for signing key
| * settings/manager: Extend the get_account_by_address with return_defaultDylan Baker2017-07-27
| | | | | | | | | | | | This new return_default flag (which is an optional and default to False) will try to return the default account if it cannot find an account matching the address hint.
| * commands/envelope: Fall back to account for signing keyDylan Baker2017-07-19
| | | | | | | | | | | | | | If there isn't a key provided as an argument to sign or togglesign, fall back to using the account of the sending address to determine the key, otherwise the message will be marked as "to sign", but won't actually be signed. This is the same type of logic used for sign_by_default.
* | Merge pull request #1083 from dcbaker/submit/add_signature-unicodeDylan Baker2017-07-26
|\ \ | | | | | | db/utils: Support unicode in signatures
| * | db/utils: Improve readabilityDylan Baker2017-07-24
| | | | | | | | | | | | | | | Nested ternaries are awful to read, especially in this case. Putting it into an if statement is actually more terse, and is much easier to read.
| * | db/utils: optimize if statementsDylan Baker2017-07-24
| | | | | | | | | | | | | | | | | | 1) dont use len() to test that a list is non-empty 2) only go down the else clause if it's possible to have a valid signature.
| * | db/utils: Support unicode in signaturesDylan Baker2017-07-24
| | | | | | | | | | | | | | | | | | Currently if a signature name has a non-ascii unicode character in it, the thread will fail to load because a UnicodeEncodeError. This patch fixes that by converting the str into unicode.
| * | tests/db/utils: Add tests for unicode as uidsDylan Baker2017-07-24
| | | | | | | | | | | | One of these tests is known to fail, and marked as xfail.
| * | tests/db/utils: share some mock biolerplateDylan Baker2017-07-24
| | |
| * | tests/utilities: Allow uid to be passed to make_uidDylan Baker2017-07-24
| | |
| * | tests/utilities: have make_key rely on make_uidDylan Baker2017-07-24
| | |
| * | tests: move shared helpers out of crypto module into common moduleDylan Baker2017-07-24
| | |
| * | tests: Add some basic tests for alot.db.utils.add_signature_headerDylan Baker2017-07-24
|/ / | | | | | | | | These are pretty basic, but they do cover most of the conditions, even if they rely heavily on mocking.
* | Merge pull request #1085 from dcbaker/submit/system-theme-locationsDylan Baker2017-07-19
|\ \ | |/ |/| settings: Allow loading themes from system locations
| * settings: Allow loading themes from system locationsDylan Baker2017-07-19
| | | | | | | | | | | | | | | | | | | | | | | | | | This adds additional system locations to search for theme files, which are either defined as the environment variable XDG_DATA_DIRS, or the generic fallback (per the xdg base directories spec) as /usr/local/share and /usr/share. We then add alot/themees to those paths to search for themes in. This allows a package manager to install the theme files system wide along with alot, and for alot to load them from the system wide directories. The Archlinux alot-git package is already installing the packages like this.
* | Merge pull request #1088 from dcbaker/submit/gpg-signed-no-newlineDylan Baker2017-07-18
|\ \ | | | | | | helper: Do not add a newline to the end of a signed section
| * | helper: Do not add a newline to the end of a signed sectionDylan Baker2017-07-17
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec is very clear here: (2) An appropriate Content-Transfer-Encoding is then applied; see section 3. In particular, line endings in the encoded data MUST use the canonical <CR><LF> sequence where appropriate (note that the canonical line ending may or may not be present on the last line of encoded data and MUST NOT be included in the signature if absent). That very last MUST NOT is what's important here, we shouldn't be adding newlines if they weren't there to begin with. Because we do it causes signed blobs that have newlines to be invalid since we've changed the substance of the signed code.
* | Merge pull request #1075 from lucc/test/miscDylan Baker2017-07-17
|\ \ | | | | | | Some misc tests
| * | Tests for alot.settings.theme.Theme.get_attributeLucas Hoffmann2017-07-17
| | |
| * | Exclude two methods from coverage reportLucas Hoffmann2017-07-17
| | | | | | | | | | | | | | | | | | | | | One is an abstract method anyways and the other one is trivial. It just calls two other functions that are already covered by tests. This results in 100% test coverage for alot/addressbook/*.
| * | Add another test for ExternalAddressbookLucas Hoffmann2017-07-17
| | |
| * | Test alot.settings.utils.resolve_attLucas Hoffmann2017-07-17
| |/
* | Merge pull request #1084 from sivamahadevan/patch-1Dylan Baker2017-07-17
|\ \ | |/ |/| Fix solarized light colorscheme name
| * Rename solarized to solarized_lightSiva Mahadevan2017-07-17
| |
| * Fix solarized light colorscheme nameSiva Mahadevan2017-07-16
|/
* Merge pull request #1081 from dcbaker/submit/crypto-testsDylan Baker2017-07-16
|\ | | | | Add crypto module tests
| * crypto: Fix list_keys docstringDylan Baker2017-07-15
| | | | | | | | | | | | | | | | | | There are currently several problems with this docstring: 1) it says the return type is list, but it's actually an iterator 2) it says the first parameter is keyid, but it's hint 3) no types are specified. This patch corrects that.
| * crypto: Make strings more readableDylan Baker2017-07-15
| | | | | | | | | | | | | | | | | | | | This is a just a small refactor that makes things a little more readable, and provides slightly more verbose messages in for signing and encrypting failures. Mainly this uses str.format instead of inline concatenation, but it also rewraps and removes '+' operators from a string already wrapped in parens
| * tests/crypto: Add tests for the crypto moduleDylan Baker2017-07-15
|/ | | | | | This covers mosts of the functions in the crypto module, but doesn't bother with the hash_key function, which is slated for deletion in the port to python-gpg. It also doesn't cover re-raising errors.
* Merge pull request #1078 from dcbaker/wip/fix-error-handling-of-signedDylan Baker2017-07-12
|\ | | | | crypto: Fix handling of signed messages
| * utils: Fix verifying signaturesDylan Baker2017-07-11
| | | | | | | | | | | | | | | | | | To verify the signature correctly we need to ensure that the body of the message is decoded the same way as it was when it was signed, specifically using helper.email_as_string to insert \r\n instead of .as_string, which only inserts \n. Fixes #1079
| * crypto: Fix error handling of signed messagesDylan Baker2017-07-11
| | | | | | | | | | | | | | | | | | | | gpgme.Context.verify doesn't raise an exception, instead it attaches the error as an attribute of the return value. This means that we've been returning that a signature is valid even when it isn't. This patch checks the attribute instead of try/excepting. Because there is a second bug (fixed in the next patch) signature verification will always fail with this patch.
| * tests: Add tests for signing functions.Dylan Baker2017-07-11
| | | | | | | | | | | | | | | | This adds a couple of basic tests for the signing and verification of signatures code in the crypto module. This relies on the utilities module introduced in the last patch. One of the tests in here is expected to fail
| * tests: Add a module with some extra utility helpersDylan Baker2017-07-11
|/ | | | | This module currently only contains a class that adds a class level addCleanup function (called addClassCleanup).
* Merge pull request #1072 from lucc/feature/envelope-tagDylan Baker2017-07-11
|\ | | | | Implement :tag commands in envelope buffer
| * Copy tags to envelope with :editnewLucas Hoffmann2017-07-11
| |
| * Update NEWSLucas Hoffmann2017-07-11
| |
| * Also save envelope tags with :saveLucas Hoffmann2017-07-11
| |
| * Display tags in envelope bufferLucas Hoffmann2017-07-11
| |
| * Add completion to new tag commandsLucas Hoffmann2017-07-11
| |
| * Add tests for new commandsLucas Hoffmann2017-07-11
| | | | | | | | The test file is also renamed.
| * Update documentation for :tag commands in envelope buffersLucas Hoffmann2017-07-11
| |