* redo min_ipar() and max_ipar() functions in ghost_zone::

  --> now these are virtual and take iperp as an argument
      (ignored for  symmetry_ghost_zone)
  --> new functions  extreme_min_ipar()  and  extreme_max_ipar()
      to give the extreme range (may even be a bit conservative),
      i.e. the range including all of the corners
* fix a bug in   patch_interp::molecule_minmax_ipar_m()
  where we mistakenly returned the min ipar m for both the min and max
  returns :(

* finish modifying the   src/util/test_patch_system.cc   test driver
  to test the Jacobian computation


git-svn-id: http://svn.einsteintoolkit.org/cactus/EinsteinAnalysis/AHFinderDirect/trunk@603 f88db872-0e4f-0410-b76b-b9085cfa78c5

1 files changed, 5 insertions, 6 deletions

diff --git a/src/patch/test_patch_system.cc b/src/patch/test_patch_system.cc
index 5143f26..6371305 100644
--- a/src/patch/test_patch_system.cc
+++ b/src/patch/test_patch_system.cc
@@ -201,14 +201,14 @@ else if (STRING_EQUAL(which_test, "synchronize"))
 
 else if (STRING_EQUAL(which_test, "synchronize Jacobian"))
    then test_synchronize_Jacobians(ps,
-				   test_fn_copy_gfn, test_fn_gfn,
+				   test_fn_gfn, test_fn_copy_gfn,
 				   NP_Jacobian__perturbation_amplitude,
 				   Jacobian_file_name);
 
 else if (STRING_EQUAL(which_test, "derivatives"))
    then {
 	setup_fn_rho_sigma(ps, test_fn_gfn);
-	ps.print_gridfn(test_fn_gfn, "test_fn.dat");
+	ps.print_ghosted_gridfn(test_fn_gfn, "test_fn.dat");
 	finite_diff(ps, test_fn_gfn, FD_derivs_gfn, which_derivs);
 	ps.print_gridfn(FD_derivs_gfn, "FD_derivs.dat");
 	analytic_derivs(ps, analytic_derivs_gfn, which_derivs);
@@ -275,7 +275,7 @@ void test_synchronize_Jacobians(patch_system& ps,
 {
 setup_sym_fn_xyz(ps, test_gfn, false);
 ps.synchronize_ghost_zones(test_fn_gfn, test_fn_gfn);
-ps.print_ghosted_gridfn(test_fn_copy_gfn, "test_fn_copy.dat");
+ps.print_ghosted_gridfn(test_fn_gfn, "test_fn.dat");
 
 setup_sym_fn_xyz(ps, NP_test_gfn, false);
 
@@ -326,9 +326,8 @@ fprintf(fileptr, "# column 17 = Jacobian error\n");
 	     x_iperp <= pgz.max_iperp() ;
 	     ++x_iperp)
 	{
-	// FIXME FIXME -- this includes corners when it shouldn't
-	for (int x_ipar = pgz.ghost_zone_min_ipar() ;
-	     x_ipar <= pgz.ghost_zone_max_ipar() ;
+	for (int x_ipar = pgz.min_ipar(x_iperp) ;
+	     x_ipar <= pgz.max_ipar(x_iperp) ;
 	     ++x_ipar)
 	{
 	const int x_irho   = pe.  irho_of_iperp_ipar(x_iperp, x_ipar);