From 8a24fbbdaea4f3ff9bdcdf76036bedca6e335bce Mon Sep 17 00:00:00 2001 From: Wilba Date: Wed, 10 Aug 2022 13:01:09 +1000 Subject: Fix detection of EEPROM reset in some keyboards (#17970) --- keyboards/cannonkeys/satisfaction75/satisfaction75.c | 6 +++--- keyboards/mxss/mxss_frontled.c | 6 +++--- keyboards/wilba_tech/wt70_jb/wt70_jb.c | 6 +++--- keyboards/wilba_tech/wt_main.c | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/keyboards/cannonkeys/satisfaction75/satisfaction75.c b/keyboards/cannonkeys/satisfaction75/satisfaction75.c index bd7eaf1885..443a4d0d8a 100644 --- a/keyboards/cannonkeys/satisfaction75/satisfaction75.c +++ b/keyboards/cannonkeys/satisfaction75/satisfaction75.c @@ -348,9 +348,9 @@ void custom_config_load(){ // Called from matrix_init_kb() if not VIA_ENABLE void via_init_kb(void) { - // If the EEPROM has the magic, the data is good. - // OK to load from EEPROM. - if (via_eeprom_is_valid()) { + // This checks both an EEPROM reset (from bootmagic lite, keycodes) + // and also firmware build date (from via_eeprom_is_valid()) + if (eeconfig_is_enabled()) { custom_config_load(); } else { #ifdef DYNAMIC_KEYMAP_ENABLE diff --git a/keyboards/mxss/mxss_frontled.c b/keyboards/mxss/mxss_frontled.c index f5e4613dfb..8bb93d5fd8 100644 --- a/keyboards/mxss/mxss_frontled.c +++ b/keyboards/mxss/mxss_frontled.c @@ -39,9 +39,9 @@ __attribute__ ((weak)) size_t lc_size = sizeof(layer_colors) / sizeof(hs_set); void fled_init(void) { - // If EEPROM config exists, load it - // If VIA EEPROM exists, FLED config should too - if (via_eeprom_is_valid()) { + // This checks both an EEPROM reset (from bootmagic lite, keycodes) + // and also firmware build date (from via_eeprom_is_valid()) + if (eeconfig_is_enabled()) { fled_load_conf(); // Else, default config } else { diff --git a/keyboards/wilba_tech/wt70_jb/wt70_jb.c b/keyboards/wilba_tech/wt70_jb/wt70_jb.c index 0bb9aca092..d4f2c5c8da 100644 --- a/keyboards/wilba_tech/wt70_jb/wt70_jb.c +++ b/keyboards/wilba_tech/wt70_jb/wt70_jb.c @@ -38,9 +38,9 @@ bool led_update_kb(led_t led_state) { // Called from matrix_init_kb() if not VIA_ENABLE void via_init_kb(void) { - // If the EEPROM has the magic, the data is good. - // OK to load from EEPROM - if (via_eeprom_is_valid()) { + // This checks both an EEPROM reset (from bootmagic lite, keycodes) + // and also firmware build date (from via_eeprom_is_valid()) + if (eeconfig_is_enabled()) { } else { // Cache "first execution" state so we can do something // specific after QMK initialization has done its thing. diff --git a/keyboards/wilba_tech/wt_main.c b/keyboards/wilba_tech/wt_main.c index a8ad795446..a7afeb5907 100644 --- a/keyboards/wilba_tech/wt_main.c +++ b/keyboards/wilba_tech/wt_main.c @@ -35,9 +35,9 @@ // Called from matrix_init_kb() if not VIA_ENABLE void via_init_kb(void) { - // If the EEPROM has the magic, the data is good. - // OK to load from EEPROM - if (via_eeprom_is_valid()) { + // This checks both an EEPROM reset (from bootmagic lite, keycodes) + // and also firmware build date (from via_eeprom_is_valid()) + if (eeconfig_is_enabled()) { #if RGB_BACKLIGHT_ENABLED || MONO_BACKLIGHT_ENABLED backlight_config_load(); #endif // RGB_BACKLIGHT_ENABLED || MONO_BACKLIGHT_ENABLED -- cgit v1.2.3