From a68302e50b835146cdb526a5850b9b19cb36a0ad Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 7 Jan 2013 10:32:01 +0100 Subject: thread/Mutex: don't use std::mutex Use a custom pthread_mutex_t wrapper because std::mutex adds overhead. --- src/thread/Mutex.hxx | 16 ++++++------- src/thread/PosixMutex.hxx | 60 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 8 deletions(-) create mode 100644 src/thread/PosixMutex.hxx (limited to 'src/thread') diff --git a/src/thread/Mutex.hxx b/src/thread/Mutex.hxx index df8d140c..675af74b 100644 --- a/src/thread/Mutex.hxx +++ b/src/thread/Mutex.hxx @@ -27,6 +27,14 @@ #include "CriticalSection.hxx" typedef CriticalSection Mutex; +#else + +#include "PosixMutex.hxx" + +typedef PosixMutex Mutex; + +#endif + class ScopeLock { Mutex &mutex; @@ -43,12 +51,4 @@ public: ScopeLock &operator=(const ScopeLock &other) = delete; }; -#else - -#include -typedef std::mutex Mutex; -typedef std::lock_guard ScopeLock; - -#endif - #endif diff --git a/src/thread/PosixMutex.hxx b/src/thread/PosixMutex.hxx new file mode 100644 index 00000000..1862a3e2 --- /dev/null +++ b/src/thread/PosixMutex.hxx @@ -0,0 +1,60 @@ +/* + * Copyright (C) 2009-2013 Max Kellermann + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * - Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * + * - Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the + * distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * FOUNDATION OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, + * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED + * OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef MPD_THREAD_POSIX_MUTEX_HXX +#define MPD_THREAD_POSIX_MUTEX_HXX + +#include + +/** + * Low-level wrapper for a pthread_mutex_t. + */ +class PosixMutex { + pthread_mutex_t mutex; + +public: + constexpr PosixMutex():mutex(PTHREAD_MUTEX_INITIALIZER) {} + + PosixMutex(const PosixMutex &other) = delete; + PosixMutex &operator=(const PosixMutex &other) = delete; + + void lock() { + pthread_mutex_lock(&mutex); + } + + bool try_lock() { + return pthread_mutex_trylock(&mutex) == 0; + } + + void unlock() { + pthread_mutex_unlock(&mutex); + } +}; + +#endif -- cgit v1.2.3