From d4f3c09081179cbe2b55a52549318949c5ede9e5 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 22 Oct 2008 21:41:49 +0200 Subject: command: converted COMMAND_RETURN_* macros to enum Also add names for "error" and "ok". I don't like passing anonymous integer codes around. This is not yet complete: lots of functions (e.g. in playlist.c) follow the same convention of -1/0, and these have to be adapted, too. --- src/command.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/command.h') diff --git a/src/command.h b/src/command.h index bae804d3..441b1685 100644 --- a/src/command.h +++ b/src/command.h @@ -23,9 +23,12 @@ #include "sllist.h" #include "ack.h" -#define COMMAND_RETURN_KILL 10 -#define COMMAND_RETURN_CLOSE 20 -#define COMMAND_MASTER_READY 30 +enum command_return { + COMMAND_RETURN_ERROR = -1, + COMMAND_RETURN_OK = 0, + COMMAND_RETURN_KILL = 10, + COMMAND_RETURN_CLOSE = 20, +}; struct client; @@ -33,11 +36,11 @@ void command_init(void); void command_finish(void); -int +enum command_return command_process_list(struct client *client, int list_ok, struct strnode *list); -int +enum command_return command_process(struct client *client, char *commandString); void command_success(struct client *client); -- cgit v1.2.3