From 8ef87be4829a260893ababa1ff943a8cf1afa0b2 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 8 Jan 2013 16:33:33 +0100 Subject: Queue: use signed integer instead of G_MAXUINT The check for unsigned underflow is fragile and unreliable. --- src/Queue.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/Queue.cxx') diff --git a/src/Queue.cxx b/src/Queue.cxx index 34f89126..0c2a8fc9 100644 --- a/src/Queue.cxx +++ b/src/Queue.cxx @@ -181,7 +181,7 @@ queue::MoveRange(unsigned start, unsigned end, unsigned to) // If to < start, we need to move start-to items to newend (= end + to - start), starting from to // This is the same as moving items from start-1 to to (decreasing), with start-1 going to end-1 // We have to iterate in this order to avoid writing over something we haven't yet moved - for (unsigned i = start - 1; i >= to && i != G_MAXUINT; i--) + for (int i = start - 1; i >= int(to); i--) MoveItemTo(i, i + end - start); // Copy the original block back in, starting at to. -- cgit v1.2.3