From 7e92820c501eef548ddcc64b345dfdbf82f708ad Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 4 Feb 2013 11:46:49 +0100 Subject: output/alsa: default "device" is an empty string Fixes nullptr dereference in std::string::operator=(). Also fixes a memory leak by using config_get_block_string() instead of config_dup_block_string(). --- src/output/AlsaOutputPlugin.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/output/AlsaOutputPlugin.cxx b/src/output/AlsaOutputPlugin.cxx index 4d9f259a..b4c8d938 100644 --- a/src/output/AlsaOutputPlugin.cxx +++ b/src/output/AlsaOutputPlugin.cxx @@ -137,7 +137,7 @@ alsa_device(const AlsaOutput *ad) static void alsa_configure(AlsaOutput *ad, const struct config_param *param) { - ad->device = config_dup_block_string(param, "device", NULL); + ad->device = config_get_block_string(param, "device", ""); ad->use_mmap = config_get_block_bool(param, "use_mmap", false); -- cgit v1.2.3