aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* added prefix to header macrosMax Kellermann2008-10-31
| | | | | | | "LOG_H" is a macro which is also used by ffmpeg/log.h. This is ffmpeg's fault, because short macros should be reserved for applications, but since it's always a good idea to choose prefixed macro names, even for applications, we are going to do that in MPD.
* client: don't try again after partial writeMax Kellermann2008-10-31
| | | | | After a partial write, chances are vanishing that another write() will succeed. Don't try immediately.
* removed the sllist libraryMax Kellermann2008-10-31
| | | | | The "simple singly-linked-list" library has been replaced with GLib's GList and GQueue.
* client: use GQueue instead of sllist.h for deferred_sendMax Kellermann2008-10-31
| | | | Another custom data structore converted to GLib.
* client: use GSList instead of struct strnode for command listsMax Kellermann2008-10-31
| | | | Replace a custom data structure with a GLib one.
* client: removed list_cacheMax Kellermann2008-10-31
| | | | | | The list cache aims to save memory allocations, and complicates the code a bit. We should rather use GLib slices later, which are easy to use.
* ogg: don't include _flac_common.hMax Kellermann2008-10-31
| | | | | | The source _ogg_common.c does not need any symbols from _flac_common.h, but including it leads to compiler errors when libflac isn't available.
* oggflac: adapt to new APIMax Kellermann2008-10-31
| | | | | Again, I forgot to adapt oggflac to the new API (struct input_stream, bool return values).
* ffmpeg: pass input_stream pointer to decoder_data()Max Kellermann2008-10-30
| | | | | decoder_data() uses wait times to let the input stream continue its transfer.
* ffmpeg: use return value of decoder_data()Max Kellermann2008-10-30
| | | | | decoder_data() always returns the current command. If we use this, we can save a lot of decoder_get_command() calls.
* ffmpeg: output buffer size cannot be negativeMax Kellermann2008-10-30
| | | | Converted the runtime check to an assertion.
* ffmpeg: break immediately after av_read_frame()Max Kellermann2008-10-30
| | | | Remove one indent level.
* ffmpeg: moved code to ffmpeg_send_frame()Max Kellermann2008-10-30
| | | | | Move code from ffmpeg_decode_internal() to make it smaller and more readable.
* ffmpeg: report seek errors to MPDMax Kellermann2008-10-30
| | | | | The decoder API provides the function decoder_seek_error() to report seek errors. Use this function instead of logging the error.
* ffmpeg: simplified mpdurl_read()Max Kellermann2008-10-30
| | | | | The function mpdurl_read() is too complicated, and uses the wrong data types.
* ffmpeg: call tag_free() instead of free()Max Kellermann2008-10-30
| | | | | tag objects must be freed with tag_free() to ensure that all resources are freed.
* ffmpeg: eliminated local variable "tag"Max Kellermann2008-10-30
| | | | | The function ffmpeg_tag() already has the variable base.tag, which can be used for this.
* ffmpeg: make ffmpeg_helper() return boolMax Kellermann2008-10-30
| | | | | ffmpeg_try_decode() did not interpret ffmpeg_helper()'s return value properly; migrate everything to bool to make it consistent.
* ffmpeg: removed debug messagesMax Kellermann2008-10-30
| | | | We don't need those anymore, they just fill the log.
* ffmpeg: initialize base.decoderMax Kellermann2008-10-30
| | | | | ffmpeg_tag() did not initialize base.decoder, which made valgrind unhappy, and can lead to a egmentation fault.
* listen: set file mode 666 on the unix socketMax Kellermann2008-10-30
| | | | | | Depending on MPD's umask, the file permissions of the unix socket were too restrictive, and many clients were not able to connect. Do a chmod(0666) on the socket, to allow everybody to connect.
* pulse: fix segfault without sink nameMax Kellermann2008-10-30
| | | | | Commit d692e9 broke configurations without explicit server or sink configuration. Check for getBlockParam()==NULL.
* mpc: provide 24 bit samplesMax Kellermann2008-10-30
| | | | | | Similar to libmad, libmpcdec provides samples with higher quality than 16 bit. Send 24 bit samples to MPD, which allows MPD to apply dithering just in case the output devices are only 16 bit capable.
* mpc: moved sample size into a constantMax Kellermann2008-10-30
| | | | Don't hard-code the "16 bits" or "2 bytes" in multiple locations.
* mpc: renamed variable "s16" to "dest"Max Kellermann2008-10-30
| | | | | The name "s16" implies 16 bit integers. To make the code more generic, rename it to "dest".
* mpc: fix broken integer sample conversionMax Kellermann2008-10-30
| | | | | | The conversion of integer samples was completely broken, which presumably didn't annoy anybody because libmpcdec provides float samples on most installations.
* mpc: fix boolean interpretation of input_stream_seek()Max Kellermann2008-10-30
| | | | | When input_stream_seek() was converted to return a bool, this wasn't adjusted in the musepack plugin.
* decoder: use bool for return values and flagsMax Kellermann2008-10-30
| | | | | Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
* mp3: make mp3_read() return boolMax Kellermann2008-10-30
| | | | | | | Its only caller in mp3_decode() just compared its value with DECODE_BREAK. Convert that to bool, and return false if the loop should be ended. Also eliminate some superfluous command checking code, which was already done in the preceding while loop.
* output: removed audio_output.resultMax Kellermann2008-10-29
| | | | | Since open() and play() close the device on error, we can simply check audio_output.open instead of audio_output.result after a call.
* output: delay reopen after device failureMax Kellermann2008-10-29
| | | | | | | When one of several output devices failed, MPD tried to reopen it quite often, wasting a lot of resources. This patch adds a delay: wait 10 seconds before retrying. This might be changed to exponential delays later, but for now, it makes the problem go away.
* output: moved code to audio_output_update()Max Kellermann2008-10-29
| | | | Moved code from syncAudioDeviceStates() to audio_output_update().
* output: always call cancel() before stop()Max Kellermann2008-10-29
| | | | | | Stopping an audio output device without cancelling its buffer doesn't make sense. Combine the two operations, which saves several cancel calls.
* input_file: refuse to open non-regular filesMax Kellermann2008-10-29
| | | | | Don't allow users to open a file which is non-regular (e.g. pipes, devices).
* input_file: check fstat() failureMax Kellermann2008-10-29
|
* input_file: use GLib for loggingMax Kellermann2008-10-29
|
* log: don't use utils.hMax Kellermann2008-10-29
| | | | Prefer GLib over utils.h.
* output: moved audioDeviceStates to audio_output.enabledMax Kellermann2008-10-29
|
* output: close device on play errorMax Kellermann2008-10-29
| | | | | When an output plugin fails to play a chunk, close it. This replaces various manual close() calls in nearly all plugins.
* output: use bool for return values and flagsMax Kellermann2008-10-29
| | | | | Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
* audio: call closeAudioDevice() on errorMax Kellermann2008-10-29
| | | | | Instead of implementing another loop which calls audio_output_close() on all configured devices, simply call closeAudioDevice().
* audio: removed variable "audioOpened"Max Kellermann2008-10-29
| | | | This variable is never read, and can be removed.
* pulse: clear pa_simple pointer in pulse_close()Max Kellermann2008-10-29
| | | | | The pointer becomes invalid due to pa_simple_free(), which may lead to segmentation faults when the output is reopened later.
* pulse: use GLib instead of util.h/log.hMax Kellermann2008-10-29
| | | | Use GLib allocation and logging functions.
* pulse: no CamelCaseMax Kellermann2008-10-29
|
* player: handle songs shorter than the initial bufferMax Kellermann2008-10-29
| | | | | | | When the decoder exited before the buffer has grown big enough ("buffer_before_play"), the player thread waited forever. Add an additional check which disables buffering as soon as the decoder exits.
* oss: check and override audio_format properlyMax Kellermann2008-10-29
| | | | | Don't accept 24 bit audio. Force MPD to use 16 bit if anything other than 8 or 16 bit is selected.
* player: added variable "play_audio_format"Max Kellermann2008-10-29
| | | | | | | | | The local variable "play_audio_format" is updated every time the player starts playing a new song. This way, we always know exactly which audio format is current. The old code broke when a new song had a different format: ob.audio_format is the format of the next song, not of the current one - using this caused breakage for the software volume control.
* decoder: automatically flush the output buffer after decoder exitsMax Kellermann2008-10-29
| | | | | | | A decoder_flush() invocation was missing in the FLAC plugin, resulting in casual assertion failures due to a wrong assumption about the last chunk's audio format. It's much easier to remove that decoder_flush() function and make the decoder thread call ob_flush().
* decoder_api: make the audio_format parameter mandatoryMax Kellermann2008-10-29
| | | | | There are no callers which pass audio_format==NULL, and it shouldn't be allowed.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 13:31:12 +0000