aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* archive: close archive when stream is closedMax Kellermann2009-12-15
| | | | | | | | Fixes a memory leak: the "archive" input plugin opens the archive, but never closes it. This patch moves the responsibility for doing that to archive_plugin.open_stream(). This is an slight internal API change, but it is the simplest and least intrusive fix for the memory leak.
* archive/bz2: removed NULL check before g_free()Max Kellermann2009-12-15
| | | | g_free(NULL) is allowed.
* input/archive: close the archive file on errorMax Kellermann2009-12-15
| | | | Fixed memory leak in error handler.
* input/file: don't fall back to parent directoryMax Kellermann2009-12-15
| | | | | This code has never made any sense, and has broken some of the archive plugin.
* decoder/wavpack: don't use the nonstandard "uchar" typeMax Kellermann2009-12-11
| | | | Use the signed C99 type int8_t instead.
* mixer: explicitly close all mixers on shutdownMax Kellermann2009-12-08
| | | | | | Mixers with the "global" flag set aren't closed automatically when the output device is closed. Thus, they might still be open when MPD shuts down.
* mapper: apply filesystem_charset to playlistsMax Kellermann2009-12-08
| | | | | | | | This fixes an inconsistency in the stored playlist subsystem: when obtaining the list of playlists (listplaylist, listplaylistinfo), the file names in the playlist directory are converted to UTF-8 (according to filesystem_charset), but when saving or loading playlists, the filesystem_charset setting was ignored.
* command: verify playlist name in the "rm" commandMax Kellermann2009-12-08
| | | | Call spl_valid_name() in spl_delete().
* mapper: fix memory leak when playlist_directory is not setMax Kellermann2009-12-08
| | | | Don't allocate the file name before the playlist_dir==NULL check.
* tag_id3: fix ID3v1 charset conversionsvitoos2009-11-30
| | | | | If we define id3v1_encoding, then the tags are not added to the database.
* ffmpeg: don't try to force stereoMax Kellermann2009-11-30
| | | | | | The plugin code tried to force libavcodec to supply stereo samples. That however has never actually worked. By removing this code, we are able to play surround files for the first time.
* decoder/flac: fixed compiler warningMax Kellermann2009-11-19
| | | | | | Removed the "vtrack" local variable (which triggered a gcc warning because it was after the newly introduced NULL check), and run strtol() on the original parameter.
* decoder/flac: fixed NULL pointer dereference in CUE codeMax Kellermann2009-11-18
| | | | The function flac_vtrack_tnum() was missing a strrchr()==NULL check.
* id3: allow 4 MB RIFF/AIFF tagsMax Kellermann2009-11-15
| | | | | | | Allow RIFF/AIFF ID3 tags up to 4 MB (old limit was 256 kB). This might still be too small for some users, and when somebody complains, we might do something more clever (like streaming the data into libid3tag?).
* decoder/ffmpeg: align the output bufferMax Kellermann2009-11-15
| | | | | | On some platforms, libavcodec wants the output buffer aligned to 16 bytes (because it uses SSE/Altivec internally). It will segfault when you don't obey this rule.
* decoder/flac: fixed CUE seeking range checkMax Kellermann2009-11-11
| | | | | | If flac_container_decode() gets a seek destination which is out of range, it ignores the SEEK command (never finishes it). This leads to MPD lockup, because the player thread waits for completion.
* oggflac: rewind stream after FLAC detectionMax Kellermann2009-11-11
| | | | | The oggflac plugin has been completely broken for quite a while and nobody has noticed - maybe we should remove it?
* sticker: added fallback for sqlite3_prepare_v2()Max Kellermann2009-11-10
| | | | This function was not present in SQLite < 3.4.
* input/lastfm: fixed variable name in GLib<2.16 code pathMax Kellermann2009-11-10
| | | | Should be "lastfm_user", not "lastfm_username".
* song_save: increased maximum line length to 32 kBMax Kellermann2009-11-01
| | | | | | | The line buffer had a fixed size of 5 kB, and was allocated on the stack. This was too small for some users. As a hotfix, we're increasing the buffer size to 32 kB now, allocated on the heap. In MPD 0.16, we'll switch to dynamic allocation.
* decoder_control: removed unused DECODE_TYPE macrosMax Kellermann2009-10-31
|
* decoder/ffmpeg: convert metadataMax Kellermann2009-10-28
| | | | | | Convert the metadata with the libavformat function av_metadata_conv(). This ensures that canonical tag names are provided by libavformat, and we can remove the "artist" vs "author" workaround.
* update: delete ignored symlinks from databaseMax Kellermann2009-10-27
| | | | | | When you disable the "follow_outside_symlinks" or the "follow_inside_symlinks" setting, the next update should remove the now-ignored files from the database.
* output_thread: check again if output is open on PAUSEMax Kellermann2009-10-21
| | | | | Basically the same as the 0.15.5 patch "check again if output is open on CANCEL". Same race condition, same fix.
* decoder/flac: fixed two memory leaks in the CUE tag loaderMax Kellermann2009-10-16
| | | | | | Don't initialize "vc" and "cs" with FLAC__metadata_object_new(); that value is overwritten by FLAC__metadata_get_tags() and FLAC__metadata_get_cuesheet().
* update: fixed memory leak during container scanMax Kellermann2009-10-16
| | | | The return value of map_directory_child_fs() must be freed.
* update: song_file_new() cannot failMax Kellermann2009-10-16
| | | | | Removed the NULL check. If that NULL check was correct, that would have been a memory leak (vtrack).
* output_thread: check again if output is open on CANCELMax Kellermann2009-10-16
| | | | | | | | When the player thread unpauses, it sends CANCEL to the output thread, after having checked that the output is still open. Problem is when the output thread closes the device before it can process the CANCEL command - race condition. This patch adds another "open" check inside the output thread.
* input/curl: fixed endless loop during bufferingMax Kellermann2009-10-13
| | | | | | | When the connection is lost while buffering, the CURL input plugin may enter an endless loop, because it does not check the EOF condition. This patch makes fill_buffer() return success only if there's at least one buffer, which is enough of a check.x
* riff, aiff: fixed "limited range" gcc warningMax Kellermann2009-10-11
| | | | | | On 32 bit systems with large file support enabled (i.e. "sizeof(off_t) > sizeof(size_t)") gcc emits a warning because a size_t cast to off_t can never become negative.
* decoder_thread: change the fallback decoder name to "mad"Max Kellermann2009-10-11
| | | | | | When there is no Content-Type response header, try the "mad" decoder plugin. It uesd to be named "mp3", and we forgot to change the fallback name in decoder_thread.c.
* input/curl: don't abort if a packet has only metadataMax Kellermann2009-10-11
| | | | | | | | | When a received chunk of data has only icy-metadata, there was no usable data left for input_curl_read() to return, and thus it returned 0 bytes. "0" however is a special value for "end of file" or "error". This patch makes input_curl_read() read more data from the socket, until the read request can be fulfilled (or until there's really EOF).
* input/curl: moved code to fill_buffer()Max Kellermann2009-10-11
|
* decoder/ffmpeg: use the "artist" tag if "author" is not presentMax Kellermann2009-09-30
| | | | | | | Usually, we read our "artist" tag from ffmpeg's "author" tag. In some cases however (e.g. APE), this tag is named "artist". This patch implements a fallback: if no "author" is found, MPD tries to use "artist".
* decoder/faad: skip assertion failure on large ID3 tagsMax Kellermann2009-09-30
| | | | | | When the ID3 tag in an AAC file is larger than the current buffer, the function decoder_buffer_consume() aborts. By using the new function decoder_buffer_skip() instead, we can safely skip the ID3 tag.
* decoder_buffer: added function decoder_buffer_skip()Max Kellermann2009-09-30
|
* input/mms: fix G_LOG_DOMAIN valueSerge Ziryukin2009-09-20
|
* output/osx: fix the OS X 10.6 buildPatrik Weiskircher2009-09-20
| | | | Include CoreServices/CoreServices.h.
* decoder/vorbis: revert "faster tag scanning with ov_test_callback()"Max Kellermann2009-09-10
| | | | | This patch made ov_time_total() unusable, and MPD did not know the duration of songs.
* decoder/vorbis: faster tag scanning with ov_test_callback()Rasmus Steinke2009-08-24
| | | | | | | | | using ov_test_callback with function CALLBACKS_STREAMONLY will cause scanning to stop after the comment field. ov_open (and ov_test) default to CALLBACKS_DEFAULT which scans the file structure causing a huge slowdown. The speed improvement is huge: It scanned my files around 10x faster This procedure has been recommended by monthy (main vorbis developer) and was said to be safe for scanning files.
* update: don't re-read unchanged container filesIgor Kuzmin2009-08-19
| | | | | | | MPD checks if every flac (possibly other types as well) file contains cuesheet on every update, which produces unneeded I/O. My music collection is on NFS share, so it's quite noticeable. IMHO, it shouldn't re-read unchanged files, so I wrote simple patch to fix it.
* output_init: initialize the "pause" flagMax Kellermann2009-08-18
| | | | Fix stuttering due to uninitialized variable.
* output/shout: minimize the unpause latencyMax Kellermann2009-08-14
| | | | | During the pause loop, manually sleep for 500ms if shout_delay() returns a value greater than that. Don't exhaust libshout's buffer.
* output: fixed shout stuck pause bugMax Kellermann2009-08-14
| | | | | | Explicitly make the output thread leave the ao_pause() loop. This patch is a workaround, and the "pause" flag is not managed in a thread-safe way, but that's good enough for now.
* directory: free empty directories after removing them (memleak)Max Kellermann2009-08-14
| | | | | dirvec_delete() does not free the object, we have to call directory_free() afterwards.
* update: free temporary string in container scan (memleak)Max Kellermann2009-08-14
| | | | The return value of map_directory_child_fs() must be freed.
* decoder/flac: don't allocate cuesheet twice (memleak)Max Kellermann2009-08-14
| | | | | | | The function flac_cue_track() first calls FLAC__metadata_object_new(), then overwrites this pointer with FLAC__metadata_get_cuesheet(). This allocate two FLAC__StreamMetadata objects, but the first pointer is lost, and never freed.
* update: free empty path string (memleak)Max Kellermann2009-08-14
| | | | | When you pass an empty string to directory_update_init(), it was not freed by update_task().
* decoder/flac: fixed indentation of flac_comment_value()Max Kellermann2009-07-22
|
* decoder/flac: parse all replaygain tagsMax Kellermann2009-07-22
| | | | | The FLAC replaygain parser used the "||" operator. This made the code stop after the first value which was found.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-02 17:12:39 +0000