aboutsummaryrefslogtreecommitdiff
path: root/src/stored_playlist.c
Commit message (Collapse)AuthorAge
* stored_playlist: return GError, code is playlist_resultMax Kellermann2011-09-11
| | | | | Improve error reporting and handling. command.c gets the new function print_error(), which sends a GError to the client.
* playlist: move PLAYLIST_COMMENT to stored_playlist.cMax Kellermann2011-09-11
| | | | Only used there.
* copyright year 2011Max Kellermann2011-01-29
|
* stored_playlist: remove database lookups from spl_load()Max Kellermann2010-12-23
| | | | Don't look up songs in the database, no caller needs this.
* stored_playlist: ignore empty linesMax Kellermann2010-12-23
|
* stored_playlist: use the text_file library to read linesMax Kellermann2010-12-23
|
* database, ...: remove EINTR checks after stdio callsMax Kellermann2010-07-25
| | | | | | MPD doesn't have child processes anymore, and thus we're not expecting to receive SIGCHLD very often. Since hard disk access isn't interrupted by signals anyway, we don't need those excessive checks.
* Update copyright notices.Avuton Olrich2009-12-31
|
* Merge branch 'v0.15.x'Max Kellermann2009-12-14
|\ | | | | | | | | Conflicts: src/decoder/ffmpeg_plugin.c
| * mapper: apply filesystem_charset to playlistsMax Kellermann2009-12-08
| | | | | | | | | | | | | | | | This fixes an inconsistency in the stored playlist subsystem: when obtaining the list of playlists (listplaylist, listplaylistinfo), the file names in the playlist directory are converted to UTF-8 (according to filesystem_charset), but when saving or loading playlists, the filesystem_charset setting was ignored.
| * command: verify playlist name in the "rm" commandMax Kellermann2009-12-08
| | | | | | | | Call spl_valid_name() in spl_delete().
* | include config.h in all sourcesMax Kellermann2009-11-12
|/ | | | | | After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
* stored_playlist: don't close NULL file on errorMax Kellermann2009-04-24
| | | | | spl_append_song() can crash when fopen() fails, because it attempts to close the invalid file handle (NULL) in the error handler.
* all: Update copyright header.Avuton Olrich2009-03-13
| | | | | | | | This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
* ls: moved generic URI utilities to uri.cMax Kellermann2009-02-25
| | | | | "ls" is a bad name for a library which parses URIs. We'll move the rest of the "ls" library later.
* playlist: moved is_valid_playlist_name() to stored_playlist.cMax Kellermann2009-01-25
|
* stored_playlist: moved configuration variables from playlist.cMax Kellermann2009-01-25
| | | | | Don't declare and export variables specific to stored playlists in playlist.c/playlist.h.
* mapper: added dot to PLAYLIST_FILE_SUFFIXMax Kellermann2009-01-25
| | | | | Some code will be a little bit simpler if the dot is part of the string literal.
* mapper: make the playlist directory optionalMax Kellermann2009-01-18
|
* path: allocate buffer in fs_charset conversion functionsMax Kellermann2009-01-08
| | | | | Don't use fixed static buffers. GLib allocates a new string for us anyway, let's just return this one instead of copying it.
* path: removed pfx_dir()Max Kellermann2009-01-04
| | | | Use GLib's g_build_filename() instead of pfx_dir().
* song: allocate the result of song_get_url()Max Kellermann2009-01-04
|
* mapper: allocate the result of map_fs_to_utf8()Max Kellermann2009-01-04
|
* playlist: use uri_has_scheme() instead of isRemoteUrl()Max Kellermann2009-01-04
| | | | | | For internal checks (i.e. not in command.c), we need to check whether an URI is in the databse, in the local file system or a remote URI with a scheme.
* playlist: use GLib instead of utils.hMax Kellermann2009-01-02
|
* playlist: use g_file_test() instead of stat()Max Kellermann2009-01-01
| | | | | To find out whether a file exists, use g_file_test() instead of stat(), because it is more portable and easier to use.
* mapper: allocate playlist path from heapMax Kellermann2009-01-01
| | | | Don't pass a static buffer to map_spl_utf8_to_fs().
* removed os_compat.hMax Kellermann2008-12-29
| | | | | Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
* utils: removed myFgets()Max Kellermann2008-12-28
| | | | Replaced myFgets() with fgets() + g_strchomp().
* stored_playlist: fix integer overflow in length estimationMax Kellermann2008-12-24
| | | | | | | With a large maximum playlist length, the integer multiplication "playlist_max_length * MPD_PATH_MAX" may overflow. Change that to a division. This was not a dangerous bug, since it was only used for a quick estimate.
* ls: removed isValidRemoteUtf8Url()Max Kellermann2008-12-16
| | | | | The function didn't do anything useful, it was just several lines obfuscating that it was only forwarding isRemoteUrl()'s return value.
* path: moved playlist_dir to mapper.cMax Kellermann2008-10-31
| | | | | Added the function map_spl_utf8_to_fs() which replaces utf8_to_fs_playlist_path().
* stored_playlist: fixed signed comparison warningMax Kellermann2008-10-26
| | | | Cast playlist_max_length to off_t before comparing it to stat.st_size.
* stored_playlist: emit idle event on deleteMax Kellermann2008-10-23
| | | | The "rm" command did not send notifications to idle clients. Add it.
* stored_playlist: renamed and moved spl_delete() to stored_playlist.cMax Kellermann2008-10-23
| | | | The function deletePlaylist() shouldn't be in playlist.c.
* stored_playlist: spl_load() returns GPtrArrayMax Kellermann2008-10-23
| | | | | Don't use our deprecated linked list library, use GLib's GPtrArray instead.
* stored_playlist: unsigned index argumentsMax Kellermann2008-10-23
| | | | | | Pass index arguments as unsigned integers. They must not be negative, and even if some caller accidently passes -1, it won't pass the bound checks (since it's now 2**32-1).
* stored_playlist: added spl_list()Max Kellermann2008-10-22
| | | | | | spl_list() provides an interface for enumerating all stored playlists. This separates the internal playlist logic from the protocol specific function lsPlaylists().
* stored_playlist: spl_append_uri() returns enum playlist_resultMax Kellermann2008-10-22
| | | | | The return value of spl_append_uri() was somewhat buggy: some branches returned ACK_* values, and some an enum playlist_result. Unify this.
* stored_playlist: de-CamelCase moved functionMax Kellermann2008-10-22
| | | | | Rename addToStoredPlaylist() to spl_append_uri(), and remove the clearStoredPlaylist() macro.
* stored_playlist: moved functions from playlist.cMax Kellermann2008-10-22
| | | | | | The two functions clearStoredPlaylist() and addToStoredPlaylist() don't belong into playlist.c. clearStoredPlaylist() was a wrapper for spl_clear(), and is converted into a CPP macro for now.
* stored_playlist: no CamelCaseMax Kellermann2008-10-22
| | | | Renamed all public functions, prefix is "spl_".
* renamed storedPlaylist.c to stored_playlist.cMax Kellermann2008-10-22
No CamelCase in file names.
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-26 09:53:06 +0000