diff options
| author | Max Kellermann <max@duempel.org> | 2012-07-10 01:14:43 +0200 |
|---|---|---|
| committer | Anton Khirnov <anton@khirnov.net> | 2013-11-04 10:52:50 +0100 |
| commit | 77b31e1e2004fbe83c7bce2faf11818ff7b7e4b0 (patch) | |
| tree | e8c498286aed44e2085443749d26aee231baeb00 | |
| parent | 38cefdeca1bf172f7ed035f0ee285d91741d21f4 (diff) | |
output_init: put the "convert" filter at the end of the list
No, really! This fixes a regression of commit 74617389, which
changed the order of filter plugins.
| -rw-r--r-- | NEWS | 2 | ||||
| -rw-r--r-- | src/output_init.c | 14 |
2 files changed, 9 insertions, 7 deletions
@@ -1,6 +1,8 @@ ver 0.17.1 (2012/??/??) * protocol: - require appropriate permissions for searchadd{,pl} +* output: + - fix noisy playback with conversion and software volume ver 0.17 (2012/06/27) * protocol: diff --git a/src/output_init.c b/src/output_init.c index d2c86bfa..c3b808e9 100644 --- a/src/output_init.c +++ b/src/output_init.c @@ -213,13 +213,6 @@ ao_base_init(struct audio_output *ao, ao->replay_gain_filter = NULL; ao->other_replay_gain_filter = NULL; - /* the "convert" filter must be the last one in the chain */ - - ao->convert_filter = filter_new(&convert_filter_plugin, NULL, NULL); - assert(ao->convert_filter != NULL); - - filter_chain_append(ao->filter, ao->convert_filter); - /* done */ return true; @@ -280,6 +273,13 @@ audio_output_setup(struct audio_output *ao, const struct config_param *param, return false; } + /* the "convert" filter must be the last one in the chain */ + + ao->convert_filter = filter_new(&convert_filter_plugin, NULL, NULL); + assert(ao->convert_filter != NULL); + + filter_chain_append(ao->filter, ao->convert_filter); + return true; } |