From 5e6ce28dabe002a6130f17b59c454bdee33088f7 Mon Sep 17 00:00:00 2001 From: Chris Cunningham Date: Tue, 1 Dec 2015 10:54:38 -0800 Subject: avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files. "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast seek is not precise, so continue to prefer the TOC when available (the lesser of two evils). Also, some re-ordering of the logic in mp3_seek to simplify and give usetoc=1 precedence over fastseek flag. Signed-off-by: wm4 --- tests/fate/seek.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/fate/seek.mak b/tests/fate/seek.mak index dfb2e84a1e..a229e72bd7 100644 --- a/tests/fate/seek.mak +++ b/tests/fate/seek.mak @@ -244,7 +244,7 @@ FATE_SEEK += $(FATE_SEEK_LAVF-yes:%=fate-seek-lavf-%) # extra files FATE_SEEK_EXTRA-$(CONFIG_MP3_DEMUXER) += fate-seek-extra-mp3 -fate-seek-extra-mp3: CMD = run libavformat/seek-test$(EXESUF) $(TARGET_SAMPLES)/gapless/gapless.mp3 -usetoc 0 +fate-seek-extra-mp3: CMD = run libavformat/seek-test$(EXESUF) $(TARGET_SAMPLES)/gapless/gapless.mp3 -fastseek 1 FATE_SEEK_EXTRA += $(FATE_SEEK_EXTRA-yes) -- cgit v1.2.3