From f3866a14c3c2949fad16267e9f2977ba9d7b5504 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Date: Sun, 8 Nov 2015 15:15:24 +0100
Subject: softfloat: assert when the argument of av_sqrt_sf is negative

The correct result can't be expressed in SoftFloat.
Currently it returns a random value from an out of bounds read.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
---
 libavutil/softfloat.h | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'libavutil')

diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h
index 651bbf4111..4cc3ceb646 100644
--- a/libavutil/softfloat.h
+++ b/libavutil/softfloat.h
@@ -174,6 +174,8 @@ static av_always_inline SoftFloat av_sqrt_sf(SoftFloat val)
 
     if (val.mant == 0)
         val.exp = MIN_EXP;
+    else if (val.mant < 0)
+        av_assert0(0);
     else
     {
         tabIndex = (val.mant - 0x20000000) >> 20;
-- 
cgit v1.2.3