From 94fadd335bd1405b6fad7c8d0a249c78bd475ff9 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 19 Feb 2024 19:10:09 +0100 Subject: avformat/iamf_writer: Don't leak on error when adding ParamDefinition Fix this by postponing the allocation. Fixes Coverity issue #1559545. Reviewed-by: James Almer Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'libavformat') diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 1a360dee2f..897b06310f 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c @@ -138,10 +138,6 @@ static IAMFParamDefinition *add_param_definition(IAMFContext *iamf, AVIAMFParamD iamf->param_definitions = tmp; - param_definition = av_mallocz(sizeof(*param_definition)); - if (!param_definition) - return NULL; - if (audio_element) codec_config = iamf->codec_configs[audio_element->codec_config_id]; @@ -160,6 +156,10 @@ static IAMFParamDefinition *add_param_definition(IAMFContext *iamf, AVIAMFParamD param->constant_subblock_duration = codec_config->nb_samples; } + param_definition = av_mallocz(sizeof(*param_definition)); + if (!param_definition) + return NULL; + param_definition->mode = !!param->duration; param_definition->param = param; param_definition->audio_element = audio_element; -- cgit v1.2.3