From 9c0b3eddf4262f9dcea479091f1307444e614e88 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 14 Feb 2021 22:24:46 +0100 Subject: avformat/utils: Fix undefined NULL + 0 This is undefined behaviour in C, so use data = len ? data + len : data instead of data += len. GCC optimizes the branch away in this case; Clang unfortunately doesn't. Fixes ticket #8592. Reviewed-by: Paul B Mahol Signed-off-by: Andreas Rheinhardt --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libavformat/utils.c') diff --git a/libavformat/utils.c b/libavformat/utils.c index 3e955b85bc..cea6d4ca92 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1426,7 +1426,7 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, pkt->pts = pkt->dts = AV_NOPTS_VALUE; pkt->pos = -1; /* increment read pointer */ - data += len; + data = len ? data + len : data; size -= len; got_output = !!out_pkt.size; -- cgit v1.2.3