From a9c847c1baff09f954b12c1dcc832b4f601f6f6e Mon Sep 17 00:00:00 2001 From: Martin Storsjö Date: Thu, 17 Jan 2013 15:08:03 +0200 Subject: rtpdec: Split handling of mpeg12 audio/video to a separate depacketizer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This also adds checking of mallocs. Signed-off-by: Martin Storsjö --- libavformat/rtpdec_mpeg12.c | 62 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 libavformat/rtpdec_mpeg12.c (limited to 'libavformat/rtpdec_mpeg12.c') diff --git a/libavformat/rtpdec_mpeg12.c b/libavformat/rtpdec_mpeg12.c new file mode 100644 index 0000000000..d111469364 --- /dev/null +++ b/libavformat/rtpdec_mpeg12.c @@ -0,0 +1,62 @@ +/* + * Common code for the RTP depacketization of MPEG-1/2 formats. + * Copyright (c) 2002 Fabrice Bellard + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * Libav is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with Libav; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "rtpdec_formats.h" +#include "libavutil/intreadwrite.h" + +static int mpeg_parse_packet(AVFormatContext *ctx, PayloadContext *data, + AVStream *st, AVPacket *pkt, uint32_t *timestamp, + const uint8_t *buf, int len, uint16_t seq, + int flags) +{ + unsigned int h; + if (len <= 4) + return AVERROR_INVALIDDATA; + h = AV_RB32(buf); + buf += 4; + len -= 4; + if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO && h & (1 << 26)) { + /* MPEG-2 */ + if (len <= 4) + return AVERROR_INVALIDDATA; + buf += 4; + len -= 4; + } + if (av_new_packet(pkt, len) < 0) + return AVERROR(ENOMEM); + memcpy(pkt->data, buf, len); + pkt->stream_index = st->index; + return 0; +} + +RTPDynamicProtocolHandler ff_mpeg_audio_dynamic_handler = { + .codec_type = AVMEDIA_TYPE_AUDIO, + .codec_id = AV_CODEC_ID_MP3, + .parse_packet = mpeg_parse_packet, + .static_payload_id = 14, +}; + +RTPDynamicProtocolHandler ff_mpeg_video_dynamic_handler = { + .codec_type = AVMEDIA_TYPE_VIDEO, + .codec_id = AV_CODEC_ID_MPEG2VIDEO, + .parse_packet = mpeg_parse_packet, + .static_payload_id = 32, +}; -- cgit v1.2.3 From c6f1dc8e4cd967ae056698eafb891a08003c211c Mon Sep 17 00:00:00 2001 From: Martin Storsjö Date: Thu, 17 Jan 2013 15:29:12 +0200 Subject: rtpdec: Move setting the parsing flags to the actual depacketizers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This gets rid of almost all the codec specific details from the generic rtpdec code. Signed-off-by: Martin Storsjö --- libavformat/rtpdec.c | 12 ------------ libavformat/rtpdec_h263.c | 10 ++++++++++ libavformat/rtpdec_h263_rfc2190.c | 9 +++++++++ libavformat/rtpdec_h264.c | 9 +++++++++ libavformat/rtpdec_mpeg12.c | 10 ++++++++++ libavformat/rtpdec_mpeg4.c | 9 +++++++++ libavformat/rtpdec_xiph.c | 11 +++++++++++ 7 files changed, 58 insertions(+), 12 deletions(-) (limited to 'libavformat/rtpdec_mpeg12.c') diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c index 38bd333e9c..4379e6f4f1 100644 --- a/libavformat/rtpdec.c +++ b/libavformat/rtpdec.c @@ -502,18 +502,6 @@ RTPDemuxContext *ff_rtp_parse_open(AVFormatContext *s1, AVStream *st, rtp_init_statistics(&s->statistics, 0); if (st) { switch (st->codec->codec_id) { - case AV_CODEC_ID_MPEG1VIDEO: - case AV_CODEC_ID_MPEG2VIDEO: - case AV_CODEC_ID_MP2: - case AV_CODEC_ID_MP3: - case AV_CODEC_ID_MPEG4: - case AV_CODEC_ID_H263: - case AV_CODEC_ID_H264: - st->need_parsing = AVSTREAM_PARSE_FULL; - break; - case AV_CODEC_ID_VORBIS: - st->need_parsing = AVSTREAM_PARSE_HEADERS; - break; case AV_CODEC_ID_ADPCM_G722: /* According to RFC 3551, the stream clock rate is 8000 * even if the sample rate is 16000. */ diff --git a/libavformat/rtpdec_h263.c b/libavformat/rtpdec_h263.c index bdb5195396..4b3443bd01 100644 --- a/libavformat/rtpdec_h263.c +++ b/libavformat/rtpdec_h263.c @@ -23,6 +23,14 @@ #include "rtpdec_formats.h" #include "libavutil/intreadwrite.h" +static int h263_init(AVFormatContext *ctx, int st_index, PayloadContext *data) +{ + if (st_index < 0) + return 0; + ctx->streams[st_index]->need_parsing = AVSTREAM_PARSE_FULL; + return 0; +} + int ff_h263_handle_packet(AVFormatContext *ctx, PayloadContext *data, AVStream *st, AVPacket *pkt, uint32_t *timestamp, const uint8_t *buf, int len, uint16_t seq, int flags) @@ -92,6 +100,7 @@ RTPDynamicProtocolHandler ff_h263_1998_dynamic_handler = { .enc_name = "H263-1998", .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_H263, + .init = h263_init, .parse_packet = ff_h263_handle_packet, }; @@ -99,5 +108,6 @@ RTPDynamicProtocolHandler ff_h263_2000_dynamic_handler = { .enc_name = "H263-2000", .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_H263, + .init = h263_init, .parse_packet = ff_h263_handle_packet, }; diff --git a/libavformat/rtpdec_h263_rfc2190.c b/libavformat/rtpdec_h263_rfc2190.c index 4792a9fdc5..4b6e996770 100644 --- a/libavformat/rtpdec_h263_rfc2190.c +++ b/libavformat/rtpdec_h263_rfc2190.c @@ -55,6 +55,14 @@ static void h263_free_context(PayloadContext *data) av_free(data); } +static int h263_init(AVFormatContext *ctx, int st_index, PayloadContext *data) +{ + if (st_index < 0) + return 0; + ctx->streams[st_index]->need_parsing = AVSTREAM_PARSE_FULL; + return 0; +} + static int h263_handle_packet(AVFormatContext *ctx, PayloadContext *data, AVStream *st, AVPacket *pkt, uint32_t *timestamp, const uint8_t *buf, int len, uint16_t seq, @@ -198,6 +206,7 @@ static int h263_handle_packet(AVFormatContext *ctx, PayloadContext *data, RTPDynamicProtocolHandler ff_h263_rfc2190_dynamic_handler = { .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_H263, + .init = h263_init, .parse_packet = h263_handle_packet, .alloc = h263_new_context, .free = h263_free_context, diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 2df0930f61..d619e60dd9 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -338,6 +338,14 @@ static void h264_free_context(PayloadContext *data) av_free(data); } +static int h264_init(AVFormatContext *s, int st_index, PayloadContext *data) +{ + if (st_index < 0) + return 0; + s->streams[st_index]->need_parsing = AVSTREAM_PARSE_FULL; + return 0; +} + static int parse_h264_sdp_line(AVFormatContext *s, int st_index, PayloadContext *h264_data, const char *line) { @@ -383,6 +391,7 @@ RTPDynamicProtocolHandler ff_h264_dynamic_handler = { .enc_name = "H264", .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_H264, + .init = h264_init, .parse_sdp_a_line = parse_h264_sdp_line, .alloc = h264_new_context, .free = h264_free_context, diff --git a/libavformat/rtpdec_mpeg12.c b/libavformat/rtpdec_mpeg12.c index d111469364..4dd98fba35 100644 --- a/libavformat/rtpdec_mpeg12.c +++ b/libavformat/rtpdec_mpeg12.c @@ -22,6 +22,14 @@ #include "rtpdec_formats.h" #include "libavutil/intreadwrite.h" +static int mpeg_init(AVFormatContext *ctx, int st_index, PayloadContext *data) +{ + if (st_index < 0) + return 0; + ctx->streams[st_index]->need_parsing = AVSTREAM_PARSE_FULL; + return 0; +} + static int mpeg_parse_packet(AVFormatContext *ctx, PayloadContext *data, AVStream *st, AVPacket *pkt, uint32_t *timestamp, const uint8_t *buf, int len, uint16_t seq, @@ -50,6 +58,7 @@ static int mpeg_parse_packet(AVFormatContext *ctx, PayloadContext *data, RTPDynamicProtocolHandler ff_mpeg_audio_dynamic_handler = { .codec_type = AVMEDIA_TYPE_AUDIO, .codec_id = AV_CODEC_ID_MP3, + .init = mpeg_init, .parse_packet = mpeg_parse_packet, .static_payload_id = 14, }; @@ -57,6 +66,7 @@ RTPDynamicProtocolHandler ff_mpeg_audio_dynamic_handler = { RTPDynamicProtocolHandler ff_mpeg_video_dynamic_handler = { .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_MPEG2VIDEO, + .init = mpeg_init, .parse_packet = mpeg_parse_packet, .static_payload_id = 32, }; diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c index 0172b5b6b5..c2cedcc210 100644 --- a/libavformat/rtpdec_mpeg4.c +++ b/libavformat/rtpdec_mpeg4.c @@ -252,10 +252,19 @@ static int parse_sdp_line(AVFormatContext *s, int st_index, return 0; } +static int init_video(AVFormatContext *s, int st_index, PayloadContext *data) +{ + if (st_index < 0) + return 0; + s->streams[st_index]->need_parsing = AVSTREAM_PARSE_FULL; + return 0; +} + RTPDynamicProtocolHandler ff_mp4v_es_dynamic_handler = { .enc_name = "MP4V-ES", .codec_type = AVMEDIA_TYPE_VIDEO, .codec_id = AV_CODEC_ID_MPEG4, + .init = init_video, .parse_sdp_a_line = parse_sdp_line, }; diff --git a/libavformat/rtpdec_xiph.c b/libavformat/rtpdec_xiph.c index db39462f4a..8bfe65d44a 100644 --- a/libavformat/rtpdec_xiph.c +++ b/libavformat/rtpdec_xiph.c @@ -70,6 +70,16 @@ static void xiph_free_context(PayloadContext * data) av_free(data); } +static int xiph_vorbis_init(AVFormatContext *ctx, int st_index, + PayloadContext *data) +{ + if (st_index < 0) + return 0; + ctx->streams[st_index]->need_parsing = AVSTREAM_PARSE_HEADERS; + return 0; +} + + static int xiph_handle_packet(AVFormatContext *ctx, PayloadContext *data, AVStream *st, AVPacket *pkt, uint32_t *timestamp, const uint8_t *buf, int len, uint16_t seq, @@ -392,6 +402,7 @@ RTPDynamicProtocolHandler ff_vorbis_dynamic_handler = { .enc_name = "vorbis", .codec_type = AVMEDIA_TYPE_AUDIO, .codec_id = AV_CODEC_ID_VORBIS, + .init = xiph_vorbis_init, .parse_sdp_a_line = xiph_parse_sdp_line, .alloc = xiph_new_context, .free = xiph_free_context, -- cgit v1.2.3