From 8b5b756c4d78c80051d23f2e95d21de01d74cd1f Mon Sep 17 00:00:00 2001 From: James Almer Date: Thu, 16 Jun 2016 19:10:42 -0300 Subject: avformat/oggparsevorbis: use the base64 decode size macro Allocate the memory needed for the decoded data rather than the encoded data. Signed-off-by: James Almer --- libavformat/oggparsevorbis.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'libavformat/oggparsevorbis.c') diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c index a8cd6c9f97..c16871873e 100644 --- a/libavformat/oggparsevorbis.c +++ b/libavformat/oggparsevorbis.c @@ -152,8 +152,8 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m, * recommended way of embedding cover art within VorbisComments." */ if (!strcmp(tt, "METADATA_BLOCK_PICTURE") && parse_picture) { - int ret; - char *pict = av_malloc(vl); + int ret, len = AV_BASE64_DECODE_SIZE(vl); + char *pict = av_malloc(len); if (!pict) { av_log(as, AV_LOG_WARNING, "out-of-memory error. Skipping cover art block.\n"); @@ -161,7 +161,7 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m, av_freep(&ct); continue; } - if ((ret = av_base64_decode(pict, ct, vl)) > 0) + if ((ret = av_base64_decode(pict, ct, len)) > 0) ret = ff_flac_parse_picture(as, pict, ret); av_freep(&tt); av_freep(&ct); -- cgit v1.2.3