From db68ef898a3802e51b6f41fd600d0d46d058e3f8 Mon Sep 17 00:00:00 2001 From: Andrew Stone Date: Tue, 12 Aug 2014 17:03:55 -0400 Subject: ogg: update event_flags with STREAM_/METADATA_UPDATED whenever metadata changes. Originally, AVFormatContext and a metadata dict were provided to ff_vorbis_comment(), but this presented issues if an AVStream was being updated or the metadata on AVFormatContext wasn't actually being updated. To remedy this, ff_vorbis_stream_comment() explicitly updates a stream's metadata and sets any necessary flags. ff_vorbis_comment() does not modify any flags, and any calls to it that update AVFormatContext's metadata (just a single call) must also update AVFormatContext.event_flags after detecting any metadata changes to the provided dictionary, as signaled by a positive return value. Signed-off-by: Anton Khirnov --- libavformat/oggparseflac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libavformat/oggparseflac.c') diff --git a/libavformat/oggparseflac.c b/libavformat/oggparseflac.c index 7808aad80c..f9c15f9a6d 100644 --- a/libavformat/oggparseflac.c +++ b/libavformat/oggparseflac.c @@ -69,7 +69,7 @@ flac_header (AVFormatContext * s, int idx) avpriv_set_pts_info(st, 64, 1, st->codec->sample_rate); } else if (mdt == FLAC_METADATA_TYPE_VORBIS_COMMENT) { - ff_vorbis_comment (s, &st->metadata, os->buf + os->pstart + 4, os->psize - 4, 1); + ff_vorbis_stream_comment(s, st, os->buf + os->pstart + 4, os->psize - 4); } return 1; -- cgit v1.2.3